From: Greg KH <gregkh@linuxfoundation.org>
To: Lijun Pan <Lijun.Pan@freescale.com>
Cc: arnd@arndb.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, stuart.yoder@freescale.com,
itai.katz@freescale.com, german.rivera@freescale.com,
leoli@freescale.com, scottwood@freescale.com, agraf@suse.de,
bhamciu1@freescale.com, R89243@freescale.com,
bhupesh.sharma@freescale.com, nir.erez@freescale.com,
richard.schmitt@freescale.com, dan.carpenter@oracle.com
Subject: Re: [PATCH 2/5] staging: fsl-mc: define a macro to differentiate root dprc
Date: Mon, 26 Oct 2015 09:12:42 +0900 [thread overview]
Message-ID: <20151026001242.GA20331@kroah.com> (raw)
In-Reply-To: <1445812883-23551-3-git-send-email-Lijun.Pan@freescale.com>
On Sun, Oct 25, 2015 at 05:41:20PM -0500, Lijun Pan wrote:
> Define is_root_dprc(dev) to tell whether a device is
> root dprc or not via platform_bus_type.
>
> Signed-off-by: Lijun Pan <Lijun.Pan@freescale.com>
> ---
> drivers/staging/fsl-mc/include/mc.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
> index a933291..483763e 100644
> --- a/drivers/staging/fsl-mc/include/mc.h
> +++ b/drivers/staging/fsl-mc/include/mc.h
> @@ -14,6 +14,7 @@
> #include <linux/device.h>
> #include <linux/mod_devicetable.h>
> #include <linux/list.h>
> +#include <linux/platform_device.h>
> #include "../include/dprc.h"
>
> #define FSL_MC_VENDOR_FREESCALE 0x1957
> @@ -109,6 +110,15 @@ struct fsl_mc_resource {
> #define FSL_MC_IS_DPRC 0x0001
>
> /**
> + * root dprc's parent is a platform device
> + * that platform device's bus type is platform_bus_type.
> + */
> +#define is_root_dprc(dev) \
> + ((to_fsl_mc_device(dev)->flags & FSL_MC_IS_DPRC) && \
> + ((dev)->bus == &fsl_mc_bus_type) && \
> + ((dev)->parent->bus == &platform_bus_type))
> +
It's best to make this type of thing a static inline function, to ensure
you get the correct typechecking.
thanks,
greg k-h
next prev parent reply other threads:[~2015-10-26 0:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 22:41 [PATCH 0/5] Management Complex restool driver Lijun Pan
2015-10-25 22:41 ` [PATCH 1/5] staging: fsl-mc: section mismatch bug fix Lijun Pan
2015-10-25 22:41 ` [PATCH 2/5] staging: fsl-mc: define a macro to differentiate root dprc Lijun Pan
2015-10-26 0:12 ` Greg KH [this message]
2015-10-26 16:02 ` Lijun Pan
2015-10-25 22:41 ` [PATCH 3/5] staging: fsl-mc: root dprc rescan attribute to sync kernel with MC Lijun Pan
2015-10-25 22:41 ` [PATCH 4/5] staging: fsl-mc: bus " Lijun Pan
2015-10-27 5:39 ` Greg KH
2015-10-29 17:13 ` Lijun Pan
2015-10-25 22:41 ` [PATCH 5/5] staging: fsl-mc: Management Complex restool driver Lijun Pan
2015-10-26 6:20 ` Dan Carpenter
2015-10-26 16:01 ` Lijun Pan
2015-10-26 15:52 ` Stuart Yoder
2015-10-27 2:11 ` Stuart Yoder
2015-10-27 5:16 ` Scott Wood
2015-10-29 23:54 ` Lijun Pan
2015-10-30 16:43 ` Lijun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026001242.GA20331@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Lijun.Pan@freescale.com \
--cc=R89243@freescale.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bhamciu1@freescale.com \
--cc=bhupesh.sharma@freescale.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=german.rivera@freescale.com \
--cc=itai.katz@freescale.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nir.erez@freescale.com \
--cc=richard.schmitt@freescale.com \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).