* Re: [PATCH v9 1/2] fs: New zonefs file system
@ 2020-01-28 15:34 Markus Elfring
2020-01-29 4:13 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2020-01-28 15:34 UTC (permalink / raw)
To: Damien Le Moal, linux-fsdevel, linux-xfs
Cc: linux-kernel, Darrick J. Wong, Hannes Reinecke,
Johannes Thumshirn, Linus Torvalds, Naohiro Aota
…
> +++ b/fs/zonefs/super.c
…
> +out:
> + kunmap(page);
> +out_free:
> + __free_page(page);
Would you like to reconsider your name selection for such labels?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b0be0eff1a5ab77d588b76bd8b1c92d5d17b3f73#n460
Change possibility:
+unmap:
+ kunmap(page);
+free_page:
+ __free_page(page);
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v9 1/2] fs: New zonefs file system
2020-01-28 15:34 [PATCH v9 1/2] fs: New zonefs file system Markus Elfring
@ 2020-01-29 4:13 ` Damien Le Moal
2020-01-29 8:20 ` [v9 " Markus Elfring
0 siblings, 1 reply; 4+ messages in thread
From: Damien Le Moal @ 2020-01-29 4:13 UTC (permalink / raw)
To: Markus.Elfring, linux-fsdevel, linux-xfs
Cc: darrick.wong, torvalds, jth, linux-kernel, hare, Naohiro Aota
On Tue, 2020-01-28 at 16:34 +0100, Markus Elfring wrote:
> …
> > +++ b/fs/zonefs/super.c
> …
> > +out:
> > + kunmap(page);
> > +out_free:
> > + __free_page(page);
>
> Would you like to reconsider your name selection for such labels?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b0be0eff1a5ab77d588b76bd8b1c92d5d17b3f73#n460
>
> Change possibility:
>
> +unmap:
> + kunmap(page);
> +free_page:
> + __free_page(page);
>
Fixed. Thanks !
>
> Regards,
> Markus
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v9 1/2] fs: New zonefs file system
2020-01-29 4:13 ` Damien Le Moal
@ 2020-01-29 8:20 ` Markus Elfring
2020-01-29 8:24 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2020-01-29 8:20 UTC (permalink / raw)
To: Damien Le Moal, linux-fsdevel, linux-xfs
Cc: linux-kernel, Darrick J. Wong, Hannes Reinecke,
Johannes Thumshirn, Linus Torvalds, Naohiro Aota
>> Would you like to reconsider your name selection for such labels?
…
> Fixed. Thanks !
Will a different identifier be occasionally more helpful than the label “out”
also at other source code places?
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v9 1/2] fs: New zonefs file system
2020-01-29 8:20 ` [v9 " Markus Elfring
@ 2020-01-29 8:24 ` Damien Le Moal
0 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2020-01-29 8:24 UTC (permalink / raw)
To: Markus Elfring, linux-fsdevel, linux-xfs
Cc: linux-kernel, Darrick J. Wong, Hannes Reinecke,
Johannes Thumshirn, Linus Torvalds, Naohiro Aota
On 2020/01/29 17:20, Markus Elfring wrote:
>>> Would you like to reconsider your name selection for such labels?
> …
>> Fixed. Thanks !
>
> Will a different identifier be occasionally more helpful than the label “out”
> also at other source code places?
I am addressing all comments I got for v10 right now and reviewing all the
goto labels too. Thanks.
>
> Regards,
> Markus
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-29 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-28 15:34 [PATCH v9 1/2] fs: New zonefs file system Markus Elfring
2020-01-29 4:13 ` Damien Le Moal
2020-01-29 8:20 ` [v9 " Markus Elfring
2020-01-29 8:24 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).