From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>,
Shardar Mohammed <smohammed@nvidia.com>,
Timo Alho <talho@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: RE: [PATCH V8 3/5] i2c: tegra: Add DMA Support
Date: Thu, 31 Jan 2019 16:56:56 +0000 [thread overview]
Message-ID: <BYAPR12MB3398CFEE7E912513AE48DD2FC2910@BYAPR12MB3398.namprd12.prod.outlook.com> (raw)
In-Reply-To: <8a88f8ee-24d3-00ac-f1fa-c43b576ed82c@gmail.com>
> >> drivers/i2c/busses/Kconfig | 2 +-
> >> drivers/i2c/busses/i2c-tegra.c | 362
> >> ++++++++++++++++++++++++++++++++++++++---
> >> 2 files changed, 339 insertions(+), 25 deletions(-)
> >
> > Tegra20 crashes because of this patch:
> >
> [snip]
> > <4>[ 3.395915] ------------[ cut here ]------------
> > <2>[ 3.395919] kernel BUG at drivers/i2c/busses/i2c-tegra.c:810!
> The BUG line is from:
>
> if (status & I2C_INT_PACKET_XFER_COMPLETE) {
> if (i2c_dev->is_curr_dma_xfer)
> i2c_dev->msg_buf_remaining = 0;
> BUG_ON(i2c_dev->msg_buf_remaining);
> complete(&i2c_dev->msg_complete);
> }
>
BUG_ON line is not part of this change. It was already there in existing driver.
Based on log, I see DMA transfer is done for 224 bytes followed by 1 successful PIO transfer and then on next PIO transfer it received packet xfer complete interrupt with incomplete transfer bytes and that where it hit BUG_ON condition.
next prev parent reply other threads:[~2019-01-31 16:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 6:16 [PATCH V8 1/5] i2c: tegra: Sort all the include headers alphabetically Sowjanya Komatineni
2019-01-31 6:16 ` [PATCH V8 2/5] i2c: tegra: Add Bus Clear Master Support Sowjanya Komatineni
2019-01-31 12:44 ` Thierry Reding
2019-01-31 15:16 ` Dmitry Osipenko
2019-01-31 6:16 ` [PATCH V8 3/5] i2c: tegra: Add DMA Support Sowjanya Komatineni
2019-01-31 12:44 ` Thierry Reding
2019-01-31 16:41 ` Sowjanya Komatineni
2019-02-01 0:52 ` Dmitry Osipenko
2019-02-01 1:11 ` Sowjanya Komatineni
2019-02-01 3:14 ` Dmitry Osipenko
2019-02-01 4:19 ` Sowjanya Komatineni
2019-02-01 15:02 ` Dmitry Osipenko
2019-01-31 15:12 ` Dmitry Osipenko
2019-01-31 15:24 ` Dmitry Osipenko
2019-01-31 16:56 ` Sowjanya Komatineni [this message]
2019-01-31 17:11 ` Dmitry Osipenko
2019-01-31 17:25 ` Dmitry Osipenko
2019-01-31 17:38 ` Dmitry Osipenko
2019-01-31 17:38 ` Sowjanya Komatineni
2019-01-31 21:46 ` Sowjanya Komatineni
2019-02-01 0:54 ` Dmitry Osipenko
2019-01-31 6:16 ` [PATCH V8 4/5] i2c: tegra: Update transfer timeout Sowjanya Komatineni
2019-01-31 12:48 ` Thierry Reding
2019-01-31 6:16 ` [PATCH V8 5/5] i2c: tegra: Add I2C interface timing support Sowjanya Komatineni
2019-01-31 12:50 ` Thierry Reding
2019-01-31 12:45 ` [PATCH V8 1/5] i2c: tegra: Sort all the include headers alphabetically Thierry Reding
2019-01-31 15:14 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB3398CFEE7E912513AE48DD2FC2910@BYAPR12MB3398.namprd12.prod.outlook.com \
--to=skomatineni@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).