From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>,
Shardar Mohammed <smohammed@nvidia.com>,
Timo Alho <talho@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH V8 3/5] i2c: tegra: Add DMA Support
Date: Thu, 31 Jan 2019 20:38:29 +0300 [thread overview]
Message-ID: <f5b9acd6-3700-9595-9be7-066be1d4d77c@gmail.com> (raw)
In-Reply-To: <c2676c08-83d7-2ac9-ce34-c7c7f86d798e@gmail.com>
31.01.2019 20:25, Dmitry Osipenko пишет:
> 31.01.2019 20:11, Dmitry Osipenko пишет:
>> 31.01.2019 19:56, Sowjanya Komatineni пишет:
>>>
>>>>>> drivers/i2c/busses/Kconfig | 2 +-
>>>>>> drivers/i2c/busses/i2c-tegra.c | 362
>>>>>> ++++++++++++++++++++++++++++++++++++++---
>>>>>> 2 files changed, 339 insertions(+), 25 deletions(-)
>>>>>
>>>>> Tegra20 crashes because of this patch:
>>>>>
>>>> [snip]
>>>>> <4>[ 3.395915] ------------[ cut here ]------------
>>>>> <2>[ 3.395919] kernel BUG at drivers/i2c/busses/i2c-tegra.c:810!
>>>> The BUG line is from:
>>>>
>>>> if (status & I2C_INT_PACKET_XFER_COMPLETE) {
>>>> if (i2c_dev->is_curr_dma_xfer)
>>>> i2c_dev->msg_buf_remaining = 0;
>>>> BUG_ON(i2c_dev->msg_buf_remaining);
>>>> complete(&i2c_dev->msg_complete);
>>>> }
>>>>
>>> BUG_ON line is not part of this change. It was already there in existing driver.
>>> Based on log, I see DMA transfer is done for 224 bytes followed by 1 successful PIO transfer and then on next PIO transfer it received packet xfer complete interrupt with incomplete transfer bytes and that where it hit BUG_ON condition.
>>>
>>>
>>
>> Yes, that BUG_ON is caused by the DMA transferring. Everything works fine be setting dma=false in the code, hence it's likely not a bug in the code (at least for now it looks fine), but likely that HW is not programmed correctly.
>>
>
> It works with this change:
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index fe5b89abc576..8e059e94b94e 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -1170,10 +1170,11 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
> time_left, completion_done(&i2c_dev->msg_complete),
> i2c_dev->msg_err);
>
> + tegra_i2c_init(i2c_dev, true);
> +
> if (likely(i2c_dev->msg_err == I2C_ERR_NONE))
> return 0;
>
> - tegra_i2c_init(i2c_dev, true);
> /* start recovery upon arbitration loss in single master mode */
> if (i2c_dev->msg_err == I2C_ERR_ARBITRATION_LOST) {
> if (!i2c_dev->is_multimaster_mode)
>
>
> Which means that HW state is kept dirty after DMA transfer. Please check everything carefully.
>
Also, enforcing dma=true regardless of transfer size doesn't work as well.
next prev parent reply other threads:[~2019-01-31 17:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 6:16 [PATCH V8 1/5] i2c: tegra: Sort all the include headers alphabetically Sowjanya Komatineni
2019-01-31 6:16 ` [PATCH V8 2/5] i2c: tegra: Add Bus Clear Master Support Sowjanya Komatineni
2019-01-31 12:44 ` Thierry Reding
2019-01-31 15:16 ` Dmitry Osipenko
2019-01-31 6:16 ` [PATCH V8 3/5] i2c: tegra: Add DMA Support Sowjanya Komatineni
2019-01-31 12:44 ` Thierry Reding
2019-01-31 16:41 ` Sowjanya Komatineni
2019-02-01 0:52 ` Dmitry Osipenko
2019-02-01 1:11 ` Sowjanya Komatineni
2019-02-01 3:14 ` Dmitry Osipenko
2019-02-01 4:19 ` Sowjanya Komatineni
2019-02-01 15:02 ` Dmitry Osipenko
2019-01-31 15:12 ` Dmitry Osipenko
2019-01-31 15:24 ` Dmitry Osipenko
2019-01-31 16:56 ` Sowjanya Komatineni
2019-01-31 17:11 ` Dmitry Osipenko
2019-01-31 17:25 ` Dmitry Osipenko
2019-01-31 17:38 ` Dmitry Osipenko [this message]
2019-01-31 17:38 ` Sowjanya Komatineni
2019-01-31 21:46 ` Sowjanya Komatineni
2019-02-01 0:54 ` Dmitry Osipenko
2019-01-31 6:16 ` [PATCH V8 4/5] i2c: tegra: Update transfer timeout Sowjanya Komatineni
2019-01-31 12:48 ` Thierry Reding
2019-01-31 6:16 ` [PATCH V8 5/5] i2c: tegra: Add I2C interface timing support Sowjanya Komatineni
2019-01-31 12:50 ` Thierry Reding
2019-01-31 12:45 ` [PATCH V8 1/5] i2c: tegra: Sort all the include headers alphabetically Thierry Reding
2019-01-31 15:14 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5b9acd6-3700-9595-9be7-066be1d4d77c@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).