[PATCH -next] mm/usercopy: fix warning Comparison to bool

[PATCH -next] mm/usercopy: fix warning Comparison to bool

[Zou Wei]

fix below warnings reported by coccicheck

mm/usercopy.c:304:5-18: WARNING: Comparison to bool

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 mm/usercopy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/usercopy.c b/mm/usercopy.c
index 660717a..04346cf 100644
--- a/mm/usercopy.c
+++ b/mm/usercopy.c
@@ -301,7 +301,7 @@ __setup("hardened_usercopy=", parse_hardened_usercopy);
 
 static int __init set_hardened_usercopy(void)
 {
-	if (enable_checks == false)
+	if (!enable_checks)
 		static_branch_enable(&bypass_usercopy_checks);
 	return 1;
 }
-- 
2.6.2

Re: [PATCH -next] mm/usercopy: fix warning Comparison to bool

[Andrew Morton]

On Tue, 14 Apr 2020 11:42:04 +0800 Zou Wei <zou_wei@huawei.com> wrote:

> fix below warnings reported by coccicheck
> 
> mm/usercopy.c:304:5-18: WARNING: Comparison to bool
>
> ...
>
> --- a/mm/usercopy.c
> +++ b/mm/usercopy.c
> @@ -301,7 +301,7 @@ __setup("hardened_usercopy=", parse_hardened_usercopy);
>  
>  static int __init set_hardened_usercopy(void)
>  {
> -	if (enable_checks == false)
> +	if (!enable_checks)
>  		static_branch_enable(&bypass_usercopy_checks);
>  	return 1;
>  }

My initial reaction is "fix coccicheck".  There's nothing wrong with
that code?

答复: [PATCH -next] mm/usercopy: fix warning Comparison to bool

[Zouwei (Samuel)]

Hi Andrew,

Thanks for your reply.
Perhaps this is a detection rule of Coccinelle (coccicheck) software for programming specifications,
and it's no wrong with the code, just a coding style.

Best Regards
Zou Wei
-----邮件原件-----
发件人: Andrew Morton [mailto:akpm@linux-foundation.org] 
发送时间: 2020年4月16日 7:05
收件人: Zouwei (Samuel) <zou_wei@huawei.com>
抄送: linux-mm@kvack.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] mm/usercopy: fix warning Comparison to bool

On Tue, 14 Apr 2020 11:42:04 +0800 Zou Wei <zou_wei@huawei.com> wrote:

> fix below warnings reported by coccicheck
> 
> mm/usercopy.c:304:5-18: WARNING: Comparison to bool
>
> ...
>
> --- a/mm/usercopy.c
> +++ b/mm/usercopy.c
> @@ -301,7 +301,7 @@ __setup("hardened_usercopy=", 
> parse_hardened_usercopy);
>  
>  static int __init set_hardened_usercopy(void)  {
> -	if (enable_checks == false)
> +	if (!enable_checks)
>  		static_branch_enable(&bypass_usercopy_checks);
>  	return 1;
>  }

My initial reaction is "fix coccicheck".  There's nothing wrong with that code?

Re: 答复: [PATCH -next] mm/usercopy: fix warning Comparison to bool

[David Hildenbrand]

On 16.04.20 12:45, Zouwei (Samuel) wrote:
> Hi Andrew,
> 
> Thanks for your reply.
> Perhaps this is a detection rule of Coccinelle (coccicheck) software for programming specifications,
> and it's no wrong with the code, just a coding style.

Then it's not an actual fix and the subject is misleading.

-- 
Thanks,

David / dhildenb