* [PATCH] mm: remove dead code totalram_pages_set()
@ 2019-12-17 6:44 Wei Yang
2019-12-17 11:01 ` David Hildenbrand
2019-12-17 12:48 ` Qian Cai
0 siblings, 2 replies; 6+ messages in thread
From: Wei Yang @ 2019-12-17 6:44 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Wei Yang
No one use totalram_pages_set(), just remote it.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
include/linux/mm.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 74232b28949b..4cf023c4c6b3 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -70,11 +70,6 @@ static inline void totalram_pages_add(long count)
atomic_long_add(count, &_totalram_pages);
}
-static inline void totalram_pages_set(long val)
-{
- atomic_long_set(&_totalram_pages, val);
-}
-
extern void * high_memory;
extern int page_cluster;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: remove dead code totalram_pages_set()
2019-12-17 6:44 [PATCH] mm: remove dead code totalram_pages_set() Wei Yang
@ 2019-12-17 11:01 ` David Hildenbrand
2019-12-18 0:48 ` Wei Yang
2019-12-17 12:48 ` Qian Cai
1 sibling, 1 reply; 6+ messages in thread
From: David Hildenbrand @ 2019-12-17 11:01 UTC (permalink / raw)
To: Wei Yang, akpm; +Cc: linux-mm, linux-kernel
On 17.12.19 07:44, Wei Yang wrote:
> No one use totalram_pages_set(), just remote it.
s/use/uses/
s/remote/remove/
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
> include/linux/mm.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 74232b28949b..4cf023c4c6b3 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -70,11 +70,6 @@ static inline void totalram_pages_add(long count)
> atomic_long_add(count, &_totalram_pages);
> }
>
> -static inline void totalram_pages_set(long val)
> -{
> - atomic_long_set(&_totalram_pages, val);
> -}
> -
> extern void * high_memory;
> extern int page_cluster;
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: remove dead code totalram_pages_set()
2019-12-17 6:44 [PATCH] mm: remove dead code totalram_pages_set() Wei Yang
2019-12-17 11:01 ` David Hildenbrand
@ 2019-12-17 12:48 ` Qian Cai
2019-12-18 0:50 ` Wei Yang
1 sibling, 1 reply; 6+ messages in thread
From: Qian Cai @ 2019-12-17 12:48 UTC (permalink / raw)
To: Wei Yang; +Cc: akpm, linux-mm, linux-kernel
> On Dec 17, 2019, at 1:44 AM, Wei Yang <richardw.yang@linux.intel.com> wrote:
>
> No one use totalram_pages_set(), just remote it.
It is unlikely that this is unintentional, but can you figure out which commit removed the last caller just in case?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: remove dead code totalram_pages_set()
2019-12-17 11:01 ` David Hildenbrand
@ 2019-12-18 0:48 ` Wei Yang
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yang @ 2019-12-18 0:48 UTC (permalink / raw)
To: David Hildenbrand, g; +Cc: Wei Yang, akpm, linux-mm, linux-kernel
On Tue, Dec 17, 2019 at 12:01:11PM +0100, David Hildenbrand wrote:
>On 17.12.19 07:44, Wei Yang wrote:
>> No one use totalram_pages_set(), just remote it.
>
>s/use/uses/
>s/remote/remove/
>
Thanks, my bad.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> ---
>> include/linux/mm.h | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index 74232b28949b..4cf023c4c6b3 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -70,11 +70,6 @@ static inline void totalram_pages_add(long count)
>> atomic_long_add(count, &_totalram_pages);
>> }
>>
>> -static inline void totalram_pages_set(long val)
>> -{
>> - atomic_long_set(&_totalram_pages, val);
>> -}
>> -
>> extern void * high_memory;
>> extern int page_cluster;
>>
>>
>
>Reviewed-by: David Hildenbrand <david@redhat.com>
>
>--
>Thanks,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: remove dead code totalram_pages_set()
2019-12-17 12:48 ` Qian Cai
@ 2019-12-18 0:50 ` Wei Yang
2019-12-18 1:04 ` Qian Cai
0 siblings, 1 reply; 6+ messages in thread
From: Wei Yang @ 2019-12-18 0:50 UTC (permalink / raw)
To: Qian Cai; +Cc: Wei Yang, akpm, linux-mm, linux-kernel
On Tue, Dec 17, 2019 at 07:48:09AM -0500, Qian Cai wrote:
>
>
>> On Dec 17, 2019, at 1:44 AM, Wei Yang <richardw.yang@linux.intel.com> wrote:
>>
>> No one use totalram_pages_set(), just remote it.
>
>It is unlikely that this is unintentional, but can you figure out which commit removed the last caller just in case?
Took a look into the history. This function is introduced in
commit 'ca79b0c211af' (mm: convert totalram_pages and totalhigh_pages
variables to atomic)
Even in this commit, no one use this function.
Will include this in next version.
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: remove dead code totalram_pages_set()
2019-12-18 0:50 ` Wei Yang
@ 2019-12-18 1:04 ` Qian Cai
0 siblings, 0 replies; 6+ messages in thread
From: Qian Cai @ 2019-12-18 1:04 UTC (permalink / raw)
To: Wei Yang; +Cc: akpm, linux-mm, linux-kernel
> On Dec 17, 2019, at 7:50 PM, Wei Yang <richardw.yang@linux.intel.com> wrote:
>
> Took a look into the history. This function is introduced in
>
> commit 'ca79b0c211af' (mm: convert totalram_pages and totalhigh_pages
> variables to atomic)
>
> Even in this commit, no one use this function.
It occurs to me that function was a part of API design as a placeholder which might be used in the future.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-18 1:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 6:44 [PATCH] mm: remove dead code totalram_pages_set() Wei Yang
2019-12-17 11:01 ` David Hildenbrand
2019-12-18 0:48 ` Wei Yang
2019-12-17 12:48 ` Qian Cai
2019-12-18 0:50 ` Wei Yang
2019-12-18 1:04 ` Qian Cai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).