* [PATCH] irqchip: mxs: add missing set_handle_irq()
@ 2016-01-29 8:29 Oleksij Rempel
2016-01-29 8:33 ` Thomas Gleixner
0 siblings, 1 reply; 9+ messages in thread
From: Oleksij Rempel @ 2016-01-29 8:29 UTC (permalink / raw)
To: kernel, linux-kernel, tglx, jason, marc.zyngier; +Cc: Oleksij Rempel
this will fix IRQ related issues on Alphascale ASM9260
Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
---
drivers/irqchip/irq-mxs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index c22e2d4..efe5084 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -241,6 +241,7 @@ static int __init asm9260_of_init(struct device_node *np,
writel(0, icoll_priv.intr + i);
icoll_add_domain(np, ASM9260_NUM_IRQS);
+ set_handle_irq(icoll_handle_irq);
return 0;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] irqchip: mxs: add missing set_handle_irq()
2016-01-29 8:29 [PATCH] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel
@ 2016-01-29 8:33 ` Thomas Gleixner
2016-01-29 8:49 ` Oleksij Rempel
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2016-01-29 8:33 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: kernel, linux-kernel, jason, marc.zyngier
On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> this will fix IRQ related issues on Alphascale ASM9260
This really does not qualify as a changelog.
1) What's the problem and what consequences does it have
2) What's the fix.
Thanks,
tglx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] irqchip: mxs: add missing set_handle_irq()
2016-01-29 8:33 ` Thomas Gleixner
@ 2016-01-29 8:49 ` Oleksij Rempel
2016-01-29 8:54 ` Thomas Gleixner
0 siblings, 1 reply; 9+ messages in thread
From: Oleksij Rempel @ 2016-01-29 8:49 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: kernel, linux-kernel, jason, marc.zyngier
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
> On Fri, 29 Jan 2016, Oleksij Rempel wrote:
>
>> this will fix IRQ related issues on Alphascale ASM9260
>
> This really does not qualify as a changelog.
>
> 1) What's the problem and what consequences does it have
>
> 2) What's the fix.
>
> Thanks,
>
> tglx
>
The driver provide this function:
asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
{
u32 irqnr;
irqnr = __raw_readl(icoll_priv.stat);
__raw_writel(irqnr, icoll_priv.vector);
handle_domain_irq(icoll_domain, irqnr, regs);
}
i assume at some late review point instead of move it to asm9260_of_init
i removed it completely. As result, the driver was compilable but not
working.
Should i put this explanation to changelog?
--
Regards,
Oleksij
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] irqchip: mxs: add missing set_handle_irq()
2016-01-29 8:49 ` Oleksij Rempel
@ 2016-01-29 8:54 ` Thomas Gleixner
2016-01-29 8:58 ` Oleksij Rempel
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2016-01-29 8:54 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: kernel, linux-kernel, jason, marc.zyngier
On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
> > On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> >
> >> this will fix IRQ related issues on Alphascale ASM9260
> >
> > This really does not qualify as a changelog.
> >
> > 1) What's the problem and what consequences does it have
> >
> > 2) What's the fix.
> >
> > Thanks,
> >
> > tglx
> >
>
> The driver provide this function:
> asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
> {
> u32 irqnr;
>
> irqnr = __raw_readl(icoll_priv.stat);
> __raw_writel(irqnr, icoll_priv.vector);
> handle_domain_irq(icoll_domain, irqnr, regs);
> }
>
> i assume at some late review point instead of move it to asm9260_of_init
> i removed it completely. As result, the driver was compilable but not
> working.
> Should i put this explanation to changelog?
So the problem is:
The rework of the driver missed to move the call to set_handle_irq() into
asm9260_of_init(). As a consequence no interrupt entry point is installed and
no interrupts are delivered (or whatever the outcome is, crash, explode ...)
Solution is:
Install the interrupt entry handler.
Right?
And that wants a tag:
Fixes: nnnnnnnnnnnn ("irqchip/......")
So we can mark it for stable.
Thanks,
tglx
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] irqchip: mxs: add missing set_handle_irq()
2016-01-29 8:54 ` Thomas Gleixner
@ 2016-01-29 8:58 ` Oleksij Rempel
2016-01-29 9:16 ` Thomas Gleixner
0 siblings, 1 reply; 9+ messages in thread
From: Oleksij Rempel @ 2016-01-29 8:58 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: kernel, linux-kernel, jason, marc.zyngier
[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]
Am 29.01.2016 um 09:54 schrieb Thomas Gleixner:
> On Fri, 29 Jan 2016, Oleksij Rempel wrote:
>> Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
>>> On Fri, 29 Jan 2016, Oleksij Rempel wrote:
>>>
>>>> this will fix IRQ related issues on Alphascale ASM9260
>>>
>>> This really does not qualify as a changelog.
>>>
>>> 1) What's the problem and what consequences does it have
>>>
>>> 2) What's the fix.
>>>
>>> Thanks,
>>>
>>> tglx
>>>
>>
>> The driver provide this function:
>> asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
>> {
>> u32 irqnr;
>>
>> irqnr = __raw_readl(icoll_priv.stat);
>> __raw_writel(irqnr, icoll_priv.vector);
>> handle_domain_irq(icoll_domain, irqnr, regs);
>> }
>>
>> i assume at some late review point instead of move it to asm9260_of_init
>> i removed it completely. As result, the driver was compilable but not
>> working.
>> Should i put this explanation to changelog?
>
> So the problem is:
>
> The rework of the driver missed to move the call to set_handle_irq() into
> asm9260_of_init(). As a consequence no interrupt entry point is installed and
> no interrupts are delivered (or whatever the outcome is, crash, explode ...)
>
> Solution is:
>
> Install the interrupt entry handler.
>
> Right?
Right.
Should i resend a patch with new comment?
> And that wants a tag:
>
> Fixes: nnnnnnnnnnnn ("irqchip/......")
>
> So we can mark it for stable.
>
> Thanks,
>
> tglx
>
--
Regards,
Oleksij
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] irqchip: mxs: add missing set_handle_irq()
2016-01-29 8:58 ` Oleksij Rempel
@ 2016-01-29 9:16 ` Thomas Gleixner
2016-01-29 9:57 ` [PATCH v2] " Oleksij Rempel
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2016-01-29 9:16 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: kernel, linux-kernel, jason, marc.zyngier
On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> Should i resend a patch with new comment?
Yes, please.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] irqchip: mxs: add missing set_handle_irq()
2016-01-29 9:16 ` Thomas Gleixner
@ 2016-01-29 9:57 ` Oleksij Rempel
2016-01-29 11:18 ` [tip:irq/urgent] irqchip/mxs: Add " tip-bot for Oleksij Rempel
2016-02-17 22:17 ` [PATCH v2] irqchip: mxs: add " Jason Cooper
0 siblings, 2 replies; 9+ messages in thread
From: Oleksij Rempel @ 2016-01-29 9:57 UTC (permalink / raw)
To: kernel, linux-kernel, tglx, jason, marc.zyngier; +Cc: Oleksij Rempel
The rework of the driver missed to move the call to set_handle_irq() into
asm9260_of_init(). As a consequence no interrupt entry point is installed and
no interrupts are delivered
Solution is:
Install the interrupt entry handler.
Fixes: 7e4ac676ee ("irqchip/mxs: Add Alphascale ASM9260 support")
Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
---
drivers/irqchip/irq-mxs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index c22e2d4..efe5084 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -241,6 +241,7 @@ static int __init asm9260_of_init(struct device_node *np,
writel(0, icoll_priv.intr + i);
icoll_add_domain(np, ASM9260_NUM_IRQS);
+ set_handle_irq(icoll_handle_irq);
return 0;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [tip:irq/urgent] irqchip/mxs: Add missing set_handle_irq()
2016-01-29 9:57 ` [PATCH v2] " Oleksij Rempel
@ 2016-01-29 11:18 ` tip-bot for Oleksij Rempel
2016-02-17 22:17 ` [PATCH v2] irqchip: mxs: add " Jason Cooper
1 sibling, 0 replies; 9+ messages in thread
From: tip-bot for Oleksij Rempel @ 2016-01-29 11:18 UTC (permalink / raw)
To: linux-tip-commits; +Cc: tglx, linux, hpa, mingo, linux-kernel
Commit-ID: c5b635203032462603c503ecce91a7021c1ad44a
Gitweb: http://git.kernel.org/tip/c5b635203032462603c503ecce91a7021c1ad44a
Author: Oleksij Rempel <linux@rempel-privat.de>
AuthorDate: Fri, 29 Jan 2016 10:57:53 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 29 Jan 2016 12:15:50 +0100
irqchip/mxs: Add missing set_handle_irq()
The rework of the driver missed to move the call to set_handle_irq() into
asm9260_of_init(). As a consequence no interrupt entry point is installed and
no interrupts are delivered
Solution is simple: Install the interrupt entry handler.
Fixes: 7e4ac676ee ("irqchip/mxs: Add Alphascale ASM9260 support")
Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
Cc: kernel@pengutronix.de
Cc: jason@lakedaemon.net
Cc: marc.zyngier@arm.com
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1454061473-24957-1-git-send-email-linux@rempel-privat.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-mxs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index c22e2d4..efe5084 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -241,6 +241,7 @@ static int __init asm9260_of_init(struct device_node *np,
writel(0, icoll_priv.intr + i);
icoll_add_domain(np, ASM9260_NUM_IRQS);
+ set_handle_irq(icoll_handle_irq);
return 0;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] irqchip: mxs: add missing set_handle_irq()
2016-01-29 9:57 ` [PATCH v2] " Oleksij Rempel
2016-01-29 11:18 ` [tip:irq/urgent] irqchip/mxs: Add " tip-bot for Oleksij Rempel
@ 2016-02-17 22:17 ` Jason Cooper
1 sibling, 0 replies; 9+ messages in thread
From: Jason Cooper @ 2016-02-17 22:17 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: kernel, linux-kernel, tglx, marc.zyngier
> On Jan 29, 2016, at 04:57, Oleksij Rempel <linux@rempel-privat.de> wrote:
>
> The rework of the driver missed to move the call to set_handle_irq() into
> asm9260_of_init(). As a consequence no interrupt entry point is installed and
> no interrupts are delivered
>
> Solution is:
> Install the interrupt entry handler.
>
> Fixes: 7e4ac676ee ("irqchip/mxs: Add Alphascale ASM9260 support")
>
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> ---
> drivers/irqchip/irq-mxs.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied to irqchip/urgent
Thx,
Jason.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-02-17 22:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-29 8:29 [PATCH] irqchip: mxs: add missing set_handle_irq() Oleksij Rempel
2016-01-29 8:33 ` Thomas Gleixner
2016-01-29 8:49 ` Oleksij Rempel
2016-01-29 8:54 ` Thomas Gleixner
2016-01-29 8:58 ` Oleksij Rempel
2016-01-29 9:16 ` Thomas Gleixner
2016-01-29 9:57 ` [PATCH v2] " Oleksij Rempel
2016-01-29 11:18 ` [tip:irq/urgent] irqchip/mxs: Add " tip-bot for Oleksij Rempel
2016-02-17 22:17 ` [PATCH v2] irqchip: mxs: add " Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).