* [PATCH v2] Documentation: include sign off for reverts
@ 2020-11-10 17:39 Aditya Srivastava
2020-11-10 17:40 ` Drew DeVault
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Srivastava @ 2020-11-10 17:39 UTC (permalink / raw)
To: corbet
Cc: yashsri421, lukas.bulwahn, joe, sir, linux-doc, linux-kernel,
linux-kernel-mentees
Currently, we do not have any documentation on commit reverts regarding
the requirement of Signed-off-by tag for it. This may be misleading to
the users.
Evaluating MISSING_SIGN_OFF checkpatch warnings on v4.13..v5.8 showed
that 4 out of 11 cases missing a sign-off are revert commits.
Add documentation regarding the same to document the community
consensus and let readers know.
Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
---
Documentation/process/submitting-patches.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index 83d9a82055a7..ff065e1f6a25 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -404,6 +404,8 @@ then you just add a line saying::
using your real name (sorry, no pseudonyms or anonymous contributions.)
This will be done for you automatically if you use ``git commit -s``.
+Also reverts should include a Signed-off-by. ``git revert -s`` does
+that for you.
Some people also put extra tags at the end. They'll just be ignored for
now, but you can do this to mark internal company procedures or just
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Documentation: include sign off for reverts
2020-11-10 17:39 [PATCH v2] Documentation: include sign off for reverts Aditya Srivastava
@ 2020-11-10 17:40 ` Drew DeVault
0 siblings, 0 replies; 2+ messages in thread
From: Drew DeVault @ 2020-11-10 17:40 UTC (permalink / raw)
To: Aditya Srivastava, corbet
Cc: lukas.bulwahn, joe, linux-doc, linux-kernel, linux-kernel-mentees
On Tue Nov 10, 2020 at 1:39 PM EDT, Aditya Srivastava wrote:
> using your real name (sorry, no pseudonyms or anonymous contributions.)
> This will be done for you automatically if you use ``git commit -s``.
> +Also reverts should include a Signed-off-by. ``git revert -s`` does
> +that for you.
The language here is a bit odd, try this:
Reverts should also include "Signed-off-by". ``git revert -s`` does that
for you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-10 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 17:39 [PATCH v2] Documentation: include sign off for reverts Aditya Srivastava
2020-11-10 17:40 ` Drew DeVault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).