[PATCH] tty: fill console_driver->driver_name

[PATCH] tty: fill console_driver->driver_name

[Cheng Chao]

cat /proc/tty/drivers
...
unknown              /dev/tty        4 1-63 console

----------------------------------
after this patch:

cat /proc/tty/drivers
...
console              /dev/tty        4 1-63 console

Signed-off-by: Cheng Chao <cs.os.kernel@gmail.com>
---
 drivers/tty/vt/vt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 34aa39d..981eee9 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -3440,6 +3440,7 @@ int __init vty_init(const struct file_operations *console_fops)
 	if (!console_driver)
 		panic("Couldn't allocate console driver\n");
 
+	console_driver->driver_name = "console";
 	console_driver->name = "tty";
 	console_driver->name_base = 1;
 	console_driver->major = TTY_MAJOR;
-- 
2.4.11

Re: [PATCH] tty: fill console_driver->driver_name

[Greg KH]

On Thu, Nov 07, 2019 at 09:25:48AM +0800, Cheng Chao wrote:
> cat /proc/tty/drivers
> ...
> unknown              /dev/tty        4 1-63 console
> 
> ----------------------------------
> after this patch:
> 
> cat /proc/tty/drivers
> ...
> console              /dev/tty        4 1-63 console

What is going to break with this change?  It's a user visable thing, why
does it need to be changed?

thanks,

greg k-h

Re: [PATCH] tty: fill console_driver->driver_name

[Cheng Chao]

Thank greg k-h.
1. I guess nothing is going to break with this change, I'm not sure about that
2. why does it need to be changed?
    "unknown" confuse us a little, and we want to know the reason: bug
or some else.
    In fact, it is a known tty driver.
3. finally, I also consider this patch is trivial, but I just expect
"cat /proc/tty/drivers" to be better.

thanks,
Cheng

On Mon, Nov 11, 2019 at 10:27 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Nov 07, 2019 at 09:25:48AM +0800, Cheng Chao wrote:
> > cat /proc/tty/drivers
> > ...
> > unknown              /dev/tty        4 1-63 console
> >
> > ----------------------------------
> > after this patch:
> >
> > cat /proc/tty/drivers
> > ...
> > console              /dev/tty        4 1-63 console
>
> What is going to break with this change?  It's a user visable thing, why
> does it need to be changed?
>
> thanks,
>
> greg k-h