From: Linus Torvalds <torvalds@linux-foundation.org>
To: Quinn Tran <quinn.tran@qlogic.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Josh Boyer <jwboyer@fedoraproject.org>,
Thorsten Leemhuis <regressions@leemhuis.info>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: Reported regressions for 4.7 as of Sunday, 2016-06-19
Date: Thu, 23 Jun 2016 09:35:42 -0700 [thread overview]
Message-ID: <CA+55aFx96hD29q_BQ+W8tV08zkX3BSCxF9etAzTDxfAgO3e7MQ@mail.gmail.com> (raw)
In-Reply-To: <1957A3C6-C4C2-4E7A-84E1-31A48F1469CD@qlogic.com>
On Thu, Jun 23, 2016 at 9:13 AM, Quinn Tran <quinn.tran@qlogic.com> wrote:
>
>
> QT: setting up the interrupt vector does not mean the interrupt starts firing immediately.
Actually, it very much can mean that. If the interrupt can possibly be
shared, there is a very real possibility of it fiding immediately.
Now, with MSI(-X) I guess that isn't a worry, so I suspect your patch
that handles just the legacy INTx case anyway is sufficient, but in
general I would like people to always act as if interrupts can happen
immediately after request_irq().
We have had *tons* of situations where the firmware left a device
active, for example. Or where some random interrupt controller ended
up having stale interrupts pending, even.
So in general, it's just good practice to say "spurious interrupts can
and do happen" - the shared irq case is the most obvious case, but
there have been other sources of unexpected spurious interrupts
firing.
Linus
next prev parent reply other threads:[~2016-06-23 16:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 14:52 Reported regressions for 4.7 as of Sunday, 2016-06-19 Thorsten Leemhuis
2016-06-20 10:21 ` Christoph Hellwig
2016-06-21 11:11 ` Josh Boyer
2016-06-21 20:40 ` Linus Torvalds
2016-06-22 0:55 ` Josh Boyer
2016-06-22 1:25 ` Martin K. Petersen
2016-06-22 1:29 ` Quinn Tran
2016-06-22 11:51 ` Johannes Thumshirn
2016-06-22 15:57 ` Quinn Tran
2016-06-23 7:22 ` Johannes Thumshirn
2016-06-23 16:13 ` Quinn Tran
2016-06-23 16:35 ` Linus Torvalds [this message]
2016-06-23 20:56 ` Eric W. Biederman
2016-07-05 16:30 ` Josh Boyer
2016-07-05 17:32 ` Linus Torvalds
2016-07-05 18:43 ` Thorsten Leemhuis
2016-07-05 19:40 ` Martin K. Petersen
2016-06-22 6:36 ` Kalle Valo
[not found] <20160624141918.4646.qmail@ns.sciencehorizons.net>
2016-06-26 12:52 ` Thorsten Leemhuis
2016-06-26 15:36 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFx96hD29q_BQ+W8tV08zkX3BSCxF9etAzTDxfAgO3e7MQ@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=jthumshirn@suse.de \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quinn.tran@qlogic.com \
--cc=regressions@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).