From: Josh Boyer <jwboyer@fedoraproject.org>
To: Quinn Tran <quinn.tran@qlogic.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thorsten Leemhuis <regressions@leemhuis.info>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Reported regressions for 4.7 as of Sunday, 2016-06-19
Date: Tue, 5 Jul 2016 12:30:34 -0400 [thread overview]
Message-ID: <CA+5PVA6NVTQUPZBCZ7J+NV-fEPkGKk2DDNQHn80sv71NNYOJnA@mail.gmail.com> (raw)
In-Reply-To: <A19CCC3E-1B00-45A5-BA4B-2E082E98AF87@qlogic.com>
On Wed, Jun 22, 2016 at 11:57 AM, Quinn Tran <quinn.tran@qlogic.com> wrote:
> Johannes, Martin,
>
> Based on the screen shot/call trace, it looks like this adapter is not using MSIX. It defaulted back to MSI or INTx interrupt. The code made an assumption of MSIX is available. There is no point in go through that code segment.
>
> Can you try this work around? It’s untested. Thanks.
>
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 5649c20..e033ecb 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2548,7 +2548,7 @@ void qla24xx_process_response_queue(struct scsi_qla_host *vha,
> if (!vha->flags.online)
> return;
>
> - if (rsp->msix->cpuid != smp_processor_id()) {
> + if (rsp->msix && (rsp->msix->cpuid != smp_processor_id())) {
> /* if kernel does not notify qla of IRQ's CPU change,
> * then set it here.
> */
Did this wind up going into an official commit somewhere?
josh
next prev parent reply other threads:[~2016-07-05 16:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 14:52 Reported regressions for 4.7 as of Sunday, 2016-06-19 Thorsten Leemhuis
2016-06-20 10:21 ` Christoph Hellwig
2016-06-21 11:11 ` Josh Boyer
2016-06-21 20:40 ` Linus Torvalds
2016-06-22 0:55 ` Josh Boyer
2016-06-22 1:25 ` Martin K. Petersen
2016-06-22 1:29 ` Quinn Tran
2016-06-22 11:51 ` Johannes Thumshirn
2016-06-22 15:57 ` Quinn Tran
2016-06-23 7:22 ` Johannes Thumshirn
2016-06-23 16:13 ` Quinn Tran
2016-06-23 16:35 ` Linus Torvalds
2016-06-23 20:56 ` Eric W. Biederman
2016-07-05 16:30 ` Josh Boyer [this message]
2016-07-05 17:32 ` Linus Torvalds
2016-07-05 18:43 ` Thorsten Leemhuis
2016-07-05 19:40 ` Martin K. Petersen
2016-06-22 6:36 ` Kalle Valo
[not found] <20160624141918.4646.qmail@ns.sciencehorizons.net>
2016-06-26 12:52 ` Thorsten Leemhuis
2016-06-26 15:36 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+5PVA6NVTQUPZBCZ7J+NV-fEPkGKk2DDNQHn80sv71NNYOJnA@mail.gmail.com \
--to=jwboyer@fedoraproject.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quinn.tran@qlogic.com \
--cc=regressions@leemhuis.info \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).