From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled
Date: Wed, 29 Nov 2017 12:58:54 -0800 [thread overview]
Message-ID: <CA+55aFy3tiDKKaE=GR0y9nxpwxJjD_NEU4yNN5YfaOUTFQvG=g@mail.gmail.com> (raw)
In-Reply-To: <CALCETrXaCtrzu7xyR+wHvSQhMoP4onUg0hfHHoxd72QSCqgkmw@mail.gmail.com>
On Wed, Nov 29, 2017 at 10:12 AM, Andy Lutomirski <luto@kernel.org> wrote:
>
> Jarkko, can you try the attached patch? If it survives resume, can
> you see if the log contains anything interesting?
I'm not Jarkko, but I'm not a huge fan of that patch.
If this was the cause of the problem (and it looks likely), wouldn't
it be nicer to instead make sure that __restore_processor_state() is
made to use only low-level code and easy to verify?
That function is already marked "notrace" because it is so fragile,
and it does the segment register reloads manually with inline asms.
Could we make it use "native_load_gs_index()" instead? Or even go all
the way and make it do that user-space %gs load internally with inline
asm, the way it already does the kernel space %gs?
(Maybe "native_wrmsrl()" too?)
Or is this actually all supposed to work even under PV? That sounds really iffy.
Linus
next prev parent reply other threads:[~2017-11-29 20:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 14:35 Suspend-to-ram/resume regression with commit ca37e57bbe0c Jarkko Nikula
2017-11-29 7:09 ` [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled Ingo Molnar
2017-11-29 9:25 ` Jarkko Nikula
2017-11-29 9:28 ` Thomas Gleixner
2017-11-29 12:39 ` Jarkko Nikula
2017-11-29 12:47 ` Peter Zijlstra
2017-11-29 14:33 ` Andy Lutomirski
2017-11-29 14:56 ` David Laight
2017-11-29 16:22 ` Andy Lutomirski
2017-11-29 16:51 ` David Laight
2017-11-29 20:48 ` Linus Torvalds
2017-11-29 16:51 ` Andy Lutomirski
2017-11-29 17:57 ` Andy Lutomirski
2017-11-29 18:08 ` Peter Zijlstra
2017-11-29 18:12 ` Andy Lutomirski
2017-11-29 20:58 ` Linus Torvalds [this message]
2017-11-29 21:25 ` Andy Lutomirski
2017-11-29 21:41 ` Andy Lutomirski
2017-11-29 21:57 ` Andy Lutomirski
2017-11-30 8:42 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFy3tiDKKaE=GR0y9nxpwxJjD_NEU4yNN5YfaOUTFQvG=g@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).