From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled
Date: Wed, 29 Nov 2017 14:39:19 +0200 [thread overview]
Message-ID: <f1ea2772-c4fa-8b74-f6fb-04e5d2eeb38a@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1711291027450.1825@nanos>
On 11/29/2017 11:28 AM, Thomas Gleixner wrote:
> On Wed, 29 Nov 2017, Jarkko Nikula wrote:
>
>> On 11/29/2017 09:09 AM, Ingo Molnar wrote:
>>> Hm, that commit looks broken with irq-tracing enabled. Does the
>>> patch below fix it?
>>>
>> No, it makes the machine not to boot at all :-(
>>
>> Log below when I used my config (now attached). With x86_64_defconfig it
>> booted twice but didn't survive suspend/resume. However several other boot
>> attempts with x86_64_defconfig failed somewhat similarly. Not in the same
>> place but hanging anyway. With my own config it seems to always end up failing
>> in trace_hardirqs_off_caller.
>
> Does it work when you disable all the tracing muck?
>
My config seems to work with Ingo's patch if I disable both
CONFIG_FTRACE and CONFIG_PROVE_LOCKING which disables the
CONFIG_TRACE_IRQS_FLAGS.
x86_64_defconfig with CONFIG_FTRACE disabled is still unstable.
Sometimes hangs during bootup and sometimes boots up to userspace.
--
Jarkko
next prev parent reply other threads:[~2017-11-29 12:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 14:35 Suspend-to-ram/resume regression with commit ca37e57bbe0c Jarkko Nikula
2017-11-29 7:09 ` [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled Ingo Molnar
2017-11-29 9:25 ` Jarkko Nikula
2017-11-29 9:28 ` Thomas Gleixner
2017-11-29 12:39 ` Jarkko Nikula [this message]
2017-11-29 12:47 ` Peter Zijlstra
2017-11-29 14:33 ` Andy Lutomirski
2017-11-29 14:56 ` David Laight
2017-11-29 16:22 ` Andy Lutomirski
2017-11-29 16:51 ` David Laight
2017-11-29 20:48 ` Linus Torvalds
2017-11-29 16:51 ` Andy Lutomirski
2017-11-29 17:57 ` Andy Lutomirski
2017-11-29 18:08 ` Peter Zijlstra
2017-11-29 18:12 ` Andy Lutomirski
2017-11-29 20:58 ` Linus Torvalds
2017-11-29 21:25 ` Andy Lutomirski
2017-11-29 21:41 ` Andy Lutomirski
2017-11-29 21:57 ` Andy Lutomirski
2017-11-30 8:42 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ea2772-c4fa-8b74-f6fb-04e5d2eeb38a@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).