From: Linus Torvalds <torvalds@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: George Spelvin <linux@horizon.com>, Jan Kara <jack@suse.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Maarten Baert <maarten-baert@hotmail.com>,
Ingo Molnar <mingo@kernel.org>,
Nate Eldredge <nate@thatsmathematics.com>,
Pekka Riikonen <priikone@iki.fi>,
Suresh Siddha <sbsiddha@gmail.com>,
stable <stable@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"the arch/x86 maintainers" <x86@kernel.org>
Subject: Re: [PATCH] Make math_state_restore() save and restore the interrupt flag
Date: Sat, 1 Feb 2014 16:17:26 -0800 [thread overview]
Message-ID: <CA+55aFyk=M2XeZd2rBR0hM3NQ5h8r26TgoEOtw4syaOjm3q75A@mail.gmail.com> (raw)
In-Reply-To: <52ED85DD.6020402@zytor.com>
On Sat, Feb 1, 2014 at 3:40 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>
> OK, let's circle back for a bit. We have an active bug, and we clearly
> have a lot of restructuring that could/should be done. We need to fix
> the bug first; if we're going to a bunch of restructuring then that
> ought to be separate. The first bit is how we fix the immediate bug.
So either of my suggested changes to __kernel_fpu_end() _should_ fix
the bug, with the caveat that if we do take the "check tsk-used-math"
version, we had better verify that yes, we allocate the save storage
before we set that flag. One of the reasons I tended to prefer simpler
the "just do stts()" version is that it seemed safer. I am a bit
worried about the whole interaction with synchronous task state and
interrupts.
Suresh's notion of just always allocating the FP state save area at
process creation would fix it too.
So many ways to fix it, so little knowledge about the actual usage
patterns and performance issues..
Linus
next prev parent reply other threads:[~2014-02-02 0:17 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 22:01 [PATCH] Make math_state_restore() save and restore the interrupt flag Nate Eldredge
2014-01-30 22:24 ` Linus Torvalds
2014-01-31 7:33 ` Suresh Siddha
2014-02-01 19:27 ` Linus Torvalds
2014-02-01 19:35 ` H. Peter Anvin
2014-02-01 19:46 ` Linus Torvalds
2014-02-01 20:00 ` H. Peter Anvin
2014-02-01 20:16 ` Linus Torvalds
2014-02-01 20:16 ` H. Peter Anvin
2014-02-01 21:17 ` George Spelvin
2014-02-01 21:36 ` H. Peter Anvin
2014-02-01 23:40 ` H. Peter Anvin
2014-02-02 0:17 ` Linus Torvalds [this message]
2014-02-02 1:19 ` George Spelvin
2014-02-02 1:25 ` H. Peter Anvin
2014-02-02 8:45 ` Pekka Riikonen
2014-02-02 1:06 ` Suresh Siddha
2014-02-02 1:26 ` H. Peter Anvin
2014-02-02 1:35 ` Suresh Siddha
2014-02-02 1:38 ` Linus Torvalds
2014-02-02 1:47 ` Suresh Siddha
2014-02-02 1:51 ` Linus Torvalds
2014-02-02 1:57 ` H. Peter Anvin
2014-02-02 2:05 ` Linus Torvalds
2014-02-02 2:12 ` H. Peter Anvin
2014-02-02 1:59 ` Suresh Siddha
2014-02-02 1:43 ` H. Peter Anvin
2014-02-02 1:47 ` Linus Torvalds
2014-02-02 7:19 ` Suresh Siddha
2014-02-02 19:15 ` Linus Torvalds
2014-02-03 6:56 ` Suresh Siddha
2014-02-03 18:20 ` Linus Torvalds
2014-02-04 6:03 ` Suresh Siddha
2014-02-06 5:26 ` Nate Eldredge
2014-02-06 5:34 ` George Spelvin
2014-02-13 15:45 ` Maarten Baert
2014-02-13 20:00 ` George Spelvin
2014-03-11 19:36 ` [tip:x86/urgent] x86, fpu: Check tsk_used_math() in kernel_fpu_end() for eager FPU tip-bot for Suresh Siddha
2014-02-27 23:44 ` [PATCH] Make math_state_restore() save and restore the interrupt flag H. Peter Anvin
2014-03-07 23:18 ` H. Peter Anvin
2014-03-08 6:18 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFyk=M2XeZd2rBR0hM3NQ5h8r26TgoEOtw4syaOjm3q75A@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=maarten-baert@hotmail.com \
--cc=mingo@kernel.org \
--cc=nate@thatsmathematics.com \
--cc=priikone@iki.fi \
--cc=sbsiddha@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).