linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Kees Cook <keescook@chromium.org>,
	Patrick McLean <chutzpah@gentoo.org>,
	"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] kconfig.h: Include compiler types to avoid missed struct attributes
Date: Thu, 22 Feb 2018 13:23:07 -0800	[thread overview]
Message-ID: <CA+55aFywUNouK-Y1qbnkwxM3G_WLdDVFdC0po-Xj01G4UsfSAw@mail.gmail.com> (raw)
In-Reply-To: <66556bf7-3e67-5793-081e-76a01f598374@prevas.dk>

On Thu, Feb 22, 2018 at 1:07 PM, Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
>
> It does, both per the documentation and testing it. But fixdep
> explicitly removes include/linux/kconfig.h along with
> include/generated/autoconf.h and a few others. So when you rebuilt after
> adding the #include to kconfig.h, I think nothing actually got built,
> and no new .o.cmd files got generated.

Hah. So it was the lack of kconfig.h dependency that bit my testing ;)

           Linus

  parent reply	other threads:[~2018-02-22 21:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 17:41 [PATCH v3] kconfig.h: Include compiler types to avoid missed struct attributes Kees Cook
2018-02-22 18:04 ` Linus Torvalds
2018-02-22 19:57   ` Kees Cook
2018-02-22 20:17     ` Linus Torvalds
2018-02-22 21:07   ` Rasmus Villemoes
2018-02-22 21:22     ` Kees Cook
2018-02-22 21:23     ` Linus Torvalds [this message]
2018-02-22 21:54       ` Linus Torvalds
2018-02-22 21:34     ` Rasmus Villemoes
2018-02-22 21:56       ` Linus Torvalds
2018-02-28 19:17         ` [PATCH 1/3] fixdep: remove stale references to uml-config.h Rasmus Villemoes
2018-02-28 19:17           ` [PATCH 2/3] fixdep: remove some false CONFIG_ matches Rasmus Villemoes
2018-02-28 19:17           ` [PATCH 3/3] fixdep: do not ignore kconfig.h Rasmus Villemoes
2018-03-05  4:52             ` Masahiro Yamada
2018-03-05  8:15               ` Rasmus Villemoes
2018-03-05  9:38                 ` Masahiro Yamada
2018-03-05 14:49             ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFywUNouK-Y1qbnkwxM3G_WLdDVFdC0po-Xj01G4UsfSAw@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=chutzpah@gentoo.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=rasmus.villemoes@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).