From: Linus Torvalds <torvalds@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Patrick McLean <chutzpah@gentoo.org>,
"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] kconfig.h: Include compiler types to avoid missed struct attributes
Date: Thu, 22 Feb 2018 12:17:05 -0800 [thread overview]
Message-ID: <CA+55aFzrNCsJr=Ca19oZcCEg+tR+TZNN2wkr94PyzWd5w9PT7w@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jJZh+LJYULPO=xqwz9ADm8Z3k+mKKnHXQYD2KWtwfxqbg@mail.gmail.com>
On Thu, Feb 22, 2018 at 11:57 AM, Kees Cook <keescook@chromium.org> wrote:
>
> Hmm. But does that mean deps for kconfig.h are broken too? That seems
> silly. I'll take a look...
Yes, kconfig.h itself shares the same problem, but it has generally
been just about the config option testing itself, so you'd normally
never care.
I'm not saying that fixing that too would be wrong, I'm just saying
that linux/compiler_types.h tends to have way more subtle stuff in it,
and get changed in ways that are not directly related to the config
options that we track other ways (ie our dependency making script very
much is all about those config options).
Linus
next prev parent reply other threads:[~2018-02-22 20:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 17:41 [PATCH v3] kconfig.h: Include compiler types to avoid missed struct attributes Kees Cook
2018-02-22 18:04 ` Linus Torvalds
2018-02-22 19:57 ` Kees Cook
2018-02-22 20:17 ` Linus Torvalds [this message]
2018-02-22 21:07 ` Rasmus Villemoes
2018-02-22 21:22 ` Kees Cook
2018-02-22 21:23 ` Linus Torvalds
2018-02-22 21:54 ` Linus Torvalds
2018-02-22 21:34 ` Rasmus Villemoes
2018-02-22 21:56 ` Linus Torvalds
2018-02-28 19:17 ` [PATCH 1/3] fixdep: remove stale references to uml-config.h Rasmus Villemoes
2018-02-28 19:17 ` [PATCH 2/3] fixdep: remove some false CONFIG_ matches Rasmus Villemoes
2018-02-28 19:17 ` [PATCH 3/3] fixdep: do not ignore kconfig.h Rasmus Villemoes
2018-03-05 4:52 ` Masahiro Yamada
2018-03-05 8:15 ` Rasmus Villemoes
2018-03-05 9:38 ` Masahiro Yamada
2018-03-05 14:49 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFzrNCsJr=Ca19oZcCEg+tR+TZNN2wkr94PyzWd5w9PT7w@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=chutzpah@gentoo.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).