From: Tony Luck <tony.luck@intel.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: andi@firstfloor.org, bp@amd64.org, gong.chen@linux.intel.com,
ananth@in.ibm.com, masbock@linux.vnet.ibm.com, x86@kernel.org,
linux-kernel@vger.kernel.org, lcm@us.ibm.com, mingo@redhat.com,
hpa@zytor.com, tglx@linutronix.de, gregkh@suse.de,
linux-edac@vger.kernel.org
Subject: Re: [PATCH v2] x86/mce: Honour bios-set CMCI threshold
Date: Tue, 11 Sep 2012 09:04:37 -0700 [thread overview]
Message-ID: <CA+8MBbKVa0=qUpG-rjV5ieKkponZo77mzk_y_dF4qA2gVG++6A@mail.gmail.com> (raw)
In-Reply-To: <20120911053128.3291.98346.stgit@localhost.localdomain>
On Mon, Sep 10, 2012 at 10:31 PM, Naveen N. Rao
<naveen.n.rao@linux.vnet.ibm.com> wrote:
> + if (mce_bios_cmci_threshold)
> + printk_once(KERN_INFO
> + "bios_cmci_threshold: Using bios-set threshold values for CMCI");
Do we really need this message? The user knows whether they gave
the command line option or not (and can check in /proc/cmdline if
they forgot whether they did). If it is needed, then you should add
a "\n" to it.
> + if (mce_bios_cmci_threshold && bios_wrong_thresh) {
> + printk_once(KERN_INFO
> + "bios_cmci_threshold: Some banks do not have valid thresholds set");
> + printk_once(KERN_INFO
> + "bios_cmci_threshold: Make sure your BIOS supports this boot option");
Also need "\n"
-Tony
next prev parent reply other threads:[~2012-09-11 16:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 5:31 [PATCH v2] x86/mce: Honour bios-set CMCI threshold Naveen N. Rao
2012-09-11 16:04 ` Tony Luck [this message]
2012-09-12 12:25 ` [PATCH v3] " Naveen N. Rao
2012-09-21 11:39 ` Naveen N. Rao
2012-10-17 10:59 ` Borislav Petkov
2012-10-17 11:27 ` Naveen N. Rao
2012-10-17 13:09 ` Borislav Petkov
2012-10-17 15:47 ` Naveen N. Rao
2012-10-17 16:40 ` Borislav Petkov
2012-10-17 17:28 ` Luck, Tony
2012-10-17 18:09 ` Borislav Petkov
2012-10-18 5:43 ` Naveen N. Rao
2012-10-18 13:24 ` Borislav Petkov
2012-10-18 16:46 ` Luck, Tony
2012-10-19 15:52 ` [tip:x86/urgent] x86, MCE: Remove bios_cmci_threshold sysfs attribute tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+8MBbKVa0=qUpG-rjV5ieKkponZo77mzk_y_dF4qA2gVG++6A@mail.gmail.com' \
--to=tony.luck@intel.com \
--cc=ananth@in.ibm.com \
--cc=andi@firstfloor.org \
--cc=bp@amd64.org \
--cc=gong.chen@linux.intel.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=lcm@us.ibm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).