From: tip-bot for Borislav Petkov <borislav.petkov@amd.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
naveen.n.rao@linux.vnet.ibm.com, tony.luck@intel.com,
tglx@linutronix.de, borislav.petkov@amd.com
Subject: [tip:x86/urgent] x86, MCE: Remove bios_cmci_threshold sysfs attribute
Date: Fri, 19 Oct 2012 08:52:11 -0700 [thread overview]
Message-ID: <tip-5bc66170dc486556a1e36fd384463536573f4b82@git.kernel.org> (raw)
In-Reply-To: <20121017105940.GA14590@x1.osrc.amd.com>
Commit-ID: 5bc66170dc486556a1e36fd384463536573f4b82
Gitweb: http://git.kernel.org/tip/5bc66170dc486556a1e36fd384463536573f4b82
Author: Borislav Petkov <borislav.petkov@amd.com>
AuthorDate: Thu, 18 Oct 2012 15:10:56 +0200
Committer: Borislav Petkov <borislav.petkov@amd.com>
CommitDate: Fri, 19 Oct 2012 15:22:29 +0200
x86, MCE: Remove bios_cmci_threshold sysfs attribute
450cc201038f3 ("x86/mce: Provide boot argument to honour bios-set CMCI
threshold") added the bios_cmci_threshold sysfs attribute which was
supposed to communicate to userspace tools that BIOS CMCI threshold has
been honoured.
However, this info is not of any importance to userspace - it should
rather get the actual error count it has been thresholded already from
MCi_STATUS[38:52].
So drop this before it becomes a used interface (good thing we caught
this early in 3.7-rc1, right after the merge window closed).
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Acked-by: Tony Luck <tony.luck@intel.com>
Link: http://lkml.kernel.org/r/20121017105940.GA14590@x1.osrc.amd.com
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 29e87d3..46cbf86 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2209,11 +2209,6 @@ static struct dev_ext_attribute dev_attr_cmci_disabled = {
&mce_cmci_disabled
};
-static struct dev_ext_attribute dev_attr_bios_cmci_threshold = {
- __ATTR(bios_cmci_threshold, 0444, device_show_int, NULL),
- &mce_bios_cmci_threshold
-};
-
static struct device_attribute *mce_device_attrs[] = {
&dev_attr_tolerant.attr,
&dev_attr_check_interval.attr,
@@ -2222,7 +2217,6 @@ static struct device_attribute *mce_device_attrs[] = {
&dev_attr_dont_log_ce.attr,
&dev_attr_ignore_ce.attr,
&dev_attr_cmci_disabled.attr,
- &dev_attr_bios_cmci_threshold.attr,
NULL
};
prev parent reply other threads:[~2012-10-19 15:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 5:31 [PATCH v2] x86/mce: Honour bios-set CMCI threshold Naveen N. Rao
2012-09-11 16:04 ` Tony Luck
2012-09-12 12:25 ` [PATCH v3] " Naveen N. Rao
2012-09-21 11:39 ` Naveen N. Rao
2012-10-17 10:59 ` Borislav Petkov
2012-10-17 11:27 ` Naveen N. Rao
2012-10-17 13:09 ` Borislav Petkov
2012-10-17 15:47 ` Naveen N. Rao
2012-10-17 16:40 ` Borislav Petkov
2012-10-17 17:28 ` Luck, Tony
2012-10-17 18:09 ` Borislav Petkov
2012-10-18 5:43 ` Naveen N. Rao
2012-10-18 13:24 ` Borislav Petkov
2012-10-18 16:46 ` Luck, Tony
2012-10-19 15:52 ` tip-bot for Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-5bc66170dc486556a1e36fd384463536573f4b82@git.kernel.org \
--to=borislav.petkov@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).