From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Xie He <xie.he.0141@gmail.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Brian Norris <briannorris@chromium.org>,
Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH net-next] net/packet: Fix a comment about hard_header_len and add a warning for it
Date: Sun, 13 Sep 2020 10:10:35 +0200 [thread overview]
Message-ID: <CA+FuTScP5x-FG6AHKujvfbLUeSnQfx371Z7a=59BU8QKAm+GGw@mail.gmail.com> (raw)
In-Reply-To: <CAJht_EOCZvubQRHuS_4F2vFgQSnhkrZBwLDxoougqKkm2qaCgg@mail.gmail.com>
On Sat, Sep 12, 2020 at 1:37 AM Xie He <xie.he.0141@gmail.com> wrote:
>
> On Fri, Sep 11, 2020 at 7:32 AM Willem de Bruijn
> <willemdebruijn.kernel@gmail.com> wrote:
> >
> > From a quick scan, a few device types that might trigger this
> >
> > net/atm/clip.c
> > drivers/net/wan/hdlc_fr.c
> > drivers/net/appletalk/ipddp.c
> > drivers/net/ppp/ppp_generic.c
> > drivers/net/net_failover.c
>
> I have recently fixed this problem in the "net" tree in hdlc_fr.c.
>
> Glad to see the number of drivers that have this problem is not very big.
I am concerned about adding a WARN_ON_ONCE that we already expect to
fire on some platforms.
Probably better to add the documentation without the warning.
I know I suggested the check before, sorry for the churn, but I hadn't
checked the existing state yet.
next prev parent reply other threads:[~2020-09-13 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 5:03 [PATCH net-next] net/packet: Fix a comment about hard_header_len and add a warning for it Xie He
2020-09-11 14:31 ` Willem de Bruijn
2020-09-11 23:37 ` Xie He
2020-09-13 8:10 ` Willem de Bruijn [this message]
2020-09-13 8:43 ` Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTScP5x-FG6AHKujvfbLUeSnQfx371Z7a=59BU8QKAm+GGw@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).