* [PATCH v2 net-next 1/2] net: add GSO UDP L4 and GSO fraglists to the list of software-backed types
@ 2020-11-01 13:17 Alexander Lobakin
2020-11-02 15:12 ` Willem de Bruijn
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Lobakin @ 2020-11-01 13:17 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: Jay Vosburgh, Veaceslav Falico, Andy Gospodarek, Jiri Pirko,
Steffen Klassert, Willem de Bruijn, Alexander Lobakin,
Miaohe Lin, Antoine Tenart, Mauro Carvalho Chehab, netdev,
linux-kernel
Commit e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.") and
commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") made UDP L4
and fraglisted GRO/GSO fully supported by the software fallback mode.
We can safely add them to NETIF_F_GSO_SOFTWARE to allow logical/virtual
netdevs to forward these types of skbs up to the real drivers.
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
include/linux/netdev_features.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
index 0b17c4322b09..934de56644e7 100644
--- a/include/linux/netdev_features.h
+++ b/include/linux/netdev_features.h
@@ -207,8 +207,8 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start)
NETIF_F_FSO)
/* List of features with software fallbacks. */
-#define NETIF_F_GSO_SOFTWARE (NETIF_F_ALL_TSO | \
- NETIF_F_GSO_SCTP)
+#define NETIF_F_GSO_SOFTWARE (NETIF_F_ALL_TSO | NETIF_F_GSO_SCTP | \
+ NETIF_F_GSO_UDP_L4 | NETIF_F_GSO_FRAGLIST)
/*
* If one device supports one of these features, then enable them
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 net-next 1/2] net: add GSO UDP L4 and GSO fraglists to the list of software-backed types
2020-11-01 13:17 [PATCH v2 net-next 1/2] net: add GSO UDP L4 and GSO fraglists to the list of software-backed types Alexander Lobakin
@ 2020-11-02 15:12 ` Willem de Bruijn
0 siblings, 0 replies; 2+ messages in thread
From: Willem de Bruijn @ 2020-11-02 15:12 UTC (permalink / raw)
To: Alexander Lobakin
Cc: David S. Miller, Jakub Kicinski, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, Jiri Pirko, Steffen Klassert, Miaohe Lin,
Antoine Tenart, Mauro Carvalho Chehab, Network Development,
linux-kernel
On Sun, Nov 1, 2020 at 8:17 AM Alexander Lobakin <alobakin@pm.me> wrote:
>
> Commit e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.") and
> commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") made UDP L4
> and fraglisted GRO/GSO fully supported by the software fallback mode.
> We can safely add them to NETIF_F_GSO_SOFTWARE to allow logical/virtual
> netdevs to forward these types of skbs up to the real drivers.
>
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
Acked-by: Willem de Bruijn <willemb@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-02 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01 13:17 [PATCH v2 net-next 1/2] net: add GSO UDP L4 and GSO fraglists to the list of software-backed types Alexander Lobakin
2020-11-02 15:12 ` Willem de Bruijn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).