From: Robert Marko <robert.marko@sartura.hr>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: tudor.ambarus@microchip.com,
Miquel Raynal <miquel.raynal@bootlin.com>,
richard@nod.at, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org,
Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d
Date: Fri, 25 Sep 2020 13:29:19 +0200 [thread overview]
Message-ID: <CA+HBbNEWsPvrx5U8dYfJ=Tsc4+ujCXzDJk0S_Jd5OKtVrQ0AqA@mail.gmail.com> (raw)
In-Reply-To: <6693ac3b-bf07-4a02-caca-5285dabdbb14@ti.com>
On Fri, Sep 25, 2020 at 1:27 PM Vignesh Raghavendra <vigneshr@ti.com> wrote:
>
> Hi,
>
> On 9/15/20 3:36 PM, Robert Marko wrote:
> > According to the mx25l12805d datasheet it supports using 4K or 64K sectors.
> > So lets add the SECT_4K to enable 4K sector usage.
> >
> > Datasheet: https://www.mxic.com.tw/Lists/Datasheet/Attachments/7321/MX25L12805D,%203V,%20128Mb,%20v1.2.pdf
>
> Have you tested this feature on a real HW?
Hi,
Yes, this has been tested on Alfa AP120C-AC which uses mx25l12805d.
I have not spotted any issues with it.
Regards,
Robert
>
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > Cc: Luka Perkov <luka.perkov@sartura.hr>
> > ---
> > drivers/mtd/spi-nor/macronix.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> > index f97f3d127575..9203abaac229 100644
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -50,7 +50,7 @@ static const struct flash_info macronix_parts[] = {
> > { "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
> > { "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
> > { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> > - { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
> > + { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, SECT_4K) },
> > { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
> > { "mx25r1635f", INFO(0xc22815, 0, 64 * 1024, 32,
> > SECT_4K | SPI_NOR_DUAL_READ |
> >
>
> Regards
> Vignesh
next prev parent reply other threads:[~2020-09-25 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 10:06 [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d Robert Marko
2020-09-25 11:27 ` Vignesh Raghavendra
2020-09-25 11:29 ` Robert Marko [this message]
2020-09-30 8:34 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+HBbNEWsPvrx5U8dYfJ=Tsc4+ujCXzDJk0S_Jd5OKtVrQ0AqA@mail.gmail.com' \
--to=robert.marko@sartura.hr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=luka.perkov@sartura.hr \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).