* [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d
@ 2020-09-15 10:06 Robert Marko
2020-09-25 11:27 ` Vignesh Raghavendra
2020-09-30 8:34 ` Vignesh Raghavendra
0 siblings, 2 replies; 4+ messages in thread
From: Robert Marko @ 2020-09-15 10:06 UTC (permalink / raw)
To: tudor.ambarus, miquel.raynal, richard, vigneshr, linux-mtd, linux-kernel
Cc: Robert Marko, Luka Perkov
According to the mx25l12805d datasheet it supports using 4K or 64K sectors.
So lets add the SECT_4K to enable 4K sector usage.
Datasheet: https://www.mxic.com.tw/Lists/Datasheet/Attachments/7321/MX25L12805D,%203V,%20128Mb,%20v1.2.pdf
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
drivers/mtd/spi-nor/macronix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
index f97f3d127575..9203abaac229 100644
--- a/drivers/mtd/spi-nor/macronix.c
+++ b/drivers/mtd/spi-nor/macronix.c
@@ -50,7 +50,7 @@ static const struct flash_info macronix_parts[] = {
{ "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
{ "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
{ "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
- { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
+ { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, SECT_4K) },
{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
{ "mx25r1635f", INFO(0xc22815, 0, 64 * 1024, 32,
SECT_4K | SPI_NOR_DUAL_READ |
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d
2020-09-15 10:06 [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d Robert Marko
@ 2020-09-25 11:27 ` Vignesh Raghavendra
2020-09-25 11:29 ` Robert Marko
2020-09-30 8:34 ` Vignesh Raghavendra
1 sibling, 1 reply; 4+ messages in thread
From: Vignesh Raghavendra @ 2020-09-25 11:27 UTC (permalink / raw)
To: Robert Marko, tudor.ambarus, miquel.raynal, richard, linux-mtd,
linux-kernel
Cc: Luka Perkov
Hi,
On 9/15/20 3:36 PM, Robert Marko wrote:
> According to the mx25l12805d datasheet it supports using 4K or 64K sectors.
> So lets add the SECT_4K to enable 4K sector usage.
>
> Datasheet: https://www.mxic.com.tw/Lists/Datasheet/Attachments/7321/MX25L12805D,%203V,%20128Mb,%20v1.2.pdf
Have you tested this feature on a real HW?
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> ---
> drivers/mtd/spi-nor/macronix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index f97f3d127575..9203abaac229 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -50,7 +50,7 @@ static const struct flash_info macronix_parts[] = {
> { "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
> { "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
> { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> - { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
> + { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, SECT_4K) },
> { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
> { "mx25r1635f", INFO(0xc22815, 0, 64 * 1024, 32,
> SECT_4K | SPI_NOR_DUAL_READ |
>
Regards
Vignesh
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d
2020-09-25 11:27 ` Vignesh Raghavendra
@ 2020-09-25 11:29 ` Robert Marko
0 siblings, 0 replies; 4+ messages in thread
From: Robert Marko @ 2020-09-25 11:29 UTC (permalink / raw)
To: Vignesh Raghavendra
Cc: tudor.ambarus, Miquel Raynal, richard, linux-mtd, linux-kernel,
Luka Perkov
On Fri, Sep 25, 2020 at 1:27 PM Vignesh Raghavendra <vigneshr@ti.com> wrote:
>
> Hi,
>
> On 9/15/20 3:36 PM, Robert Marko wrote:
> > According to the mx25l12805d datasheet it supports using 4K or 64K sectors.
> > So lets add the SECT_4K to enable 4K sector usage.
> >
> > Datasheet: https://www.mxic.com.tw/Lists/Datasheet/Attachments/7321/MX25L12805D,%203V,%20128Mb,%20v1.2.pdf
>
> Have you tested this feature on a real HW?
Hi,
Yes, this has been tested on Alfa AP120C-AC which uses mx25l12805d.
I have not spotted any issues with it.
Regards,
Robert
>
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > Cc: Luka Perkov <luka.perkov@sartura.hr>
> > ---
> > drivers/mtd/spi-nor/macronix.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> > index f97f3d127575..9203abaac229 100644
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -50,7 +50,7 @@ static const struct flash_info macronix_parts[] = {
> > { "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
> > { "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
> > { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> > - { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
> > + { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, SECT_4K) },
> > { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
> > { "mx25r1635f", INFO(0xc22815, 0, 64 * 1024, 32,
> > SECT_4K | SPI_NOR_DUAL_READ |
> >
>
> Regards
> Vignesh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d
2020-09-15 10:06 [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d Robert Marko
2020-09-25 11:27 ` Vignesh Raghavendra
@ 2020-09-30 8:34 ` Vignesh Raghavendra
1 sibling, 0 replies; 4+ messages in thread
From: Vignesh Raghavendra @ 2020-09-30 8:34 UTC (permalink / raw)
To: Robert Marko, linux-kernel, miquel.raynal, tudor.ambarus,
richard, linux-mtd
Cc: Vignesh Raghavendra, Luka Perkov
On Tue, 15 Sep 2020 12:06:23 +0200, Robert Marko wrote:
> According to the mx25l12805d datasheet it supports using 4K or 64K sectors.
> So lets add the SECT_4K to enable 4K sector usage.
>
> Datasheet: https://www.mxic.com.tw/Lists/Datasheet/Attachments/7321/MX25L12805D,%203V,%20128Mb,%20v1.2.pdf
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next, thanks!
[1/1] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d
https://git.kernel.org/mtd/c/02892d4053
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-30 8:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 10:06 [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d Robert Marko
2020-09-25 11:27 ` Vignesh Raghavendra
2020-09-25 11:29 ` Robert Marko
2020-09-30 8:34 ` Vignesh Raghavendra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).