From: Robert Marko <robert.marko@sartura.hr>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh+dt@kernel.org>,
gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: marvell: add Globalscale MOCHAbin
Date: Thu, 23 Sep 2021 20:15:10 +0200 [thread overview]
Message-ID: <CA+HBbNEqwoGY4tEiM3c3otjfpFYFbCCbtKn5K4vdA7QM_-kXFg@mail.gmail.com> (raw)
In-Reply-To: <YUy6PBMG25Ipr/vO@lunn.ch>
On Thu, Sep 23, 2021 at 7:32 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > + /* 88E6141 Topaz switch */
> > + switch: switch@3 {
> > + compatible = "marvell,mv88e6085";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <3>;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&cp0_switch_pins>;
> > + reset-gpios = <&cp0_gpio1 0 GPIO_ACTIVE_LOW>;
> > +
> > + interrupt-parent = <&cp0_gpio1>;
> > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
>
> The switch interrupt is a level interrupt, not an edge interrupt.
Hi Andrew,
thanks for catching this.
The same is true for the PCA9554 as well.
Will fix that now in v3.
Regards,
Robert
>
> Andrew
--
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr
prev parent reply other threads:[~2021-09-23 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 13:54 [PATCH] arm64: dts: marvell: add Globalscale MOCHAbin Robert Marko
2021-09-23 17:32 ` Andrew Lunn
2021-09-23 18:15 ` Robert Marko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+HBbNEqwoGY4tEiM3c3otjfpFYFbCCbtKn5K4vdA7QM_-kXFg@mail.gmail.com \
--to=robert.marko@sartura.hr \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).