From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: yuehaibing@huawei.com
Cc: Vincent Abriou <vincent.abriou@st.com>,
David Airlie <airlied@linux.ie>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] drm/sti: remove set but not used variable 'priv'
Date: Tue, 13 Nov 2018 12:09:10 +0100 [thread overview]
Message-ID: <CA+M3ks56PBoH3_H4a-DPKooGwx41T=K9XW5KhdRSTwRCYyOXGw@mail.gmail.com> (raw)
In-Reply-To: <1541818660-37168-1-git-send-email-yuehaibing@huawei.com>
Le sam. 10 nov. 2018 à 03:48, YueHaibing <yuehaibing@huawei.com> a écrit :
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/sti/sti_crtc.c: In function 'sti_crtc_vblank_cb':
> drivers/gpu/drm/sti/sti_crtc.c:255:22: warning:
> variable 'priv' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
> 9e1f05b28009 ("drm/sti: rename files and functions")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied on drm-misc-next.
Thanks,
Benjamin
> ---
> drivers/gpu/drm/sti/sti_crtc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
> index 61c2379..ed76e52e 100644
> --- a/drivers/gpu/drm/sti/sti_crtc.c
> +++ b/drivers/gpu/drm/sti/sti_crtc.c
> @@ -252,10 +252,8 @@ int sti_crtc_vblank_cb(struct notifier_block *nb,
> struct sti_compositor *compo;
> struct drm_crtc *crtc = data;
> struct sti_mixer *mixer;
> - struct sti_private *priv;
> unsigned int pipe;
>
> - priv = crtc->dev->dev_private;
> pipe = drm_crtc_index(crtc);
> compo = container_of(nb, struct sti_compositor, vtg_vblank_nb[pipe]);
> mixer = compo->mixer[pipe];
>
>
>
prev parent reply other threads:[~2018-11-13 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 2:57 [PATCH -next] drm/sti: remove set but not used variable 'priv' YueHaibing
2018-11-13 11:09 ` Benjamin Gaignard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+M3ks56PBoH3_H4a-DPKooGwx41T=K9XW5KhdRSTwRCYyOXGw@mail.gmail.com' \
--to=benjamin.gaignard@linaro.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.abriou@st.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).