* [PATCH] drm/stm: dsi: higher pll out only in video burst mode
@ 2019-09-12 8:56 Yannick Fertré
2019-09-16 13:16 ` Benjamin Gaignard
0 siblings, 1 reply; 2+ messages in thread
From: Yannick Fertré @ 2019-09-12 8:56 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou, David Airlie, Daniel Vetter, Maxime Coquelin,
Alexandre Torgue, dri-devel, linux-stm32, linux-arm-kernel,
linux-kernel
In order to better support video non-burst modes,
the +20% on pll out is added only in burst mode.
Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
Reviewed-by: Yannick FERTRE <yannick.fertre@st.com>
---
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
index a03a642..514efef 100644
--- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
+++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
@@ -260,8 +260,11 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
/* Compute requested pll out */
bpp = mipi_dsi_pixel_format_to_bpp(format);
pll_out_khz = mode->clock * bpp / lanes;
+
/* Add 20% to pll out to be higher than pixel bw (burst mode only) */
- pll_out_khz = (pll_out_khz * 12) / 10;
+ if (mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
+ pll_out_khz = (pll_out_khz * 12) / 10;
+
if (pll_out_khz > dsi->lane_max_kbps) {
pll_out_khz = dsi->lane_max_kbps;
DRM_WARN("Warning max phy mbps is used\n");
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/stm: dsi: higher pll out only in video burst mode
2019-09-12 8:56 [PATCH] drm/stm: dsi: higher pll out only in video burst mode Yannick Fertré
@ 2019-09-16 13:16 ` Benjamin Gaignard
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Gaignard @ 2019-09-16 13:16 UTC (permalink / raw)
To: Yannick Fertré
Cc: Philippe Cornu, Benjamin Gaignard, Vincent Abriou, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue, ML dri-devel,
linux-stm32, Linux ARM, Linux Kernel Mailing List
Le jeu. 12 sept. 2019 à 10:57, Yannick Fertré <yannick.fertre@st.com> a écrit :
>
> In order to better support video non-burst modes,
> the +20% on pll out is added only in burst mode.
>
> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> Reviewed-by: Yannick FERTRE <yannick.fertre@st.com>
Applied on drm-misc-next,
Thanks,
Benjamin
> ---
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index a03a642..514efef 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -260,8 +260,11 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
> /* Compute requested pll out */
> bpp = mipi_dsi_pixel_format_to_bpp(format);
> pll_out_khz = mode->clock * bpp / lanes;
> +
> /* Add 20% to pll out to be higher than pixel bw (burst mode only) */
> - pll_out_khz = (pll_out_khz * 12) / 10;
> + if (mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
> + pll_out_khz = (pll_out_khz * 12) / 10;
> +
> if (pll_out_khz > dsi->lane_max_kbps) {
> pll_out_khz = dsi->lane_max_kbps;
> DRM_WARN("Warning max phy mbps is used\n");
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-16 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 8:56 [PATCH] drm/stm: dsi: higher pll out only in video burst mode Yannick Fertré
2019-09-16 13:16 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).