* [PATCH -next] drm/stm: ltdc: remove set but not used variable 'src_h'
@ 2018-09-28 10:39 YueHaibing
2019-01-21 8:27 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2018-09-28 10:39 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou, David Airlie, Maxime Coquelin, Alexandre Torgue
Cc: YueHaibing, dri-devel, linux-stm32, linux-arm-kernel,
linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/stm/ltdc.c: In function 'ltdc_plane_atomic_check':
drivers/gpu/drm/stm/ltdc.c:694:13: warning:
variable 'src_y' set but not used [-Wunused-but-set-variable]
u32 src_x, src_y, src_w, src_h;
^
^
drivers/gpu/drm/stm/ltdc.c:694:6: warning:
variable 'src_x' set but not used [-Wunused-but-set-variable]
u32 src_x, src_y, src_w, src_h;
^
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/stm/ltdc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 61dd661..a91e041 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -691,7 +691,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
struct drm_plane_state *state)
{
struct drm_framebuffer *fb = state->fb;
- u32 src_x, src_y, src_w, src_h;
+ u32 src_w, src_h;
DRM_DEBUG_DRIVER("\n");
@@ -699,8 +699,6 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
return 0;
/* convert src_ from 16:16 format */
- src_x = state->src_x >> 16;
- src_y = state->src_y >> 16;
src_w = state->src_w >> 16;
src_h = state->src_h >> 16;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next] drm/stm: ltdc: remove set but not used variable 'src_h'
2018-09-28 10:39 [PATCH -next] drm/stm: ltdc: remove set but not used variable 'src_h' YueHaibing
@ 2019-01-21 8:27 ` YueHaibing
2019-01-21 9:09 ` Benjamin Gaignard
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-01-21 8:27 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou, David Airlie, Daniel Vetter, Maxime Coquelin,
Alexandre Torgue
Cc: YueHaibing, dri-devel, linux-stm32, linux-arm-kernel,
linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/stm/ltdc.c: In function 'ltdc_plane_atomic_check':
drivers/gpu/drm/stm/ltdc.c:694:13: warning:
variable 'src_y' set but not used [-Wunused-but-set-variable]
u32 src_x, src_y, src_w, src_h;
^
^
drivers/gpu/drm/stm/ltdc.c:694:6: warning:
variable 'src_x' set but not used [-Wunused-but-set-variable]
u32 src_x, src_y, src_w, src_h;
^
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/stm/ltdc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 61dd661..a91e041 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -691,7 +691,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
struct drm_plane_state *state)
{
struct drm_framebuffer *fb = state->fb;
- u32 src_x, src_y, src_w, src_h;
+ u32 src_w, src_h;
DRM_DEBUG_DRIVER("\n");
@@ -699,8 +699,6 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
return 0;
/* convert src_ from 16:16 format */
- src_x = state->src_x >> 16;
- src_y = state->src_y >> 16;
src_w = state->src_w >> 16;
src_h = state->src_h >> 16;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/stm: ltdc: remove set but not used variable 'src_h'
2019-01-21 8:27 ` YueHaibing
@ 2019-01-21 9:09 ` Benjamin Gaignard
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Gaignard @ 2019-01-21 9:09 UTC (permalink / raw)
To: YueHaibing
Cc: Yannick Fertre, Philippe Cornu, Vincent Abriou, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue, ML dri-devel,
linux-stm32, Linux ARM, Linux Kernel Mailing List,
kernel-janitors
Le lun. 21 janv. 2019 à 09:21, YueHaibing <yuehaibing@huawei.com> a écrit :
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/stm/ltdc.c: In function 'ltdc_plane_atomic_check':
> drivers/gpu/drm/stm/ltdc.c:694:13: warning:
> variable 'src_y' set but not used [-Wunused-but-set-variable]
> u32 src_x, src_y, src_w, src_h;
> ^
> ^
> drivers/gpu/drm/stm/ltdc.c:694:6: warning:
> variable 'src_x' set but not used [-Wunused-but-set-variable]
> u32 src_x, src_y, src_w, src_h;
> ^
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied on drm-misc-next,
Thanks,
Benjamin
> ---
> drivers/gpu/drm/stm/ltdc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 61dd661..a91e041 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -691,7 +691,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
> struct drm_plane_state *state)
> {
> struct drm_framebuffer *fb = state->fb;
> - u32 src_x, src_y, src_w, src_h;
> + u32 src_w, src_h;
>
> DRM_DEBUG_DRIVER("\n");
>
> @@ -699,8 +699,6 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
> return 0;
>
> /* convert src_ from 16:16 format */
> - src_x = state->src_x >> 16;
> - src_y = state->src_y >> 16;
> src_w = state->src_w >> 16;
> src_h = state->src_h >> 16;
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-21 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28 10:39 [PATCH -next] drm/stm: ltdc: remove set but not used variable 'src_h' YueHaibing
2019-01-21 8:27 ` YueHaibing
2019-01-21 9:09 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).