[PATCH] gpu: drm: sti: sti_drm_crtc.c: Remove unused function

[PATCH] gpu: drm: sti: sti_drm_crtc.c: Remove unused function

[Rickard Strandqvist]

Remove the function sti_drm_crtc_is_main() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/gpu/drm/sti/sti_drm_crtc.c |   10 ----------
 drivers/gpu/drm/sti/sti_drm_crtc.h |    1 -
 2 files changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_drm_crtc.c b/drivers/gpu/drm/sti/sti_drm_crtc.c
index d2ae0c0..be53e35 100644
--- a/drivers/gpu/drm/sti/sti_drm_crtc.c
+++ b/drivers/gpu/drm/sti/sti_drm_crtc.c
@@ -389,16 +389,6 @@ static struct drm_crtc_funcs sti_crtc_funcs = {
 	.set_property = sti_drm_crtc_set_property,
 };
 
-bool sti_drm_crtc_is_main(struct drm_crtc *crtc)
-{
-	struct sti_mixer *mixer = to_sti_mixer(crtc);
-
-	if (mixer->id == STI_MIXER_MAIN)
-		return true;
-
-	return false;
-}
-
 int sti_drm_crtc_init(struct drm_device *drm_dev, struct sti_mixer *mixer,
 		struct drm_plane *primary, struct drm_plane *cursor)
 {
diff --git a/drivers/gpu/drm/sti/sti_drm_crtc.h b/drivers/gpu/drm/sti/sti_drm_crtc.h
index caca8b1..ddae8fe 100644
--- a/drivers/gpu/drm/sti/sti_drm_crtc.h
+++ b/drivers/gpu/drm/sti/sti_drm_crtc.h
@@ -17,6 +17,5 @@ int sti_drm_crtc_enable_vblank(struct drm_device *dev, int crtc);
 void sti_drm_crtc_disable_vblank(struct drm_device *dev, int crtc);
 int sti_drm_crtc_vblank_cb(struct notifier_block *nb,
 		unsigned long event, void *data);
-bool sti_drm_crtc_is_main(struct drm_crtc *drm_crtc);
 
 #endif
-- 
1.7.10.4

Re: [PATCH] gpu: drm: sti: sti_drm_crtc.c: Remove unused function

[Benjamin Gaignard]

Hello,

Please do not apply this patch, this function is use in the next I have submit:
http://lists.freedesktop.org/archives/dri-devel/2014-December/074073.html

Regards,
Benjamin


2014-12-20 18:17 GMT+01:00 Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se>:
> Remove the function sti_drm_crtc_is_main() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  drivers/gpu/drm/sti/sti_drm_crtc.c |   10 ----------
>  drivers/gpu/drm/sti/sti_drm_crtc.h |    1 -
>  2 files changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_drm_crtc.c b/drivers/gpu/drm/sti/sti_drm_crtc.c
> index d2ae0c0..be53e35 100644
> --- a/drivers/gpu/drm/sti/sti_drm_crtc.c
> +++ b/drivers/gpu/drm/sti/sti_drm_crtc.c
> @@ -389,16 +389,6 @@ static struct drm_crtc_funcs sti_crtc_funcs = {
>         .set_property = sti_drm_crtc_set_property,
>  };
>
> -bool sti_drm_crtc_is_main(struct drm_crtc *crtc)
> -{
> -       struct sti_mixer *mixer = to_sti_mixer(crtc);
> -
> -       if (mixer->id == STI_MIXER_MAIN)
> -               return true;
> -
> -       return false;
> -}
> -
>  int sti_drm_crtc_init(struct drm_device *drm_dev, struct sti_mixer *mixer,
>                 struct drm_plane *primary, struct drm_plane *cursor)
>  {
> diff --git a/drivers/gpu/drm/sti/sti_drm_crtc.h b/drivers/gpu/drm/sti/sti_drm_crtc.h
> index caca8b1..ddae8fe 100644
> --- a/drivers/gpu/drm/sti/sti_drm_crtc.h
> +++ b/drivers/gpu/drm/sti/sti_drm_crtc.h
> @@ -17,6 +17,5 @@ int sti_drm_crtc_enable_vblank(struct drm_device *dev, int crtc);
>  void sti_drm_crtc_disable_vblank(struct drm_device *dev, int crtc);
>  int sti_drm_crtc_vblank_cb(struct notifier_block *nb,
>                 unsigned long event, void *data);
> -bool sti_drm_crtc_is_main(struct drm_crtc *drm_crtc);
>
>  #endif
> --
> 1.7.10.4
>



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog