From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
yakui.zhao@intel.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/modes: tag unused variables to avoid warnings
Date: Tue, 7 Jan 2020 14:13:38 +0100 [thread overview]
Message-ID: <CA+M3ks7ha2PkznLJ8JO=ZLo9eN2Q3ijiR+Zw9x2PKPH3Vwbovw@mail.gmail.com> (raw)
In-Reply-To: <20191210102437.19377-1-benjamin.gaignard@st.com>
Le mer. 11 déc. 2019 à 10:20, Benjamin Gaignard
<benjamin.gaignard@st.com> a écrit :
>
> Some variables are set but never used. To avoid warning when compiling
> with W=1 and keep the algorithm like it is tag theses variables
> with _maybe_unused macro.
Gentle ping.
Thanks,
Benjamin
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> changes in this version:
> - do not modify the code to remove the unused variables
> just prefix them with __maybe_unused macro.
>
> drivers/gpu/drm/drm_modes.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index 88232698d7a0..70aed4e2990d 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -233,7 +233,7 @@ struct drm_display_mode *drm_cvt_mode(struct drm_device *dev, int hdisplay,
> /* 3) Nominal HSync width (% of line period) - default 8 */
> #define CVT_HSYNC_PERCENTAGE 8
> unsigned int hblank_percentage;
> - int vsyncandback_porch, vback_porch, hblank;
> + int vsyncandback_porch, __maybe_unused vback_porch, hblank;
>
> /* estimated the horizontal period */
> tmp1 = HV_FACTOR * 1000000 -
> @@ -386,9 +386,10 @@ drm_gtf_mode_complex(struct drm_device *dev, int hdisplay, int vdisplay,
> int top_margin, bottom_margin;
> int interlace;
> unsigned int hfreq_est;
> - int vsync_plus_bp, vback_porch;
> - unsigned int vtotal_lines, vfieldrate_est, hperiod;
> - unsigned int vfield_rate, vframe_rate;
> + int vsync_plus_bp, __maybe_unused vback_porch;
> + unsigned int vtotal_lines, __maybe_unused vfieldrate_est;
> + unsigned int __maybe_unused hperiod;
> + unsigned int vfield_rate, __maybe_unused vframe_rate;
> int left_margin, right_margin;
> unsigned int total_active_pixels, ideal_duty_cycle;
> unsigned int hblank, total_pixels, pixel_freq;
> --
> 2.15.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-07 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 10:24 [PATCH] drm/modes: tag unused variables to avoid warnings Benjamin Gaignard
2020-01-07 13:13 ` Benjamin Gaignard [this message]
2020-01-07 13:24 ` Thomas Zimmermann
2020-01-09 16:18 ` Benjamin GAIGNARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+M3ks7ha2PkznLJ8JO=ZLo9eN2Q3ijiR+Zw9x2PKPH3Vwbovw@mail.gmail.com' \
--to=benjamin.gaignard@linaro.org \
--cc=airlied@linux.ie \
--cc=benjamin.gaignard@st.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).