From: Benjamin GAIGNARD <benjamin.gaignard@st.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"mripard@kernel.org" <mripard@kernel.org>,
"sean@poorly.run" <sean@poorly.run>,
"airlied@linux.ie" <airlied@linux.ie>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"yakui.zhao@intel.com" <yakui.zhao@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/modes: tag unused variables to avoid warnings
Date: Thu, 9 Jan 2020 16:18:40 +0000 [thread overview]
Message-ID: <ab5d769f-60ff-e99d-6802-d93f94fd240d@st.com> (raw)
In-Reply-To: <ec3838df-6e8a-b0d9-4b00-2fcd07f97630@suse.de>
On 1/7/20 2:24 PM, Thomas Zimmermann wrote:
> Hi
>
> Am 10.12.19 um 11:24 schrieb Benjamin Gaignard:
>> Some variables are set but never used. To avoid warning when compiling
>> with W=1 and keep the algorithm like it is tag theses variables
>> with _maybe_unused macro.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Applied on drm-misc-next.
Thanks,
Benjamin
>
>> ---
>> changes in this version:
>> - do not modify the code to remove the unused variables
>> just prefix them with __maybe_unused macro.
>>
>> drivers/gpu/drm/drm_modes.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
>> index 88232698d7a0..70aed4e2990d 100644
>> --- a/drivers/gpu/drm/drm_modes.c
>> +++ b/drivers/gpu/drm/drm_modes.c
>> @@ -233,7 +233,7 @@ struct drm_display_mode *drm_cvt_mode(struct drm_device *dev, int hdisplay,
>> /* 3) Nominal HSync width (% of line period) - default 8 */
>> #define CVT_HSYNC_PERCENTAGE 8
>> unsigned int hblank_percentage;
>> - int vsyncandback_porch, vback_porch, hblank;
>> + int vsyncandback_porch, __maybe_unused vback_porch, hblank;
>>
>> /* estimated the horizontal period */
>> tmp1 = HV_FACTOR * 1000000 -
>> @@ -386,9 +386,10 @@ drm_gtf_mode_complex(struct drm_device *dev, int hdisplay, int vdisplay,
>> int top_margin, bottom_margin;
>> int interlace;
>> unsigned int hfreq_est;
>> - int vsync_plus_bp, vback_porch;
>> - unsigned int vtotal_lines, vfieldrate_est, hperiod;
>> - unsigned int vfield_rate, vframe_rate;
>> + int vsync_plus_bp, __maybe_unused vback_porch;
>> + unsigned int vtotal_lines, __maybe_unused vfieldrate_est;
>> + unsigned int __maybe_unused hperiod;
>> + unsigned int vfield_rate, __maybe_unused vframe_rate;
>> int left_margin, right_margin;
>> unsigned int total_active_pixels, ideal_duty_cycle;
>> unsigned int hblank, total_pixels, pixel_freq;
>>
prev parent reply other threads:[~2020-01-09 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 10:24 [PATCH] drm/modes: tag unused variables to avoid warnings Benjamin Gaignard
2020-01-07 13:13 ` Benjamin Gaignard
2020-01-07 13:24 ` Thomas Zimmermann
2020-01-09 16:18 ` Benjamin GAIGNARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab5d769f-60ff-e99d-6802-d93f94fd240d@st.com \
--to=benjamin.gaignard@st.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).