linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Diego Viola <diego.viola@gmail.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, cooldavid@cooldavid.org
Subject: Re: [PATCH] jme: remove the jme driver as it is no longer maintained
Date: Mon, 22 Feb 2016 22:38:30 -0300	[thread overview]
Message-ID: <CA+ToGPG9bD5O6xbxq=hu3Ta7PwPLha9dk7dRCShhnDa=NUP-YQ@mail.gmail.com> (raw)
In-Reply-To: <CA+ToGPEQwdOvgN3OHEjHLrnAyQsCR7zHzvtHmYeKZzoq26ehjQ@mail.gmail.com>

On Sun, Feb 21, 2016 at 2:17 PM, Diego Viola <diego.viola@gmail.com> wrote:
> On Sun, Feb 21, 2016 at 9:45 AM, One Thousand Gnomes
> <gnomes@lxorguk.ukuu.org.uk> wrote:
>>> I would appreciate some hint from someone who is more experienced with drivers.
>>
>> Start by testing
>>
>> - loading the driver as a module
>> - using the networking
>> - unloading the module (and checking it stays unloaded!)
>>
>> then suspend/resume
>>
>> If that works then you have a good starting point because you know a
>> sequence of actions that suspends properly. If it fails then it's going
>> to be rather more fun because it implies something in the hardware has
>> not been properly shut down.
>>
>> Alan
>
> Hi Alan,
>
> Thanks for your email, did you see my bug report? Because I tried all
> this already.
>
> The only workarounds I've found to work is one of these:
>
> $ rmmod jme # before suspend
>
> or
>
> $ ip link set ens34 down
>
> or
>
> $ echo 0 > /sys/power/pm_async # disable async power management
>
> Then resume works fine (I can't reproduce the hang).
>
> I'm not a C developer nor a kernel developer, I tried looking at the
> jme.c driver code but it's not clear what is broken and what needs
> fixing, so I would appreciate someone more experienced looking at the
> issue and giving me an idea or two.
>
> Thanks,
> Diego

Please disregard this patch, I feel like an idiot for sending it.

I've found a fix already and sent a patch.

Diego

      reply	other threads:[~2016-02-23  1:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20 21:20 [PATCH] jme: remove the jme driver as it is no longer maintained Diego Viola
2016-02-21  0:16 ` David Miller
2016-02-21  0:33   ` Diego Viola
     [not found]     ` <20160221124506.00237916@lxorguk.ukuu.org.uk>
2016-02-21 17:17       ` Diego Viola
2016-02-23  1:38         ` Diego Viola [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+ToGPG9bD5O6xbxq=hu3Ta7PwPLha9dk7dRCShhnDa=NUP-YQ@mail.gmail.com' \
    --to=diego.viola@gmail.com \
    --cc=cooldavid@cooldavid.org \
    --cc=davem@davemloft.net \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).