* [PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
@ 2013-10-06 6:23 Michael Opdenacker
2013-10-07 6:12 ` Prabhakar Lad
0 siblings, 1 reply; 9+ messages in thread
From: Michael Opdenacker @ 2013-10-06 6:23 UTC (permalink / raw)
To: m.chehab, gregkh
Cc: prabhakar.csengg, yongjun_wei, sakari.ailus, hans.verkuil,
linux-media, devel, linux-kernel, Michael Opdenacker
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
index d8ce20d..cda8388c 100644
--- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
+++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
@@ -298,7 +298,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
{
int ret = 0;
- ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, IRQF_DISABLED,
+ ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, 0,
"vpfe_capture0", vpfe_dev);
if (ret < 0) {
v4l2_err(&vpfe_dev->v4l2_dev,
@@ -306,7 +306,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
return ret;
}
- ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, IRQF_DISABLED,
+ ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, 0,
"vpfe_capture1", vpfe_dev);
if (ret < 0) {
v4l2_err(&vpfe_dev->v4l2_dev,
@@ -316,7 +316,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
}
ret = request_irq(vpfe_dev->imp_dma_irq, vpfe_imp_dma_isr,
- IRQF_DISABLED, "Imp_Sdram_Irq", vpfe_dev);
+ 0, "Imp_Sdram_Irq", vpfe_dev);
if (ret < 0) {
v4l2_err(&vpfe_dev->v4l2_dev,
"Error: requesting IMP IRQ interrupt\n");
--
1.8.1.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
2013-10-06 6:23 [PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED Michael Opdenacker
@ 2013-10-07 6:12 ` Prabhakar Lad
2013-12-09 10:16 ` [PATCH][RESEND] " Michael Opdenacker
0 siblings, 1 reply; 9+ messages in thread
From: Prabhakar Lad @ 2013-10-07 6:12 UTC (permalink / raw)
To: Michael Opdenacker
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Wei Yongjun,
Sakari Ailus, Hans Verkuil, linux-media, devel, LKML
On Sun, Oct 6, 2013 at 11:53 AM, Michael Opdenacker
<michael.opdenacker@free-electrons.com> wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regrads,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
2013-10-07 6:12 ` Prabhakar Lad
@ 2013-12-09 10:16 ` Michael Opdenacker
2014-02-20 11:36 ` Laurent Pinchart
0 siblings, 1 reply; 9+ messages in thread
From: Michael Opdenacker @ 2013-12-09 10:16 UTC (permalink / raw)
To: m.chehab, gregkh
Cc: prabhakar.csengg, yongjun_wei, sakari.ailus, hans.verkuil,
linux-media, devel, linux-kernel, Michael Opdenacker
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
index d8ce20d2fbda..cda8388cbb89 100644
--- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
+++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
@@ -298,7 +298,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
{
int ret = 0;
- ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, IRQF_DISABLED,
+ ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, 0,
"vpfe_capture0", vpfe_dev);
if (ret < 0) {
v4l2_err(&vpfe_dev->v4l2_dev,
@@ -306,7 +306,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
return ret;
}
- ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, IRQF_DISABLED,
+ ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, 0,
"vpfe_capture1", vpfe_dev);
if (ret < 0) {
v4l2_err(&vpfe_dev->v4l2_dev,
@@ -316,7 +316,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
}
ret = request_irq(vpfe_dev->imp_dma_irq, vpfe_imp_dma_isr,
- IRQF_DISABLED, "Imp_Sdram_Irq", vpfe_dev);
+ 0, "Imp_Sdram_Irq", vpfe_dev);
if (ret < 0) {
v4l2_err(&vpfe_dev->v4l2_dev,
"Error: requesting IMP IRQ interrupt\n");
--
1.8.3.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
2013-12-09 10:16 ` [PATCH][RESEND] " Michael Opdenacker
@ 2014-02-20 11:36 ` Laurent Pinchart
2014-02-20 13:17 ` Michael Opdenacker
0 siblings, 1 reply; 9+ messages in thread
From: Laurent Pinchart @ 2014-02-20 11:36 UTC (permalink / raw)
To: Michael Opdenacker
Cc: m.chehab, gregkh, prabhakar.csengg, yongjun_wei, sakari.ailus,
hans.verkuil, linux-media, devel, linux-kernel
Hi Michael,
What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
plan to push all your IRQF_DISABLED removal patches in one go ?
On Monday 09 December 2013 11:16:22 Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
> drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c index
> d8ce20d2fbda..cda8388cbb89 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> @@ -298,7 +298,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> {
> int ret = 0;
>
> - ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, IRQF_DISABLED,
> + ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, 0,
> "vpfe_capture0", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> @@ -306,7 +306,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> return ret;
> }
>
> - ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, IRQF_DISABLED,
> + ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, 0,
> "vpfe_capture1", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> @@ -316,7 +316,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> }
>
> ret = request_irq(vpfe_dev->imp_dma_irq, vpfe_imp_dma_isr,
> - IRQF_DISABLED, "Imp_Sdram_Irq", vpfe_dev);
> + 0, "Imp_Sdram_Irq", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> "Error: requesting IMP IRQ interrupt\n");
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
2014-02-20 11:36 ` Laurent Pinchart
@ 2014-02-20 13:17 ` Michael Opdenacker
2014-02-20 13:30 ` Laurent Pinchart
2014-02-24 5:31 ` Prabhakar Lad
0 siblings, 2 replies; 9+ messages in thread
From: Michael Opdenacker @ 2014-02-20 13:17 UTC (permalink / raw)
To: Laurent Pinchart
Cc: m.chehab, gregkh, prabhakar.csengg, yongjun_wei, sakari.ailus,
hans.verkuil, linux-media, devel, linux-kernel
Hi Laurent,
On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
> Hi Michael,
>
> What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
> plan to push all your IRQF_DISABLED removal patches in one go ?
It's true a good number of my patches haven't been picked up yet, even
after multiple resends.
I was planning to ask the community tomorrow about what to do to finally
get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
in one go (or removing the definition of IRQF_DISABLED) may be the final
solution.
I hope to be able to answer your question by the end of the week.
Thanks for getting back to me about this!
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
2014-02-20 13:17 ` Michael Opdenacker
@ 2014-02-20 13:30 ` Laurent Pinchart
2014-02-24 5:31 ` Prabhakar Lad
1 sibling, 0 replies; 9+ messages in thread
From: Laurent Pinchart @ 2014-02-20 13:30 UTC (permalink / raw)
To: Michael Opdenacker
Cc: m.chehab, gregkh, prabhakar.csengg, yongjun_wei, sakari.ailus,
hans.verkuil, linux-media, devel, linux-kernel
Hi Michael,
On Thursday 20 February 2014 14:17:09 Michael Opdenacker wrote:
> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
> > Hi Michael,
> >
> > What's the status of this patch ? Do expect Prabhakar to pick it up, or do
> > you plan to push all your IRQF_DISABLED removal patches in one go ?
>
> It's true a good number of my patches haven't been picked up yet, even
> after multiple resends.
Maintainers might have assumed that you would push all the patches yourself.
That might be why Prabhakar has acked your patch but hasn't picked it up.
> I was planning to ask the community tomorrow about what to do to finally
> get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
> in one go (or removing the definition of IRQF_DISABLED) may be the final
> solution.
>
> I hope to be able to answer your question by the end of the week.
>
> Thanks for getting back to me about this!
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
2014-02-20 13:17 ` Michael Opdenacker
2014-02-20 13:30 ` Laurent Pinchart
@ 2014-02-24 5:31 ` Prabhakar Lad
2014-02-25 6:02 ` Prabhakar Lad
1 sibling, 1 reply; 9+ messages in thread
From: Prabhakar Lad @ 2014-02-24 5:31 UTC (permalink / raw)
To: Michael Opdenacker
Cc: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Wei Yongjun, Sakari Ailus, Hans Verkuil, linux-media, devel,
LKML
Hi Michael,
On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
<michael.opdenacker@free-electrons.com> wrote:
> Hi Laurent,
>
> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
>> Hi Michael,
>>
>> What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
>> plan to push all your IRQF_DISABLED removal patches in one go ?
> It's true a good number of my patches haven't been picked up yet, even
> after multiple resends.
>
> I was planning to ask the community tomorrow about what to do to finally
> get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
> in one go (or removing the definition of IRQF_DISABLED) may be the final
> solution.
>
> I hope to be able to answer your question by the end of the week.
>
gentle ping. should I pick it up ?
Regards,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
2014-02-24 5:31 ` Prabhakar Lad
@ 2014-02-25 6:02 ` Prabhakar Lad
2014-02-25 7:58 ` Michael Opdenacker
0 siblings, 1 reply; 9+ messages in thread
From: Prabhakar Lad @ 2014-02-25 6:02 UTC (permalink / raw)
To: Michael Opdenacker
Cc: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Wei Yongjun, Sakari Ailus, Hans Verkuil, linux-media, devel,
LKML
Hi Michael,
On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad
<prabhakar.csengg@gmail.com> wrote:
> Hi Michael,
>
> On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
> <michael.opdenacker@free-electrons.com> wrote:
>> Hi Laurent,
>>
>> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
>>> Hi Michael,
>>>
>>> What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
>>> plan to push all your IRQF_DISABLED removal patches in one go ?
>> It's true a good number of my patches haven't been picked up yet, even
>> after multiple resends.
>>
>> I was planning to ask the community tomorrow about what to do to finally
>> get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
>> in one go (or removing the definition of IRQF_DISABLED) may be the final
>> solution.
>>
>> I hope to be able to answer your question by the end of the week.
>>
> gentle ping. should I pick it up ?
>
I've picked it up.
Thanks,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
2014-02-25 6:02 ` Prabhakar Lad
@ 2014-02-25 7:58 ` Michael Opdenacker
0 siblings, 0 replies; 9+ messages in thread
From: Michael Opdenacker @ 2014-02-25 7:58 UTC (permalink / raw)
To: Prabhakar Lad
Cc: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Wei Yongjun, Sakari Ailus, Hans Verkuil, linux-media, devel,
LKML
Hi Prabhakar
On 02/25/2014 07:02 AM, Prabhakar Lad wrote:
> Hi Michael,
>
> On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad
> <prabhakar.csengg@gmail.com> wrote:
>> Hi Michael,
>>
>> On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
>> <michael.opdenacker@free-electrons.com> wrote:
>>> Hi Laurent,
>>>
>>> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
>>>> Hi Michael,
>>>>
>>>> What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
>>>> plan to push all your IRQF_DISABLED removal patches in one go ?
>>> It's true a good number of my patches haven't been picked up yet, even
>>> after multiple resends.
>>>
>>> I was planning to ask the community tomorrow about what to do to finally
>>> get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
>>> in one go (or removing the definition of IRQF_DISABLED) may be the final
>>> solution.
>>>
>>> I hope to be able to answer your question by the end of the week.
>>>
>> gentle ping. should I pick it up ?
>>
> I've picked it up.
>
> Thanks,
> --Prabhakar Lad
Thanks a lot! Yes, I was planning to wait for another cycle before
sending a treewide patch.
Cheers,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-02-25 7:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-06 6:23 [PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-10-07 6:12 ` Prabhakar Lad
2013-12-09 10:16 ` [PATCH][RESEND] " Michael Opdenacker
2014-02-20 11:36 ` Laurent Pinchart
2014-02-20 13:17 ` Michael Opdenacker
2014-02-20 13:30 ` Laurent Pinchart
2014-02-24 5:31 ` Prabhakar Lad
2014-02-25 6:02 ` Prabhakar Lad
2014-02-25 7:58 ` Michael Opdenacker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).