[PATCH] Sony-laptop: fix sparse warning

[PATCH] Sony-laptop: fix sparse warning

[Lad Prabhakar]

From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>

this patch fixes following sparse warning:

sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
 Found this issue on linux-next (gcc  version 4.9.2,
 sparse version  0.4.5-rc1) and applies on top linux-next.

 drivers/platform/x86/sony-laptop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 6dd1c0e..e51c1e7 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -1032,7 +1032,7 @@ struct sony_backlight_props {
 	u8			offset;
 	u8			maxlvl;
 };
-struct sony_backlight_props sony_bl_props;
+static struct sony_backlight_props sony_bl_props;
 
 static int sony_backlight_update_status(struct backlight_device *bd)
 {
-- 
1.9.1

Re: [PATCH] Sony-laptop: fix sparse warning

[Giedrius Statkevičius]

On 2015.02.05 16:49, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> 
> this patch fixes following sparse warning:
> 
> sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static?
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Don't put a comma between your first and last name, please. Also, is
this your real name and surname?

-- 
Thanks,
Giedrius

Re: [PATCH] Sony-laptop: fix sparse warning

[Lad, Prabhakar]

Hi Giedrius,

On Thu, Feb 5, 2015 at 3:55 PM, Giedrius Statkevičius
<giedrius.statkevicius@gmail.com> wrote:
> On 2015.02.05 16:49, Lad Prabhakar wrote:
>> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>>
>> this patch fixes following sparse warning:
>>
>> sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static?
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Don't put a comma between your first and last name, please. Also, is
> this your real name and surname?
>
I have hundreds of patches with:

Lad, Prabhakar <prabhakar.lad@ti.com>
Lad, Prabhakar <prabhakar.csengg@gmail.com>

I don’t want to change it now! Yes that's my real name.

Cheers,
--Prabhakar

Re: [PATCH] Sony-laptop: fix sparse warning

[Darren Hart]

On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote:
> Hi Giedrius,
> 
> On Thu, Feb 5, 2015 at 3:55 PM, Giedrius Statkevičius
> <giedrius.statkevicius@gmail.com> wrote:
> > On 2015.02.05 16:49, Lad Prabhakar wrote:
> >> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> >>
> >> this patch fixes following sparse warning:
> >>
> >> sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static?
> >>
> >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> > Don't put a comma between your first and last name, please. Also, is
> > this your real name and surname?
> >
> I have hundreds of patches with:
> 
> Lad, Prabhakar <prabhakar.lad@ti.com>
> Lad, Prabhakar <prabhakar.csengg@gmail.com>

I think there may be a problem with this in an unquoted email address. The
unquoted local part, per RFC 2822 3.4.1, can only contain  !#$%'*+-/=?^_`{|}~
and . separators.

David Miller is the one who usually catches this sort of thing. David, do we
have a problem here?

> 
> I don’t want to change it now! Yes that's my real name.
> 
> Cheers,
> --Prabhakar
> 

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] Sony-laptop: fix sparse warning

[Bjørn Mork]

Darren Hart <dvhart@infradead.org> writes:
> On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote:
>
>> Lad, Prabhakar <prabhakar.lad@ti.com>
>> Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
> I think there may be a problem with this in an unquoted email address. The
> unquoted local part, per RFC 2822 3.4.1, can only contain  !#$%'*+-/=?^_`{|}~
> and . separators.

Yes, but that is not applicable to the git commit tags.  They are not
RFC2822 header fields.  Nothing will ever parse "Lad" as an unqualified
local destination in a SOB, and therefore there is no problem using the
comma there.

Note that names using non-ascii characters are often written without
quotes i SOBs (wonder how I know this? :-).  In practice I believe the
character set is only limited by what you will allow in your git log.
The only characters with a special meaning are :<>#, and the latter is
somewhat dubious.  But it's often used as a comment separator in stable
CCs, so I guess it should be avoided for other uses.

Scripts etc trying to parse these tags into email headers must be
prepared to do the necessary stripping and quoting of any text outside
the <> brackets.

Requiring a full name is of course good for accountability, but do let
people format their names as they want them to appear in the log.
Different cultures have different traditions. Wookey has collected a few
links on this subject if anyone is interested:
http://wookware.org/name.html


Bjørn

Re: [PATCH] Sony-laptop: fix sparse warning

[Darren Hart]

On Sat, Feb 07, 2015 at 12:33:16PM +0100, Bjørn Mork wrote:
> Darren Hart <dvhart@infradead.org> writes:
> > On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote:
> >
> >> Lad, Prabhakar <prabhakar.lad@ti.com>
> >> Lad, Prabhakar <prabhakar.csengg@gmail.com>
> >
> > I think there may be a problem with this in an unquoted email address. The
> > unquoted local part, per RFC 2822 3.4.1, can only contain  !#$%'*+-/=?^_`{|}~
> > and . separators.
> 
> Yes, but that is not applicable to the git commit tags.  They are not
> RFC2822 header fields.  Nothing will ever parse "Lad" as an unqualified
> local destination in a SOB, and therefore there is no problem using the
> comma there.

Also, my reading was incorrect as "local part" refers to the text preceeding
the @ character, not the text outside the <>. So, while the name should probably
be quoted to avoid problems with MUAs interpretting the , as a list separator, I
don't have anything definitive to reference to prevent it. So at least for now,
I'll be accepting Lad's contributions as is, comma and all :-)

I really dislike this aspect of our tooling. Being so free form, it's
inevitiable for even seasoned contributors to trip over these sort of implicit
rules. It seems to me that a very significant, perhaps not the majority, of the
time I spend as maintainer is dealing with things like coding style, commit
message formatting, and similar issues. I can sympathize with those who
criticize our mechanisms as archaic :-/

> 
> Note that names using non-ascii characters are often written without
> quotes i SOBs (wonder how I know this? :-).  In practice I believe the
> character set is only limited by what you will allow in your git log.
> The only characters with a special meaning are :<>#, and the latter is
> somewhat dubious.  But it's often used as a comment separator in stable
> CCs, so I guess it should be avoided for other uses.
> 
> Scripts etc trying to parse these tags into email headers must be
> prepared to do the necessary stripping and quoting of any text outside
> the <> brackets.
> 
> Requiring a full name is of course good for accountability, but do let
> people format their names as they want them to appear in the log.
> Different cultures have different traditions. Wookey has collected a few
> links on this subject if anyone is interested:
> http://wookware.org/name.html
> 

Thanks Bjørn :-)

> 
> Bjørn
> 

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] Sony-laptop: fix sparse warning

[Darren Hart]

On Thu, Feb 05, 2015 at 02:49:41PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> 
> this patch fixes following sparse warning:
> 
> sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static?
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Queued, thanks Lad.

-- 
Darren Hart
Intel Open Source Technology Center