From: Philipp Zabel <philipp.zabel@gmail.com>
To: tom@aussec.com
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/4] pps: descriptor-based gpio, capture-clear addition
Date: Sat, 17 Nov 2018 12:11:10 +0100 [thread overview]
Message-ID: <CA+gwMccq0dwEViy-u=_mTsJD+N-Long+-3z3vzvpDfFxT4UgSw@mail.gmail.com> (raw)
In-Reply-To: <20181113034007.3878-3-tom@aussec.com>
Hi Tom,
On Tue, Nov 13, 2018 at 5:08 AM Tom Burkart <tom@aussec.com> wrote:
>
> This patch changes the GPIO access for the pps-gpio driver from the
> integer based API to the descriptor based API. It also adds
> documentation for the device tree capture-clear option and
> device tree capture-clear extraction.
>
> The change from integer based GPIO API to the descriptor based API
> breaks backward compatibility for the devicetree. This is due to
> the descriptor based API appending "-gpio" or "-gpios" (see
> Documentation/gpio/base.txt.)
Documentation/devicetree/bindings/gpio/gpio.txt says:
"While a non-existent <name> is considered valid
for compatibility reasons (resolving to the "gpios" property),
it is not allowed for new bindings."
This is not a new binding, so there should be no reason to change it.
gpiod_get() and friends support this by using the "gpios" property if
they are passed a NULL con_id.
of_find_gpio() in drivers/gpio/gpiolib-of.c contains the relevant code.
regards
Philipp
next prev parent reply other threads:[~2018-11-17 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 3:40 [PATCH v6 0/4] PPS: pps-gpio PPS ECHO implementation Tom Burkart
2018-11-13 3:40 ` [PATCH v6 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition Tom Burkart
2018-11-13 3:40 ` [PATCH v6 2/4] " Tom Burkart
2018-11-13 3:40 ` [PATCH v6 3/4] dt-bindings: pps: pps-gpio PPS ECHO implementation Tom Burkart
2018-11-13 3:40 ` [PATCH v6 4/4] pps: pps-gpio pps-echo implementation Tom Burkart
2018-11-13 15:14 ` [PATCH v6 2/4] pps: descriptor-based gpio, capture-clear addition Richard Cochran
2018-11-14 9:25 ` tom burkart
2018-11-17 11:11 ` Philipp Zabel [this message]
2018-11-17 11:24 ` tom burkart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+gwMccq0dwEViy-u=_mTsJD+N-Long+-3z3vzvpDfFxT4UgSw@mail.gmail.com' \
--to=philipp.zabel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom@aussec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).