From: Vladimir Oltean <olteanv@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
netdev <netdev@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH v2 net-next/devicetree 3/5] dt-bindings: net: dsa: ocelot: document the vsc9959 core
Date: Sat, 22 Feb 2020 14:33:05 +0200 [thread overview]
Message-ID: <CA+h21hroaskWAmCcv7UuMDEXSVAAmbX+JGTLr-pBqN-kj-=fGg@mail.gmail.com> (raw)
In-Reply-To: <20200222112841.29927-1-michael@walle.cc>
Hi Michael,
On Sat, 22 Feb 2020 at 13:28, Michael Walle <michael@walle.cc> wrote:
>
> > +Any port can be disabled, but the CPU port should be kept enabled.
>
> What is the reason for this? Do you mean if you actually want to use it? In
> fact, I'd would like to see it disabled by default in the .dtsi file. It
> doesn't make sense to just have the CPU port enabled, but not any of the
> outgoing ports. It'd just confuse the user if there is an additional
> network port which cannot be used.
>
> -michael
>
I can disable all internal ports by default, but there is one
configuration which will not work: enabling only eno3 and switch port
5. This is because the switch PCS registers belong to eno2, and if
that is disabled, the memory accesses will be invalid. So providing a
configuration with eno2 disabled by default is more likely to produce
confusion. But I'll try to clarify better next time.
> > --
> > 2.17.1
>
>
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-02-22 12:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 15:12 [PATCH v2 net-next/devicetree 0/5] DT bindings for Felix DSA switch on LS1028A Vladimir Oltean
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 1/5] arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for ENETC RCIE Vladimir Oltean
2020-02-24 6:34 ` Shawn Guo
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 2/5] net: dsa: felix: Use PHY_INTERFACE_MODE_INTERNAL instead of GMII Vladimir Oltean
2020-02-19 15:26 ` Andrew Lunn
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 3/5] dt-bindings: net: dsa: ocelot: document the vsc9959 core Vladimir Oltean
2020-02-19 15:27 ` Andrew Lunn
2020-02-22 11:28 ` Michael Walle
2020-02-22 12:33 ` Vladimir Oltean [this message]
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 4/5] arm64: dts: fsl: ls1028a: add node for Felix switch Vladimir Oltean
2020-02-22 11:38 ` Michael Walle
2020-02-22 12:25 ` Vladimir Oltean
2020-02-22 13:19 ` Michael Walle
2020-02-24 6:36 ` Shawn Guo
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 5/5] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB Vladimir Oltean
2020-02-22 11:41 ` Michael Walle
2020-02-22 12:17 ` Vladimir Oltean
2020-02-24 6:39 ` Shawn Guo
2020-02-19 19:12 ` [PATCH v2 net-next/devicetree 0/5] DT bindings for Felix DSA switch on LS1028A David Miller
2020-02-22 13:33 ` Michael Walle
2020-02-24 6:31 ` Shawn Guo
2020-02-24 7:59 ` Vladimir Oltean
2020-02-24 8:48 ` Shawn Guo
2020-02-24 8:50 ` Vladimir Oltean
2020-02-24 8:51 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+h21hroaskWAmCcv7UuMDEXSVAAmbX+JGTLr-pBqN-kj-=fGg@mail.gmail.com' \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).