From: Sedat Dilek <sedat.dilek@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Nick Desaulniers <ndesaulniers@google.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Clang-Built-Linux ML <clang-built-linux@googlegroups.com>,
David Woodhouse <dwmw2@infradead.org>,
Dmitry Golovin <dima@golovin.in>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v3 11/11] x86: support i386 with Clang
Date: Fri, 24 Jul 2020 15:22:03 +0200 [thread overview]
Message-ID: <CA+icZUVGnfO1w6CpHh5cbZ9-ozMo6LhoyKxCq9mBpVF1jCZi-Q@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a0gFG8z_qdY2gPm5p7kjpj8xq-APyazk390FpHUJiZ7Hw@mail.gmail.com>
On Thu, Jul 23, 2020 at 3:56 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Jul 23, 2020 at 3:14 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> > What happens when there is no CONFIG_64BIT line?
> > There exist explicit checks for (and "inverse") of CONFIG_64BIT like
> > "ifdef" and "ifndef" or any "defined(...)" and its opposite?
> > I remember I have seen checks for it in x86 tree.
>
> As long as you consistently pass ARCH=i386 when running 'make',
> nothing bad happens, as ARCH=i386 just hides that option.
>
> If you run "make ARCH=i386 defconfig" followed by "make olddefconfig"
> (without ARCH=i386) on a non-i386 machine, the absence of that
> CONFIG_64BIT line will lead to the kernel going back to a 64-bit
> configuration.
>
Again thank you for your feedback.
Unsure if people are aware of the different behaviours and results.
That's why I keep the same make line with and without "defconfig".
Unfortunately, I had no opportunity to test the patchset :-(.
For testing I had done:
$ MAKE_OPTS="..."
$ ARCH=x86 make V=1 -j3 $MAKE_OPTS i386_defconfig (whereas V=1 and -j3
can be dropped of course)
$ ARCH=x86 make V=1 -j3 $MAKE_OPTS
Side-note:
How wonderful my patch "x86/defconfigs: Remove CONFIG_CRYPTO_AES_586
from i386_defconfig" landed in <tip.git#x86/build>.
- Sedat -
[1] https://git.kernel.org/tip/tip/c/6526b12de07588253a52577f42ec99fc7ca26a1f
next prev parent reply other threads:[~2020-07-24 13:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 20:49 [PATCH v3 00/11] i386 Clang support Nick Desaulniers
2020-07-20 20:49 ` [PATCH v3 01/11] x86/percpu: Introduce size abstraction macros Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 02/11] x86/percpu: Clean up percpu_to_op() Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 03/11] x86/percpu: Clean up percpu_from_op() Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 04/11] x86/percpu: Clean up percpu_add_op() Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 05/11] x86/percpu: Remove "e" constraint from XADD Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 06/11] x86/percpu: Clean up percpu_add_return_op() Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 07/11] x86/percpu: Clean up percpu_xchg_op() Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 08/11] x86/percpu: Clean up percpu_cmpxchg_op() Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 09/11] x86/percpu: Clean up percpu_stable_op() Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 10/11] x86/percpu: Remove unused PER_CPU() macro Nick Desaulniers
2020-07-23 10:43 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
2020-07-20 20:49 ` [PATCH v3 11/11] x86: support i386 with Clang Nick Desaulniers
2020-07-23 9:14 ` Thomas Gleixner
2020-07-23 9:17 ` Thomas Gleixner
2020-07-23 11:06 ` Sedat Dilek
2020-07-23 11:42 ` Arnd Bergmann
2020-07-23 13:14 ` Sedat Dilek
2020-07-23 13:55 ` Arnd Bergmann
2020-07-24 13:22 ` Sedat Dilek [this message]
2020-07-23 10:43 ` [tip: x86/asm] x86/uaccess: Make __get_user_size() Clang compliant on 32-bit tip-bot2 for Nick Desaulniers
2020-07-21 8:09 ` [PATCH v3 00/11] i386 Clang support Sedat Dilek
2020-07-21 22:27 ` Dennis Zhou
2020-07-22 23:08 ` Thomas Gleixner
2020-07-22 23:25 ` Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+icZUVGnfO1w6CpHh5cbZ9-ozMo6LhoyKxCq9mBpVF1jCZi-Q@mail.gmail.com \
--to=sedat.dilek@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=cl@linux.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dennis@kernel.org \
--cc=dima@golovin.in \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).