Re: Linux 4.10-rc7

Re: Linux 4.10-rc7

[Sedat Dilek]

Hi Linus,

here in my environment I hit a pm/runtime problem.
For people seeing this too, [1] has the fix "PM / runtime: Avoid
false-positive warnings from might_sleep_if()".
Just for the records.

Regards,
- Sedat -

[1] http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=a9306a63631493afc75893a4ac405d4e1cbae6aa

Re: Linux 4.10-rc7

[Christoph Hellwig]

On Mon, Feb 06, 2017 at 04:56:55PM -0800, Linus Torvalds wrote:
> Christop,

missing h :)

> mind re-sending that patch with commit message and sign-off,
> and I'll apply it.

I'll resend it through the nfsd maintainer (Bruce).

Re: Linux 4.10-rc7

[Linus Torvalds]

On Mon, Feb 6, 2017 at 4:22 PM, Dave Jones <davej@codemonkey.org.uk> wrote:
> On Mon, Feb 06, 2017 at 09:19:24AM +0100, Christoph Hellwig wrote:
>  >
>  > Double mnt_want_write, no idea why lockdep isn't reporting that for me.
>  > Fix below:
>
> Yep, seems to do the trick.
>
> Tested-by: Dave Jones <davej@codemonkey.org.uk>

Christop, mind re-sending that patch with commit message and sign-off,
and I'll apply it.

Or just send a git pull request, of course.

                Linus

Re: Linux 4.10-rc7

[Dave Jones]

On Mon, Feb 06, 2017 at 09:19:24AM +0100, Christoph Hellwig wrote:
 > On Mon, Feb 06, 2017 at 01:00:32AM -0500, Dave Jones wrote:
 > > This one smells funny to me.
 > 
 > Double mnt_want_write, no idea why lockdep isn't reporting that for me.
 > Fix below:

Yep, seems to do the trick.

Tested-by: Dave Jones <davej@codemonkey.org.uk>

Re: Linux 4.10-rc7

[Christoph Hellwig]

On Mon, Feb 06, 2017 at 01:00:32AM -0500, Dave Jones wrote:
> This one smells funny to me.

Double mnt_want_write, no idea why lockdep isn't reporting that for me.
Fix below:

diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index ca13236dbb1f..a974368026a1 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -359,11 +359,6 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap,
 	err = fh_verify(rqstp, fhp, ftype, accmode);
 	if (err)
 		return err;
-	if (get_write_count) {
-		host_err = fh_want_write(fhp);
-		if (host_err)
-			goto out_host_err;
-	}
 
 	dentry = fhp->fh_dentry;
 	inode = d_inode(dentry);
@@ -416,6 +411,12 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap,
 
 	iap->ia_valid |= ATTR_CTIME;
 
+	if (get_write_count) {
+		host_err = fh_want_write(fhp);
+		if (host_err)
+			goto out_host_err;
+	}
+
 	fh_lock(fhp);
 	host_err = notify_change(dentry, iap, NULL);
 	fh_unlock(fhp);

Re: Linux 4.10-rc7

[Dave Jones]

On Sun, Feb 05, 2017 at 03:41:54PM -0800, Linus Torvalds wrote:
 > Hey, look at that - it's all been very quiet, and unless anything bad
 > happens, we're all back to the regular schedule with this being the
 > last rc.
 

..

 > Christoph Hellwig (1):
 >       nfsd: special case truncates some more


This one smells funny to me.

[  145.983182] =============================================
[  145.983201] [ INFO: possible recursive locking detected ]
[  145.983220] 4.10.0-rc7+ #1 Not tainted
[  145.983236] ---------------------------------------------
[  145.984868] nfsd/865 is trying to acquire lock:
[  145.986497]  (sb_writers#7){.+.+.+}, at: [<ffffffff9b1e0a25>] mnt_want_write+0x25/0x50
[  145.988153] 
but task is already holding lock:
[  145.991350]  (sb_writers#7){.+.+.+}, at: [<ffffffff9b1e0a25>] mnt_want_write+0x25/0x50
[  145.992931] 
other info that might help us debug this:
[  145.995991]  Possible unsafe locking scenario:

[  145.998936]        CPU0
[  146.000358]        ----
[  146.001749]   lock(sb_writers#7);
[  146.003109]   lock(sb_writers#7);
[  146.004431] 
 *** DEADLOCK ***

[  146.008179]  May be due to missing lock nesting notation

[  146.010541] 1 lock held by nfsd/865:
[  146.011681]  #0:  (sb_writers#7){.+.+.+}, at: [<ffffffff9b1e0a25>] mnt_want_write+0x25/0x50
[  146.012820] 
stack backtrace:
[  146.015033] CPU: 0 PID: 865 Comm: nfsd Not tainted 4.10.0-rc7+ #1
[  146.016147] Call Trace:
[  146.017225]  dump_stack+0x68/0xa0
[  146.018273]  __lock_acquire+0x6ea/0x11d0
[  146.019251]  ? trace_hardirqs_on_caller+0xef/0x1b0
[  146.020119]  lock_acquire+0x109/0x270
[  146.020957]  ? mnt_want_write+0x25/0x50
[  146.021770]  __sb_start_write+0xd8/0x230
[  146.022555]  ? mnt_want_write+0x25/0x50
[  146.023313]  ? nfsd_permission+0x7f/0x110
[  146.024042]  mnt_want_write+0x25/0x50
[  146.024745]  vfs_truncate+0x4e/0x200
[  146.025421]  nfsd_setattr+0x13a/0x300
[  146.026070]  nfsd4_setattr+0x109/0x130
[  146.026690]  nfsd4_proc_compound+0x443/0x6e0
[  146.027286]  nfsd_dispatch+0x91/0x170
[  146.027853]  svc_process+0x6e6/0xa00
[  146.028393]  nfsd+0x193/0x2a0
[  146.028903]  ? nfsd+0x5/0x2a0
[  146.029448]  kthread+0x111/0x150
[  146.029964]  ? nfsd_destroy+0x190/0x190
[  146.030474]  ? __kthread_create_on_node+0x250/0x250
[  146.030988]  ret_from_fork+0x2e/0x40


I'll double check that it's that commit in the morning, but nfs+truncate seems to point
in this direction..

	Dave

Linux 4.10-rc7

[Linus Torvalds]

Hey, look at that - it's all been very quiet, and unless anything bad
happens, we're all back to the regular schedule with this being the
last rc.

Of course, when I actually looked at my calendar, I realized that if
that actually happens, the next merge window will be awkward for me
due to travel, so it turns out that I should never have hoped for
things calming down in the first place. But I've done merge windows
during travels before, so it's not like it would necessarily be a big
problem.

And anything might happen during the next week anyway.

Anyway, rc7 is pretty small, with about half being driver fixes
(networking, GPU and HID accounts for most of it), 20% arch updates
(x86, sparc powerp, some arm64 crypto) and the rest is "misc":
filesystems, generic networking, VM, genksyms scripting etc.

It's all fairly small, and nothing particularly stands out (apart from
me being reminded once more about how much I hate modversions - we hit
another random architecture-specific tooling bug that was triggered by
it). Shortlog appended for the people who want to get an overview of
the details.

                          Linus

---

Alastair Bridgewater (1):
      drm/nouveau/disp/gt215: Fix HDA ELD handling (thus, HDMI audio) on gt215

Aleksander Morgado (1):
      USB: serial: qcserial: add Dell DW5570 QDL

Alex Deucher (1):
      drm/amdgpu/si: fix crash on headless asics

Alexander Stein (1):
      pinctrl: baytrail: Add missing spinlock usage in byt_gpio_irq_handler

Alexandre Belloni (1):
      rtc: jz4740: make the driver buildable as a module again

Alexey Brodkin (1):
      stmmac: Discard masked flags in interrupt status register

Alexey Kardashevskiy (1):
      vfio/spapr: Fix missing mutex unlock when creating a window

Alexey Khoroshilov (1):
      net: adaptec: starfire: add checks for dma mapping errors

Alison Schofield (3):
      iio: health: afe4403: retrieve a valid iio_dev in suspend/resume
      iio: health: afe4404: retrieve a valid iio_dev in suspend/resume
      iio: adc: palmas_gpadc: retrieve a valid iio_dev in suspend/resume

Amit Shah (1):
      MAINTAINERS: update email address for Amit Shah

Andy Shevchenko (3):
      pinctrl: intel: merrifield: Add missed check in mrfld_config_set()
      pinctrl: baytrail: Rectify debounce support (part 2)
      pinctrl: baytrail: Debounce register is one per community

Ard Biesheuvel (6):
      crypto: arm64/aes-blk - honour iv_out requirement in CBC and CTR modes
      efi/fdt: Avoid FDT manipulation after ExitBootServices()
      kbuild: modversions: add infrastructure for emitting relative CRCs
      modversions: treat symbol CRCs as 32 bit quantities
      module: unify absolute krctab definitions for 32-bit and 64-bit
      log2: make order_base_2() behave correctly on const input value zero

Ardinartsev Nikita (1):
      HID: hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

Arnd Bergmann (1):
      tracing/kprobes: Fix __init annotation

Arseny Solokha (1):
      gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new_page

Arvind Yadav (1):
      ata: sata_mv:- Handle return value of devm_ioremap.

Ben Skeggs (4):
      drm/nouveau/fence/g84-: protect against concurrent access to
semaphore buffers
      drm/nouveau: prevent userspace from deleting client object
      drm/nouveau/disp/mcp7x: disable dptmds workaround
      drm/nouveau/kms/nv50: request vblank events for commits that
send completion events

Bjorn Helgaas (1):
      PCI/ASPM: Handle PCI-to-PCIe bridges as roots of PCIe hierarchies

Bjørn Mork (1):
      USB: serial: option: add device ID for HP lt2523 (Novatel E371)

Borislav Petkov (2):
      x86/microcode/intel: Drop stashed AP patch pointer optimization
      x86/microcode: Do not access the initrd after it has been freed

Chris Wilson (1):
      drm/i915: Track pinned vma in intel_plane_state

Christoph Hellwig (1):
      nfsd: special case truncates some more

Christophe JAILLET (1):
      Input: synaptics-rmi4 - fix reversed conditions in enable/disable_irq_wake

Colin Ian King (2):
      regulator: twl6030: fix range comparison, allowing vsel = 59
      HID: usbhid: Quirk a AMI virtual mouse and keyboard with ALWAYS_POLL

Damien Le Moal (1):
      libata: Fix ATA request sense

Dan Carpenter (1):
      ipv6: pointer math error in ip6_tnl_parse_tlv_enc_lim()

Dan Streetman (1):
      zswap: disable changing params if init fails

Daniel Vetter (2):
      drm: prevent double-(un)registration for connectors
      drm: Don't race connector registration

Darren Stevens (1):
      powerpc: Add missing error check to prom_find_boot_cpu()

David Howells (3):
      FS-Cache: Initialise stores_lock in netfs cookie
      fscache: Clear outstanding writes when disabling a cookie
      fscache: Fix dead object requeue

David Lin (1):
      jump label: pass kbuild_cflags when checking for asm goto support

Dexuan Cui (1):
      Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

Dimitris Michailidis (2):
      ipv6: fix flow labels when the traffic class is non-0
      net: fix ndo_features_check/ndo_fix_features comment ordering

Douglas Miller (1):
      percpu-refcount: fix reference leak during percpu-atomic transition

Eric Dumazet (2):
      can: Fix kernel panic at security_sock_rcv_skb
      tcp: fix 0 divide in __tcp_select_window()

Eric Farman (1):
      scsi: virtio_scsi: Reject commands when virtqueue is broken

Gabriel Krisman Bertazi (1):
      mmc: sdhci: Ignore unexpected CARD_INT interrupts

Gal Pressman (2):
      net/mlx5e: Modify TIRs hash only when it's needed
      net/mlx5e: Fix update of hash function/key via ethtool

Gavin Shan (1):
      powerpc/eeh: Fix wrong flag passed to eeh_unfreeze_pe()

Hadar Hen Zion (1):
      net/mlx5e: Support TC encapsulation offloads with upper devices

Halil Pasic (1):
      vhost: fix initialization for vq->is_le

Iago Abal (1):
      dmaengine: pl330: fix double lock

Ilia Mirkin (1):
      drm/nouveau/nv1a,nv1f/disp: fix memory clock rate retrieval

Ivan Vecera (1):
      be2net: fix initial MAC setting

J. Bruce Fields (1):
      svcrpc: fix oops in absence of krb5 module

Jack Morgenstein (1):
      net/mlx4_core: Avoid command timeouts during VF driver device shutdown

Jason Gerecke (1):
      HID: wacom: Fix poor prox handling in 'wacom_pl_irq'

Jens Axboe (1):
      iwlwifi: fix kernel crash when unregistering thermal zone

Jiri Kosina (1):
      x86/efi: Always map the first physical page into the EFI pagetables

Jiri Slaby (1):
      objtool: Fix IRET's opcode

Jisheng Zhang (1):
      pinctrl: berlin-bg4ct: fix the value for "sd1a" of pin SCRD0_CRD_PRES

Johan Hovold (2):
      HID: cp2112: fix sleep-while-atomic
      HID: cp2112: fix gpio-callback error handling

Johannes Berg (1):
      iwlwifi: mvm: avoid crash on restart w/o reserved queues

John Brooks (1):
      iio: dht11: Use usleep_range instead of msleep for start signal

Jürg Billeter (1):
      iwlwifi: fix double hyphen in MODULE_FIRMWARE for 8000

Kalle Valo (1):
      MAINTAINERS: ath9k-devel is closed

Kevin Hao (1):
      x86/fpu: Set the xcomp_bv when we fake up a XSAVES area

Kinglong Mee (1):
      NFSD: Fix a null reference case in find_or_create_lock_stateid()

Kirill A. Shutemov (1):
      shmem: fix sleeping from atomic context

Liam R. Howlett (2):
      sparc64: Zero pages on allocation for mondo and error queues.
      sparc64: Handle PIO & MEM non-resumable errors.

Linus Torvalds (1):
      Linux 4.10-rc7

Luis R. Rodriguez (1):
      firmware: fix NULL pointer dereference in __fw_load_abort()

Lukáš Lalinský (1):
      USB: Add quirk for WORLDE easykey.25 MIDI keyboard

Maarten Lankhorst (2):
      drm/atomic: Fix double free in drm_atomic_state_default_clear
      drm/atomic: Unconditionally call prepare_fb.

Manuel Lauss (1):
      Input: wm97xx - make missing platform data non-fatal

Marc Zyngier (1):
      irqdomain: Avoid activating interrupts more than once

Marcel J.E. Mol (1):
      USB: serial: pl2303: add ATEN device ID

Mark Rutland (1):
      regulator: fixed: Revert support for ACPI interface

Martin Peres (1):
      drm/nouveau/nouveau/led: prevent compiling the led-code if
nouveau=y and leds=m

Matt Ranostay (1):
      iio: health: max30100: fixed parenthesis around FIFO count check

Max Filippov (1):
      xtensa: fix noMMU build on cores with MMU

Maxime Ripard (1):
      pinctrl: sunxi: Don't enforce bias disable (for now)

Michael Ellerman (2):
      powerpc: Revert the initial stack protector support
      powerpc: Fix build failure with clang due to BUILD_BUG_ON()

Michael S. Tsirkin (1):
      Revert "vring: Force use of DMA API for ARM-based systems with
legacy devices"

Michal Hocko (2):
      fs: break out of iomap_file_buffered_write on fatal signals
      mm, fs: check for fatal signals in do_generic_file_read()

Michel Dänzer (1):
      drm/radeon: Fix vram_size/visible values in DRM_RADEON_GEM_INFO ioctl

Mike Kravetz (1):
      sparc: use symbolic names for tsb indexing

Moshe Shemesh (1):
      net/mlx5e: Check ets capability before ets query FW command

Oliver Hartkopp (1):
      can: bcm: fix hrtimer/tasklet termination in bcm op removal

Or Gerlitz (4):
      net/mlx5: Change ENOTSUPP to EOPNOTSUPP
      net/mlx5: Return EOPNOTSUPP when failing to get steering name-space
      net/mlx5: E-Switch, Err when retrieving steering name-space fails
      net/mlx5: E-Switch, Re-enable RoCE on mode change only after FDB destroy

Pavel Belous (1):
      net: ethtool: add support for 2500BaseT and 5000BaseT link modes

Peter Zijlstra (3):
      perf/core: Fix use-after-free bug
      perf/core: Fix PERF_RECORD_MMAP2 prot/flags for anonymous memory
      kasan: respect /proc/sys/kernel/traceoff_on_warning

Rabin Vincent (1):
      cifs: initialize file_info_lock

Radim Krčmář (1):
      KVM: x86: do not save guest-unsupported XSAVE state

Rafal Ozieblo (1):
      net: macb: Fix 64 bit addressing support for GEM

Rafał Miłecki (1):
      Revert "bcma: init serial console directly from ChipCommon code"

Rask Ingemann Lambertsen (1):
      regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce

Reza Arbab (1):
      powerpc/mm: Use the correct pointer when setting a 2MB pte

Rui Miguel Silva (1):
      staging: greybus: timesync: validate platform state callback

Salvatore Benedetto (1):
      crypto: api - Clear CRYPTO_ALG_DEAD bit before registering an alg

Sean Nyekjaer (1):
      net: phy: micrel: KSZ8795 do not set SUPPORTED_[Asym_]Pause

Simon Horman (1):
      net/sched: cls_flower: Correct matching on ICMPv6 code

Steven Rostedt (VMware) (1):
      tracing: Fix hwlat kthread migration

Tejun Heo (2):
      libata: apply MAX_SEC_1024 to all CX1-JB*-HP devices
      cgroup: don't online subsystems before cgroup_name/path() are operational

Thomas Gleixner (5):
      x86/irq: Make irq activate operations symmetric
      x86/mce: Make timer handling more robust
      perf/x86/intel/rapl: Make package handling more robust
      perf/x86/intel/uncore: Clean up hotplug conversion fallout
      perf/x86/intel/uncore: Make package handling more robust

Tom Hromatka (1):
      sparc: Fixed typo in sstate.c. Replaced panicing with panicking

Tony Lindgren (5):
      dmaengine: cppi41: Fix runtime PM timeouts with USB mass storage
      dmaengine: cppi41: Fix oops in cppi41_runtime_resume
      dmaengine: cppi41: Clean up pointless warnings
      usb: musb: Fix host mode error -71 regression
      usb: musb: Fix external abort on non-linefetch for musb_irq_work()

Toshi Kani (2):
      mm/memory_hotplug.c: check start_pfn in test_pages_in_a_zone()
      base/memory, hotplug: fix a kernel oops in show_valid_zones()

Vincent (1):
      net: thunderx: avoid dereferencing xcv when NULL

Vincent Pelletier (1):
      usb: gadget: f_fs: Assorted buffer overflow checks.

Vlad Yasevich (1):
      ipv6: Paritially checksum full MTU frames

Yotam Gigi (1):
      net/sched: matchall: Fix configuration race

Yu-cheng Yu (1):
      x86/fpu/xstate: Fix xcomp_bv in XSAVES header