* kbuild: do not pass $(KBUILD_CFLAGS) to scripts/mkcompile_h
@ 2020-04-06 10:02 Sedat Dilek
2020-04-07 18:55 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Sedat Dilek @ 2020-04-06 10:02 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, linux-kernel, Kees Cook, Nick Desaulniers, Thomas Gleixner
[ Please CC me I am not subscribed to this mailing-list ]
Hi,
I think with your patch in [1] line #56 can go away, too?
[ scripts/mkcompile_h ]
53 # Generate a temporary compile.h
54
55 { echo /\* This file is auto generated, version $VERSION \*/
56 if [ -n "$CONFIG_FLAGS" ] ; then echo "/* $CONFIG_FLAGS */"; fi
Thanks.
Regards,
- Sedat -
[1] https://patchwork.kernel.org/patch/11473667/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: kbuild: do not pass $(KBUILD_CFLAGS) to scripts/mkcompile_h
2020-04-06 10:02 kbuild: do not pass $(KBUILD_CFLAGS) to scripts/mkcompile_h Sedat Dilek
@ 2020-04-07 18:55 ` Masahiro Yamada
2020-04-08 8:00 ` Sedat Dilek
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2020-04-07 18:55 UTC (permalink / raw)
To: Sedat Dilek
Cc: Linux Kbuild mailing list, Linux Kernel Mailing List, Kees Cook,
Nick Desaulniers, Thomas Gleixner
Hi Sedat,
On Mon, Apr 6, 2020 at 7:01 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> [ Please CC me I am not subscribed to this mailing-list ]
>
> Hi,
>
> I think with your patch in [1] line #56 can go away, too?
>
> [ scripts/mkcompile_h ]
>
> 53 # Generate a temporary compile.h
> 54
> 55 { echo /\* This file is auto generated, version $VERSION \*/
> 56 if [ -n "$CONFIG_FLAGS" ] ; then echo "/* $CONFIG_FLAGS */"; fi
I think the this inserts a comment line
to make sure compile.h is updated
when any of CONFIG_SMP, CONFIG_PREEMPT, CONFIG_PREEMPT_RT
is changed.
So, this is unrelated to my patch at least.
> Thanks.
>
> Regards,
> - Sedat -
>
> [1] https://patchwork.kernel.org/patch/11473667/
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: kbuild: do not pass $(KBUILD_CFLAGS) to scripts/mkcompile_h
2020-04-07 18:55 ` Masahiro Yamada
@ 2020-04-08 8:00 ` Sedat Dilek
0 siblings, 0 replies; 3+ messages in thread
From: Sedat Dilek @ 2020-04-08 8:00 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Linux Kbuild mailing list, Linux Kernel Mailing List, Kees Cook,
Nick Desaulniers, Thomas Gleixner
On Tue, Apr 7, 2020 at 8:56 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Hi Sedat,
>
> On Mon, Apr 6, 2020 at 7:01 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >
> > [ Please CC me I am not subscribed to this mailing-list ]
> >
> > Hi,
> >
> > I think with your patch in [1] line #56 can go away, too?
> >
> > [ scripts/mkcompile_h ]
> >
> > 53 # Generate a temporary compile.h
> > 54
> > 55 { echo /\* This file is auto generated, version $VERSION \*/
> > 56 if [ -n "$CONFIG_FLAGS" ] ; then echo "/* $CONFIG_FLAGS */"; fi
>
>
>
> I think the this inserts a comment line
> to make sure compile.h is updated
> when any of CONFIG_SMP, CONFIG_PREEMPT, CONFIG_PREEMPT_RT
> is changed.
>
> So, this is unrelated to my patch at least.
>
I mixed up CONFIG_FLAGS with KBUILD_CFLAGS - my bad.
- sed@ -
>
> > Thanks.
> >
> > Regards,
> > - Sedat -
> >
> > [1] https://patchwork.kernel.org/patch/11473667/
>
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-08 8:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 10:02 kbuild: do not pass $(KBUILD_CFLAGS) to scripts/mkcompile_h Sedat Dilek
2020-04-07 18:55 ` Masahiro Yamada
2020-04-08 8:00 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).