From: Lorenzo Stoakes <lstoakes@gmail.com>
To: linux-mm <linux-mm@kvack.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Michal Hocko <mhocko@kernel.org>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] drm/via: use get_user_pages_unlocked()
Date: Mon, 20 Feb 2017 18:46:54 +0000 [thread overview]
Message-ID: <CAA5enKYhsACE+LFdjQexEOnOVLAC+soXs4kEtT4fxm2W7MiU=g@mail.gmail.com> (raw)
In-Reply-To: <CAA5enKbkwP0P1sC4WAMf_SP2QM6-Vg8YMXs_=CkNzav4yTm1ow@mail.gmail.com>
On 6 January 2017 at 07:09, Lorenzo Stoakes <lstoakes@gmail.com> wrote:
>
> Adding Andrew, as this may be another less active corner of the corner, thanks!
Hi all,
Thought I'd also give this one a gentle nudge now the merge window has
re-opened, Andrew - are you ok to pick this up? I've checked the patch
and it still applies, for convenience the raw patch is available at
https://marc.info/?l=linux-mm&m=147802942832515&q=raw - let me know if
there's anything else I can do on this or if you'd prefer a re-send.
Best, Lorenzo
> On 3 January 2017 at 20:23, Lorenzo Stoakes <lstoakes@gmail.com> wrote:
>> Hi All,
>>
>> Just a gentle ping on this one :)
>>
>> Cheers, Lorenzo
>>
>> On 1 November 2016 at 19:43, Lorenzo Stoakes <lstoakes@gmail.com> wrote:
>>> Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code
>>> and takes advantage of VM_FAULT_RETRY functionality when faulting in pages.
>>>
>>> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
>>> ---
>>> drivers/gpu/drm/via/via_dmablit.c | 10 +++-------
>>> 1 file changed, 3 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c
>>> index 1a3ad76..98aae98 100644
>>> --- a/drivers/gpu/drm/via/via_dmablit.c
>>> +++ b/drivers/gpu/drm/via/via_dmablit.c
>>> @@ -238,13 +238,9 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer)
>>> vsg->pages = vzalloc(sizeof(struct page *) * vsg->num_pages);
>>> if (NULL == vsg->pages)
>>> return -ENOMEM;
>>> - down_read(¤t->mm->mmap_sem);
>>> - ret = get_user_pages((unsigned long)xfer->mem_addr,
>>> - vsg->num_pages,
>>> - (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0,
>>> - vsg->pages, NULL);
>>> -
>>> - up_read(¤t->mm->mmap_sem);
>>> + ret = get_user_pages_unlocked((unsigned long)xfer->mem_addr,
>>> + vsg->num_pages, vsg->pages,
>>> + (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0);
>>> if (ret != vsg->num_pages) {
>>> if (ret < 0)
>>> return ret;
>>> --
>>> 2.10.2
>>>
--
Lorenzo Stoakes
https://ljs.io
next prev parent reply other threads:[~2017-02-20 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 19:43 [PATCH] drm/via: use get_user_pages_unlocked() Lorenzo Stoakes
2017-01-03 20:23 ` Lorenzo Stoakes
2017-01-06 7:09 ` Lorenzo Stoakes
2017-02-20 18:46 ` Lorenzo Stoakes [this message]
2017-02-26 19:40 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA5enKYhsACE+LFdjQexEOnOVLAC+soXs4kEtT4fxm2W7MiU=g@mail.gmail.com' \
--to=lstoakes@gmail.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).