Re: [PATCH] drm/via: use get_user_pages_unlocked()

From: Lorenzo Stoakes <lstoakes@gmail.com>
To: linux-mm <linux-mm@kvack.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Michal Hocko <mhocko@kernel.org>, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Lorenzo Stoakes <lstoakes@gmail.com>
Subject: Re: [PATCH] drm/via: use get_user_pages_unlocked()
Date: Tue, 3 Jan 2017 20:23:20 +0000	[thread overview]
Message-ID: <CAA5enKai6Gq7gCf6mmuXJwZrds5N8s9JAtNGxy1vAJD1zSmb2Q@mail.gmail.com> (raw)
In-Reply-To: <20161101194337.24015-1-lstoakes@gmail.com>

Hi All,

Just a gentle ping on this one :)

Cheers, Lorenzo

On 1 November 2016 at 19:43, Lorenzo Stoakes <lstoakes@gmail.com> wrote:
> Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code
> and takes advantage of VM_FAULT_RETRY functionality when faulting in pages.
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> ---
>  drivers/gpu/drm/via/via_dmablit.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c
> index 1a3ad76..98aae98 100644
> --- a/drivers/gpu/drm/via/via_dmablit.c
> +++ b/drivers/gpu/drm/via/via_dmablit.c
> @@ -238,13 +238,9 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg,  drm_via_dmablit_t *xfer)
>         vsg->pages = vzalloc(sizeof(struct page *) * vsg->num_pages);
>         if (NULL == vsg->pages)
>                 return -ENOMEM;
> -       down_read(&current->mm->mmap_sem);
> -       ret = get_user_pages((unsigned long)xfer->mem_addr,
> -                            vsg->num_pages,
> -                            (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0,
> -                            vsg->pages, NULL);
> -
> -       up_read(&current->mm->mmap_sem);
> +       ret = get_user_pages_unlocked((unsigned long)xfer->mem_addr,
> +                       vsg->num_pages, vsg->pages,
> +                       (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0);
>         if (ret != vsg->num_pages) {
>                 if (ret < 0)
>                         return ret;
> --
> 2.10.2
>

-- 
Lorenzo Stoakes
https://ljs.io