From: Tong Zhang <ztong0001@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sean Nyekjaer <sean@geanix.com>,
Alexandru Ardelean <ardeleanalex@gmail.com>,
Jonathan Albrieux <jonathan.albrieux@gmail.com>,
linux-iio <linux-iio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] iio:imu:bmi160: disable regulator in error path
Date: Sun, 27 Mar 2022 08:58:36 -0700 [thread overview]
Message-ID: <CAA5qM4AGvTrcGu=RRi-fDrAC8aE2FN-Y+79-24LV0MerEN-5CQ@mail.gmail.com> (raw)
In-Reply-To: <20220327165336.799db3ac@jic23-huawei>
On Sun, Mar 27, 2022 at 8:46 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun, 27 Mar 2022 08:40:05 -0700
> Tong Zhang <ztong0001@gmail.com> wrote:
>
> > Regulator should be disabled in error path as mentioned in _regulator_put().
> > Also disable accel if gyro cannot be enabled.
> >
> > [ 16.233604] WARNING: CPU: 0 PID: 2177 at drivers/regulator/core.c:2257 _regulator_put
> > [ 16.240453] Call Trace:
> > [ 16.240572] <TASK>
> > [ 16.240676] regulator_put+0x26/0x40
> > [ 16.240853] regulator_bulk_free+0x26/0x50
> > [ 16.241050] release_nodes+0x3f/0x70
> > [ 16.241225] devres_release_group+0x147/0x1c0
> > [ 16.241441] ? bmi160_core_probe+0x175/0x3a0 [bmi160_core]
> >
> > Fixes: 5dea3fb066f0 ("iio: imu: bmi160: added regulator support")
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> oops. Raced with you ;)
>
> Anyhow, I added the tag, so no problem.
>
> Jonathan
No problem. Have a nice weekend!:-)
- Tong
>
> > ---
> > v2: also disable accel when gyro fail to enable
> > v3: add tag
> > drivers/iio/imu/bmi160/bmi160_core.c | 20 ++++++++++++++------
> > 1 file changed, 14 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
> > index 824b5124a5f5..01336105792e 100644
> > --- a/drivers/iio/imu/bmi160/bmi160_core.c
> > +++ b/drivers/iio/imu/bmi160/bmi160_core.c
> > @@ -730,7 +730,7 @@ static int bmi160_chip_init(struct bmi160_data *data, bool use_spi)
> >
> > ret = regmap_write(data->regmap, BMI160_REG_CMD, BMI160_CMD_SOFTRESET);
> > if (ret)
> > - return ret;
> > + goto disable_regulator;
> >
> > usleep_range(BMI160_SOFTRESET_USLEEP, BMI160_SOFTRESET_USLEEP + 1);
> >
> > @@ -741,29 +741,37 @@ static int bmi160_chip_init(struct bmi160_data *data, bool use_spi)
> > if (use_spi) {
> > ret = regmap_read(data->regmap, BMI160_REG_DUMMY, &val);
> > if (ret)
> > - return ret;
> > + goto disable_regulator;
> > }
> >
> > ret = regmap_read(data->regmap, BMI160_REG_CHIP_ID, &val);
> > if (ret) {
> > dev_err(dev, "Error reading chip id\n");
> > - return ret;
> > + goto disable_regulator;
> > }
> > if (val != BMI160_CHIP_ID_VAL) {
> > dev_err(dev, "Wrong chip id, got %x expected %x\n",
> > val, BMI160_CHIP_ID_VAL);
> > - return -ENODEV;
> > + ret = -ENODEV;
> > + goto disable_regulator;
> > }
> >
> > ret = bmi160_set_mode(data, BMI160_ACCEL, true);
> > if (ret)
> > - return ret;
> > + goto disable_regulator;
> >
> > ret = bmi160_set_mode(data, BMI160_GYRO, true);
> > if (ret)
> > - return ret;
> > + goto disable_accel;
> >
> > return 0;
> > +
> > +disable_accel:
> > + bmi160_set_mode(data, BMI160_ACCEL, false);
> > +
> > +disable_regulator:
> > + regulator_bulk_disable(ARRAY_SIZE(data->supplies), data->supplies);
> > + return ret;
> > }
> >
> > static int bmi160_data_rdy_trigger_set_state(struct iio_trigger *trig,
>
next prev parent reply other threads:[~2022-03-27 15:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 7:09 [PATCH] iio:imu:bmi160: disable regulator in error path Tong Zhang
2022-03-18 14:11 ` Andy Shevchenko
2022-03-19 16:20 ` Jonathan Cameron
2022-03-19 19:33 ` Tong Zhang
2022-03-19 19:34 ` [PATCH v2] " Tong Zhang
2022-03-21 8:27 ` Andy Shevchenko
2022-03-21 15:53 ` Tong Zhang
2022-03-21 16:22 ` Andy Shevchenko
2022-03-27 15:51 ` Jonathan Cameron
2022-03-27 15:40 ` [PATCH v3] " Tong Zhang
2022-03-27 15:53 ` Jonathan Cameron
2022-03-27 15:58 ` Tong Zhang [this message]
2022-03-27 16:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA5qM4AGvTrcGu=RRi-fDrAC8aE2FN-Y+79-24LV0MerEN-5CQ@mail.gmail.com' \
--to=ztong0001@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardeleanalex@gmail.com \
--cc=jic23@kernel.org \
--cc=jonathan.albrieux@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).