From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Tong Zhang <ztong0001@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Sean Nyekjaer <sean@geanix.com>,
Alexandru Ardelean <ardeleanalex@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Albrieux <jonathan.albrieux@gmail.com>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio:imu:bmi160: disable regulator in error path
Date: Mon, 21 Mar 2022 10:27:37 +0200 [thread overview]
Message-ID: <CAHp75Vfk+CQZoz+s5PuSTBb0Nb4KLB+yoNiTCJQ4NktxV1nycQ@mail.gmail.com> (raw)
In-Reply-To: <20220319193459.2628876-1-ztong0001@gmail.com>
On Sun, Mar 20, 2022 at 8:44 AM Tong Zhang <ztong0001@gmail.com> wrote:
>
> Regulator should be disabled in error path as mentioned in _regulator_put().
> Also disable accel if gyro cannot be enabled.
>
> [ 16.233604] WARNING: CPU: 0 PID: 2177 at drivers/regulator/core.c:2257 _regulator_put
> [ 16.240453] Call Trace:
> [ 16.240572] <TASK>
> [ 16.240676] regulator_put+0x26/0x40
> [ 16.240853] regulator_bulk_free+0x26/0x50
> [ 16.241050] release_nodes+0x3f/0x70
> [ 16.241225] devres_release_group+0x147/0x1c0
> [ 16.241441] ? bmi160_core_probe+0x175/0x3a0 [bmi160_core]
Haven't I given you a tag?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-21 8:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 7:09 [PATCH] iio:imu:bmi160: disable regulator in error path Tong Zhang
2022-03-18 14:11 ` Andy Shevchenko
2022-03-19 16:20 ` Jonathan Cameron
2022-03-19 19:33 ` Tong Zhang
2022-03-19 19:34 ` [PATCH v2] " Tong Zhang
2022-03-21 8:27 ` Andy Shevchenko [this message]
2022-03-21 15:53 ` Tong Zhang
2022-03-21 16:22 ` Andy Shevchenko
2022-03-27 15:51 ` Jonathan Cameron
2022-03-27 15:40 ` [PATCH v3] " Tong Zhang
2022-03-27 15:53 ` Jonathan Cameron
2022-03-27 15:58 ` Tong Zhang
2022-03-27 16:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vfk+CQZoz+s5PuSTBb0Nb4KLB+yoNiTCJQ4NktxV1nycQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardeleanalex@gmail.com \
--cc=jic23@kernel.org \
--cc=jonathan.albrieux@gmail.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean@geanix.com \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).