* [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf
@ 2022-06-07 11:08 Miaoqian Lin
2022-06-07 15:39 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Miaoqian Lin @ 2022-06-07 11:08 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Stephen Boyd, David Heidelberg,
Guo Zhengkui, Xu Wang, Miaoqian Lin, Neil Armstrong, Rob Herring,
linux-arm-msm, dri-devel, freedreno, linux-kernel
of_graph_get_remote_node() returns remote device node pointer with
refcount incremented, we should use of_node_put() on it
when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
index fb48c8c19ec3..17cb1fc78379 100644
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
@@ -216,6 +216,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
encoder = mdp4_lcdc_encoder_init(dev, panel_node);
if (IS_ERR(encoder)) {
DRM_DEV_ERROR(dev->dev, "failed to construct LCDC encoder\n");
+ of_node_put(panel_node);
return PTR_ERR(encoder);
}
@@ -225,6 +226,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
connector = mdp4_lvds_connector_init(dev, panel_node, encoder);
if (IS_ERR(connector)) {
DRM_DEV_ERROR(dev->dev, "failed to initialize LVDS connector\n");
+ of_node_put(panel_node);
return PTR_ERR(connector);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf
2022-06-07 11:08 [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf Miaoqian Lin
@ 2022-06-07 15:39 ` Dmitry Baryshkov
2022-06-08 22:14 ` Stephen Boyd
2022-06-10 23:20 ` Abhinav Kumar
2 siblings, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2022-06-07 15:39 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Rob Clark, Abhinav Kumar, Sean Paul, David Airlie, Daniel Vetter,
Stephen Boyd, David Heidelberg, Guo Zhengkui, Xu Wang,
Neil Armstrong, Rob Herring, linux-arm-msm, dri-devel, freedreno,
linux-kernel
On Tue, 7 Jun 2022 at 14:08, Miaoqian Lin <linmq006@gmail.com> wrote:
>
> of_graph_get_remote_node() returns remote device node pointer with
> refcount incremented, we should use of_node_put() on it
> when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf
2022-06-07 11:08 [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf Miaoqian Lin
2022-06-07 15:39 ` Dmitry Baryshkov
@ 2022-06-08 22:14 ` Stephen Boyd
2022-06-10 23:20 ` Abhinav Kumar
2 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2022-06-08 22:14 UTC (permalink / raw)
To: Abhinav Kumar, Daniel Vetter, David Airlie, David Heidelberg,
Dmitry Baryshkov, Guo Zhengkui, Miaoqian Lin, Neil Armstrong,
Rob Clark, Rob Herring, Sean Paul, Xu Wang, dri-devel, freedreno,
linux-arm-msm, linux-kernel
Quoting Miaoqian Lin (2022-06-07 04:08:38)
> of_graph_get_remote_node() returns remote device node pointer with
> refcount incremented, we should use of_node_put() on it
> when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf
2022-06-07 11:08 [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf Miaoqian Lin
2022-06-07 15:39 ` Dmitry Baryshkov
2022-06-08 22:14 ` Stephen Boyd
@ 2022-06-10 23:20 ` Abhinav Kumar
2022-06-14 10:07 ` Miaoqian Lin
2 siblings, 1 reply; 7+ messages in thread
From: Abhinav Kumar @ 2022-06-10 23:20 UTC (permalink / raw)
To: Miaoqian Lin, Rob Clark, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Stephen Boyd, David Heidelberg,
Guo Zhengkui, Xu Wang, Neil Armstrong, Rob Herring,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On 6/7/2022 4:08 AM, Miaoqian Lin wrote:
> of_graph_get_remote_node() returns remote device node pointer with
> refcount incremented, we should use of_node_put() on it
> when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 ++
> 1 file changed, 2 insertions(+)
>
This patch itself looks fine and will cover the cases when there was an
error and we did not release the refcount.
But, even in the normal cases I am not finding where we are releasing
the refcount for the panel_node.
I dont see a of_node_put() on mdp4_lcdc_encoder->panel_node.
Am i missing something?
> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
> index fb48c8c19ec3..17cb1fc78379 100644
> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
> @@ -216,6 +216,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
> encoder = mdp4_lcdc_encoder_init(dev, panel_node);
> if (IS_ERR(encoder)) {
> DRM_DEV_ERROR(dev->dev, "failed to construct LCDC encoder\n");
> + of_node_put(panel_node);
> return PTR_ERR(encoder);
> }
>
> @@ -225,6 +226,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
> connector = mdp4_lvds_connector_init(dev, panel_node, encoder);
> if (IS_ERR(connector)) {
> DRM_DEV_ERROR(dev->dev, "failed to initialize LVDS connector\n");
> + of_node_put(panel_node);
> return PTR_ERR(connector);
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf
2022-06-10 23:20 ` Abhinav Kumar
@ 2022-06-14 10:07 ` Miaoqian Lin
2022-06-14 10:09 ` Dmitry Baryshkov
0 siblings, 1 reply; 7+ messages in thread
From: Miaoqian Lin @ 2022-06-14 10:07 UTC (permalink / raw)
To: Abhinav Kumar, Rob Clark, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Stephen Boyd, David Heidelberg,
Guo Zhengkui, Xu Wang, Neil Armstrong, Rob Herring,
linux-arm-msm, dri-devel, freedreno, linux-kernel
Hi, Abhinav
On 2022/6/11 7:20, Abhinav Kumar wrote:
>
>
> On 6/7/2022 4:08 AM, Miaoqian Lin wrote:
>> of_graph_get_remote_node() returns remote device node pointer with
>> refcount incremented, we should use of_node_put() on it
>> when not need anymore.
>> Add missing of_node_put() to avoid refcount leak.
>>
>> Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node")
>> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>> ---
>> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>
> This patch itself looks fine and will cover the cases when there was an error and we did not release the refcount.
>
> But, even in the normal cases I am not finding where we are releasing the refcount for the panel_node.
>
> I dont see a of_node_put() on mdp4_lcdc_encoder->panel_node.
>
Thanks for your review.
I don't see it either. It's a bit messy because the reference assigned to mdp4_lcdc_encoder->panel_node and mdp4_lvds_connector->panel_node both.
> Am i missing something?
>
>> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>> index fb48c8c19ec3..17cb1fc78379 100644
>> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>> @@ -216,6 +216,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
>> encoder = mdp4_lcdc_encoder_init(dev, panel_node);
>> if (IS_ERR(encoder)) {
>> DRM_DEV_ERROR(dev->dev, "failed to construct LCDC encoder\n");
>> + of_node_put(panel_node);
>> return PTR_ERR(encoder);
>> }
>> @@ -225,6 +226,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
>> connector = mdp4_lvds_connector_init(dev, panel_node, encoder);
>> if (IS_ERR(connector)) {
>> DRM_DEV_ERROR(dev->dev, "failed to initialize LVDS connector\n");
>> + of_node_put(panel_node);
>> return PTR_ERR(connector);
>> }
>>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf
2022-06-14 10:07 ` Miaoqian Lin
@ 2022-06-14 10:09 ` Dmitry Baryshkov
2022-06-14 16:31 ` Abhinav Kumar
0 siblings, 1 reply; 7+ messages in thread
From: Dmitry Baryshkov @ 2022-06-14 10:09 UTC (permalink / raw)
To: Miaoqian Lin, Abhinav Kumar, Rob Clark, Sean Paul, David Airlie,
Daniel Vetter, Stephen Boyd, David Heidelberg, Guo Zhengkui,
Xu Wang, Neil Armstrong, Rob Herring, linux-arm-msm, dri-devel,
freedreno, linux-kernel
On 14/06/2022 13:07, Miaoqian Lin wrote:
> Hi, Abhinav
>
> On 2022/6/11 7:20, Abhinav Kumar wrote:
>>
>>
>> On 6/7/2022 4:08 AM, Miaoqian Lin wrote:
>>> of_graph_get_remote_node() returns remote device node pointer with
>>> refcount incremented, we should use of_node_put() on it
>>> when not need anymore.
>>> Add missing of_node_put() to avoid refcount leak.
>>>
>>> Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node")
>>> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>>> ---
>>> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>
>> This patch itself looks fine and will cover the cases when there was an error and we did not release the refcount.
>>
>> But, even in the normal cases I am not finding where we are releasing the refcount for the panel_node.
>>
>> I dont see a of_node_put() on mdp4_lcdc_encoder->panel_node.
>>
> Thanks for your review.
>
> I don't see it either. It's a bit messy because the reference assigned to mdp4_lcdc_encoder->panel_node and mdp4_lvds_connector->panel_node both.
I have a plan to rework mdp4 lcdc support once I get my ifc6410 lvds
cable. Thus I think we can land this patch now and fix the mdp4
lcdc/lvds code leaking the reference in the due time.
>
>> Am i missing something?
>>
>>> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>> index fb48c8c19ec3..17cb1fc78379 100644
>>> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>> @@ -216,6 +216,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
>>> encoder = mdp4_lcdc_encoder_init(dev, panel_node);
>>> if (IS_ERR(encoder)) {
>>> DRM_DEV_ERROR(dev->dev, "failed to construct LCDC encoder\n");
>>> + of_node_put(panel_node);
>>> return PTR_ERR(encoder);
>>> }
>>> @@ -225,6 +226,7 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
>>> connector = mdp4_lvds_connector_init(dev, panel_node, encoder);
>>> if (IS_ERR(connector)) {
>>> DRM_DEV_ERROR(dev->dev, "failed to initialize LVDS connector\n");
>>> + of_node_put(panel_node);
>>> return PTR_ERR(connector);
>>> }
>>>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf
2022-06-14 10:09 ` Dmitry Baryshkov
@ 2022-06-14 16:31 ` Abhinav Kumar
0 siblings, 0 replies; 7+ messages in thread
From: Abhinav Kumar @ 2022-06-14 16:31 UTC (permalink / raw)
To: Dmitry Baryshkov, Miaoqian Lin, Rob Clark, Sean Paul,
David Airlie, Daniel Vetter, Stephen Boyd, David Heidelberg,
Guo Zhengkui, Xu Wang, Neil Armstrong, Rob Herring,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On 6/14/2022 3:09 AM, Dmitry Baryshkov wrote:
> On 14/06/2022 13:07, Miaoqian Lin wrote:
>> Hi, Abhinav
>>
>> On 2022/6/11 7:20, Abhinav Kumar wrote:
>>>
>>>
>>> On 6/7/2022 4:08 AM, Miaoqian Lin wrote:
>>>> of_graph_get_remote_node() returns remote device node pointer with
>>>> refcount incremented, we should use of_node_put() on it
>>>> when not need anymore.
>>>> Add missing of_node_put() to avoid refcount leak.
>>>>
>>>> Fixes: 86418f90a4c1 ("drm: convert drivers to use
>>>> of_graph_get_remote_node")
>>>> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>>>> ---
>>>> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>
>>> This patch itself looks fine and will cover the cases when there was
>>> an error and we did not release the refcount.
>>>
>>> But, even in the normal cases I am not finding where we are releasing
>>> the refcount for the panel_node.
>>>
>>> I dont see a of_node_put() on mdp4_lcdc_encoder->panel_node.
>>>
>> Thanks for your review.
>>
>> I don't see it either. It's a bit messy because the reference assigned
>> to mdp4_lcdc_encoder->panel_node and mdp4_lvds_connector->panel_node
>> both.
>
> I have a plan to rework mdp4 lcdc support once I get my ifc6410 lvds
> cable. Thus I think we can land this patch now and fix the mdp4
> lcdc/lvds code leaking the reference in the due time.
>
Alright, with that assurance,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Will pick it up for -fixes.
>>
>>> Am i missing something?
>>>
>>>> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>>> b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>>> index fb48c8c19ec3..17cb1fc78379 100644
>>>> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>>> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>>> @@ -216,6 +216,7 @@ static int mdp4_modeset_init_intf(struct
>>>> mdp4_kms *mdp4_kms,
>>>> encoder = mdp4_lcdc_encoder_init(dev, panel_node);
>>>> if (IS_ERR(encoder)) {
>>>> DRM_DEV_ERROR(dev->dev, "failed to construct LCDC
>>>> encoder\n");
>>>> + of_node_put(panel_node);
>>>> return PTR_ERR(encoder);
>>>> }
>>>> @@ -225,6 +226,7 @@ static int mdp4_modeset_init_intf(struct
>>>> mdp4_kms *mdp4_kms,
>>>> connector = mdp4_lvds_connector_init(dev, panel_node,
>>>> encoder);
>>>> if (IS_ERR(connector)) {
>>>> DRM_DEV_ERROR(dev->dev, "failed to initialize LVDS
>>>> connector\n");
>>>> + of_node_put(panel_node);
>>>> return PTR_ERR(connector);
>>>> }
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-06-14 16:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-07 11:08 [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf Miaoqian Lin
2022-06-07 15:39 ` Dmitry Baryshkov
2022-06-08 22:14 ` Stephen Boyd
2022-06-10 23:20 ` Abhinav Kumar
2022-06-14 10:07 ` Miaoqian Lin
2022-06-14 10:09 ` Dmitry Baryshkov
2022-06-14 16:31 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).