From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Taniya Das <tdas@codeaurora.org>,
Jonathan Marek <jonathan@marek.ca>,
Michael Turquette <mturquette@baylibre.com>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
Mark Brown <broonie@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 7/8] clk: qcom: dispcc-sm8250: stop using mmcx regulator
Date: Fri, 15 Oct 2021 03:15:39 +0300 [thread overview]
Message-ID: <CAA8EJpo4SCSPMVstxO_eTGHVNCEkhguJDcfE4=6Y3YSDQ+SeOw@mail.gmail.com> (raw)
In-Reply-To: <163425629248.1688384.14367506222343416862@swboyd.mtv.corp.google.com>
On Fri, 15 Oct 2021 at 03:04, Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Dmitry Baryshkov (2021-10-14 02:53:41)
> > On 13/10/2021 22:50, Stephen Boyd wrote:
> > > Quoting Dmitry Baryshkov (2021-10-07 09:16:13)
> > >> On 07/10/2021 18:48, Bjorn Andersson wrote:
> > >>> On Sun 29 Aug 08:47 PDT 2021, Dmitry Baryshkov wrote:
> > >>>
> > >>>> Now as the common qcom clock controller code has been taught about power
> > >>>> domains, stop mentioning mmcx supply as a way to power up the clock
> > >>>> controller's gdsc.
> > >>>>
> > >>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > >>>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > >>>
> > >>> Once we merge these, I expect that the boards will start crashing if
> > >>> the kernel is booted using an existing DTB?
> > >>>
> > >>> Is it okay to just merge the first 6 patches in the series now and
> > >>> postpone these two until we've had the dts change sitting for a while?
> > >>
> > >> Sure it is.
> > >>
> > >
> > > What's the merge strategy? It goes through arm-soc?
> >
> > I think this should go through the clk tree. There is little chance of
> > conflicts.
> >
>
> The other thing that concerns me is that we don't have backwards
> compat code. If things are going to start crashing that's not very nice.
> Is there some way to make it work with old and new DTB for one release
> so that we don't have to worry about this problem?
I have to admit that I did not check that, but without the patch 7 the
dispcc and videocc would be compatible with the old DTB. The 'supply =
"mmcx"' would ensure that it is used if it is defined.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2021-10-15 0:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 15:47 [PATCH v7 0/6] clk: qcom: use power-domain for sm8250's clock controllers Dmitry Baryshkov
2021-08-29 15:47 ` [PATCH v7 1/8] dt-bindings: clock: qcom,dispcc-sm8x50: add mmcx power domain Dmitry Baryshkov
2021-10-15 0:55 ` Stephen Boyd
2021-08-29 15:47 ` [PATCH v7 2/8] dt-bindings: clock: qcom,videocc: " Dmitry Baryshkov
2021-10-15 0:56 ` Stephen Boyd
2021-08-29 15:47 ` [PATCH v7 3/8] clk: qcom: dispcc-sm8250: use runtime PM for the clock controller Dmitry Baryshkov
2021-10-07 15:09 ` Bjorn Andersson
2021-10-15 0:56 ` Stephen Boyd
2021-08-29 15:47 ` [PATCH v7 4/8] clk: qcom: videocc-sm8250: " Dmitry Baryshkov
2021-10-07 15:10 ` Bjorn Andersson
2021-10-15 0:56 ` Stephen Boyd
2021-08-29 15:47 ` [PATCH v7 5/8] clk: qcom: gdsc: enable optional power domain support Dmitry Baryshkov
2021-10-07 15:11 ` Bjorn Andersson
2021-10-15 0:56 ` Stephen Boyd
2021-08-29 15:47 ` [PATCH v7 6/8] arm64: dts: qcom: sm8250: remove mmcx regulator Dmitry Baryshkov
2021-08-29 15:47 ` [PATCH v7 7/8] clk: qcom: dispcc-sm8250: stop using " Dmitry Baryshkov
2021-10-07 15:48 ` Bjorn Andersson
2021-10-07 16:16 ` Dmitry Baryshkov
2021-10-13 19:50 ` Stephen Boyd
2021-10-14 9:53 ` Dmitry Baryshkov
2021-10-15 0:01 ` Stephen Boyd
2021-10-15 0:04 ` Stephen Boyd
2021-10-15 0:15 ` Dmitry Baryshkov [this message]
[not found] ` <163425751841.1688384.11770181770221059842@swboyd.mtv.corp.google.com>
2021-10-15 0:46 ` Bjorn Andersson
2021-10-15 0:49 ` Stephen Boyd
2022-01-31 16:15 ` Dmitry Baryshkov
2021-08-29 15:47 ` [PATCH v7 8/8] clk: qcom: videocc-sm8250: " Dmitry Baryshkov
2021-09-07 14:23 ` [PATCH v7 0/6] clk: qcom: use power-domain for sm8250's clock controllers Ulf Hansson
2021-10-06 11:42 ` Dmitry Baryshkov
2021-10-17 15:31 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8EJpo4SCSPMVstxO_eTGHVNCEkhguJDcfE4=6Y3YSDQ+SeOw@mail.gmail.com' \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).