From: Phillip Potter <phil@philpotter.co.uk>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Dan Carpenter <dan.carpenter@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-staging@lists.linux.dev,
Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver
Date: Wed, 28 Jul 2021 17:00:18 +0100 [thread overview]
Message-ID: <CAA=Fs0mH9YAVhr24YeE3jpZrnuDGhOuhj=Sb9Ekkpb-xoC5LYg@mail.gmail.com> (raw)
In-Reply-To: <20210728074605.pp5rs4c65tofnqot@viti.kaiser.cx>
On Wed, 28 Jul 2021 at 08:46, Martin Kaiser <martin@kaiser.cx> wrote:
>
> Hi Philipp and all,
>
> Thus wrote Phillip Potter (phil@philpotter.co.uk):
>
> > The driver currently in staging is older and less functional than the
> > version on Larry Finger's GitHub account, based upon v4.1.4_6773.20130222.
> > This series of patches therefore:
>
> [...]
>
> > V4: don't remove old driver now, just mark as deprecated and modify to
> > allow building alongside the new driver.
>
> Basically, you're suggesting to put aside all the fixes and cleanup
> that was done since the rtl8188eu driver was imported into the kernel
> tree. The TODO file says
>
> - merge Realtek's bugfixes and new features into the driver
>
> Why aren't we going down this route?
>
> Edimax offer a realtek driver linux_v5.7.6.1_36803.20200602 for
> rtl8188eu as a .zip file for download on their website
>
> https://www.edimax.com/edimax/mw/cufiles/files/download/Driver_Utility/EW-7811Un_V2/EW-7811Un_V2_Linux_Driver_1.0.1.2.zip
>
> If we integrate and fix the v4.1.4_6773.20130222 driver, are we running
> the risk that someone else will come along and propose another replacement?
>
> Thanks,
> Martin
Dear Martin,
I see what you are saying for sure - I think we've both sunk a fair
few patches into the existing driver :-)
That said, from what Larry has mentioned, this newer driver would
still be a better bet overall due to the additional work that has
already happened on it out-of-tree. The Realtek driver you reference
probably has no CFG80211 support etc. would be my guess, but I am
going off what others have suggested in terms of proposing this
patchset. I can't honestly say what the risk of this happening again
would be, but minimal I'd imagine.
Regards,
Phil
next prev parent reply other threads:[~2021-07-28 16:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 23:22 [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver Phillip Potter
2021-07-27 23:22 ` [PATCH v4 1/6] staging: r8188eu: introduce new core dir for " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 2/6] staging: r8188eu: introduce new hal " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 3/6] staging: r8188eu: introduce new os_dep " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 4/6] staging: r8188eu: introduce new include " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 5/6] staging: r8188eu: introduce new supporting files " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 6/6] staging: r8188eu: attach newly imported driver to build system Phillip Potter
2021-07-28 7:46 ` [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver Martin Kaiser
2021-07-28 16:00 ` Phillip Potter [this message]
2021-07-29 13:37 ` Martin Kaiser
2021-07-29 14:00 ` Greg KH
2021-07-29 16:47 ` Larry Finger
2021-08-01 17:50 ` Martin Kaiser
2021-07-28 18:14 ` Greg KH
2021-07-28 18:41 ` Larry Finger
2021-07-28 18:55 ` Greg KH
2021-07-28 22:17 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA=Fs0mH9YAVhr24YeE3jpZrnuDGhOuhj=Sb9Ekkpb-xoC5LYg@mail.gmail.com' \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).