linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Phillip Potter <phil@philpotter.co.uk>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-staging@lists.linux.dev,
	Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver
Date: Thu, 29 Jul 2021 16:00:04 +0200	[thread overview]
Message-ID: <YQK0ZMY34AFYtzN4@kroah.com> (raw)
In-Reply-To: <20210729133730.lnxqzawnvksp4skg@viti.kaiser.cx>

On Thu, Jul 29, 2021 at 03:37:30PM +0200, Martin Kaiser wrote:
> Hi Phil and all,
> 
> Thus wrote Phillip Potter (phil@philpotter.co.uk):
> 
> > I see what you are saying for sure - I think we've both sunk a fair
> > few patches into the existing driver :-)
> 
> > That said, from what Larry has mentioned, this newer driver would
> > still be a better bet overall due to the additional work that has
> > already happened on it out-of-tree. The Realtek driver you reference
> > probably has no CFG80211 support etc. would be my guess, but I am
> > going off what others have suggested in terms of proposing this
> > patchset. I can't honestly say what the risk of this happening again
> > would be, but minimal I'd imagine.
> 
> ok, understood. That's an important feature. I see that Greg accepted
> your patches, there's no point in arguing any more ;-)
> 
> Greg and Larry: Would you mind sharing your ideas about getting
> rtl8188eu support mainline? Do you imagine that we clean up this driver
> until it can be moved out of staging?

Yes, it's that "simple" :)

> If so, we'd probably have to resolve name conflicts with other realtek
> drivers and rename lots of functions.

Odds are that will happen as the code is cleaned up, right?

> Or would a cleanup of the new rtl8188eu driver be a preparation for
> adding bits and pieces of it to rtlwifi?

Do you think it will fit into that framework?

thanks,

greg k-h

  reply	other threads:[~2021-07-29 14:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 23:22 [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver Phillip Potter
2021-07-27 23:22 ` [PATCH v4 1/6] staging: r8188eu: introduce new core dir for " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 2/6] staging: r8188eu: introduce new hal " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 3/6] staging: r8188eu: introduce new os_dep " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 4/6] staging: r8188eu: introduce new include " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 5/6] staging: r8188eu: introduce new supporting files " Phillip Potter
2021-07-27 23:22 ` [PATCH v4 6/6] staging: r8188eu: attach newly imported driver to build system Phillip Potter
2021-07-28  7:46 ` [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver Martin Kaiser
2021-07-28 16:00   ` Phillip Potter
2021-07-29 13:37     ` Martin Kaiser
2021-07-29 14:00       ` Greg KH [this message]
2021-07-29 16:47       ` Larry Finger
2021-08-01 17:50         ` Martin Kaiser
2021-07-28 18:14 ` Greg KH
2021-07-28 18:41   ` Larry Finger
2021-07-28 18:55     ` Greg KH
2021-07-28 22:17       ` Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQK0ZMY34AFYtzN4@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).