* [PATCH] riscv: cacheinfo: fix typo of homogenous
@ 2021-10-08 20:56 hasheddan
2021-10-23 20:30 ` Palmer Dabbelt
0 siblings, 1 reply; 4+ messages in thread
From: hasheddan @ 2021-10-08 20:56 UTC (permalink / raw)
Cc: georgedanielmangum, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Atish Patra, Peter Zijlstra, Kefeng Wang, Will Deacon,
Thomas Gleixner, linux-riscv, linux-kernel
Updates 'homonogenous' to 'homogenous' in comment.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
---
arch/riscv/kernel/cacheinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c
index 90deabfe63ea..ff98546b1152 100644
--- a/arch/riscv/kernel/cacheinfo.c
+++ b/arch/riscv/kernel/cacheinfo.c
@@ -29,7 +29,7 @@ static struct cacheinfo *get_cacheinfo(u32 level, enum cache_type type)
/*
* Using raw_smp_processor_id() elides a preemptability check, but this
* is really indicative of a larger problem: the cacheinfo UABI assumes
- * that cores have a homonogenous view of the cache hierarchy. That
+ * that cores have a homogenous view of the cache hierarchy. That
* happens to be the case for the current set of RISC-V systems, but
* likely won't be true in general. Since there's no way to provide
* correct information for these systems via the current UABI we're
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: cacheinfo: fix typo of homogenous
2021-10-08 20:56 [PATCH] riscv: cacheinfo: fix typo of homogenous hasheddan
@ 2021-10-23 20:30 ` Palmer Dabbelt
2021-10-23 20:36 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Palmer Dabbelt @ 2021-10-23 20:30 UTC (permalink / raw)
To: georgedanielmangum
Cc: georgedanielmangum, Paul Walmsley, aou, Atish Patra, peterz,
wangkefeng.wang, will, tglx, linux-riscv, linux-kernel
On Fri, 08 Oct 2021 13:56:25 PDT (-0700), georgedanielmangum@gmail.com wrote:
> Updates 'homonogenous' to 'homogenous' in comment.
I don't really know spelling that well, but checkpatch says
WARNING: 'homogenous' may be misspelled - perhaps 'homogeneous'?
when applying this. It looks like they're both words, but "homogeneous"
is the right one?
>
> Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
> ---
> arch/riscv/kernel/cacheinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c
> index 90deabfe63ea..ff98546b1152 100644
> --- a/arch/riscv/kernel/cacheinfo.c
> +++ b/arch/riscv/kernel/cacheinfo.c
> @@ -29,7 +29,7 @@ static struct cacheinfo *get_cacheinfo(u32 level, enum cache_type type)
> /*
> * Using raw_smp_processor_id() elides a preemptability check, but this
> * is really indicative of a larger problem: the cacheinfo UABI assumes
> - * that cores have a homonogenous view of the cache hierarchy. That
> + * that cores have a homogenous view of the cache hierarchy. That
> * happens to be the case for the current set of RISC-V systems, but
> * likely won't be true in general. Since there's no way to provide
> * correct information for these systems via the current UABI we're
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: cacheinfo: fix typo of homogenous
2021-10-23 20:30 ` Palmer Dabbelt
@ 2021-10-23 20:36 ` Randy Dunlap
2021-10-25 1:12 ` Daniel Mangum
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-10-23 20:36 UTC (permalink / raw)
To: Palmer Dabbelt, georgedanielmangum
Cc: Paul Walmsley, aou, Atish Patra, peterz, wangkefeng.wang, will,
tglx, linux-riscv, linux-kernel
On 10/23/21 1:30 PM, Palmer Dabbelt wrote:
> On Fri, 08 Oct 2021 13:56:25 PDT (-0700), georgedanielmangum@gmail.com wrote:
>> Updates 'homonogenous' to 'homogenous' in comment.
>
> I don't really know spelling that well, but checkpatch says
>
> WARNING: 'homogenous' may be misspelled - perhaps 'homogeneous'?
>
> when applying this. It looks like they're both words, but "homogeneous" is the right one?
>
Internet search to grammar.com says:
To summarise, Earlier, homogenous was used as a scientific term, mainly in biology, but now it is almost obsolete, being replaced by homologous. Whereas, homogeneous is a common word, very much in use and means having similar or comparable characteristics.
Several web sites agree that homogeneous is currently preferable.
>>
>> Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
>> ---
>> arch/riscv/kernel/cacheinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c
>> index 90deabfe63ea..ff98546b1152 100644
>> --- a/arch/riscv/kernel/cacheinfo.c
>> +++ b/arch/riscv/kernel/cacheinfo.c
>> @@ -29,7 +29,7 @@ static struct cacheinfo *get_cacheinfo(u32 level, enum cache_type type)
>> /*
>> * Using raw_smp_processor_id() elides a preemptability check, but this
>> * is really indicative of a larger problem: the cacheinfo UABI assumes
>> - * that cores have a homonogenous view of the cache hierarchy. That
>> + * that cores have a homogenous view of the cache hierarchy. That
>> * happens to be the case for the current set of RISC-V systems, but
>> * likely won't be true in general. Since there's no way to provide
>> * correct information for these systems via the current UABI we're
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: cacheinfo: fix typo of homogenous
2021-10-23 20:36 ` Randy Dunlap
@ 2021-10-25 1:12 ` Daniel Mangum
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Mangum @ 2021-10-25 1:12 UTC (permalink / raw)
To: Randy Dunlap
Cc: Palmer Dabbelt, Paul Walmsley, Albert Ou, Atish Patra,
Peter Zijlstra, Kefeng Wang, Will Deacon, Thomas Gleixner,
linux-riscv, linux-kernel
Thanks for the feedback folks! I have sent a v2 patch.
Dan
On Sat, Oct 23, 2021 at 4:36 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 10/23/21 1:30 PM, Palmer Dabbelt wrote:
> > On Fri, 08 Oct 2021 13:56:25 PDT (-0700), georgedanielmangum@gmail.com wrote:
> >> Updates 'homonogenous' to 'homogenous' in comment.
> >
> > I don't really know spelling that well, but checkpatch says
> >
> > WARNING: 'homogenous' may be misspelled - perhaps 'homogeneous'?
> >
> > when applying this. It looks like they're both words, but "homogeneous" is the right one?
> >
>
> Internet search to grammar.com says:
>
> To summarise, Earlier, homogenous was used as a scientific term, mainly in biology, but now it is almost obsolete, being replaced by homologous. Whereas, homogeneous is a common word, very much in use and means having similar or comparable characteristics.
>
> Several web sites agree that homogeneous is currently preferable.
>
> >>
> >> Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
> >> ---
> >> arch/riscv/kernel/cacheinfo.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c
> >> index 90deabfe63ea..ff98546b1152 100644
> >> --- a/arch/riscv/kernel/cacheinfo.c
> >> +++ b/arch/riscv/kernel/cacheinfo.c
> >> @@ -29,7 +29,7 @@ static struct cacheinfo *get_cacheinfo(u32 level, enum cache_type type)
> >> /*
> >> * Using raw_smp_processor_id() elides a preemptability check, but this
> >> * is really indicative of a larger problem: the cacheinfo UABI assumes
> >> - * that cores have a homonogenous view of the cache hierarchy. That
> >> + * that cores have a homogenous view of the cache hierarchy. That
> >> * happens to be the case for the current set of RISC-V systems, but
> >> * likely won't be true in general. Since there's no way to provide
> >> * correct information for these systems via the current UABI we're
>
>
> --
> ~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-25 1:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-08 20:56 [PATCH] riscv: cacheinfo: fix typo of homogenous hasheddan
2021-10-23 20:30 ` Palmer Dabbelt
2021-10-23 20:36 ` Randy Dunlap
2021-10-25 1:12 ` Daniel Mangum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).