* [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE @ 2018-10-04 13:37 Maxime Jourdan 2018-10-09 7:58 ` Tomasz Figa 2018-11-29 9:01 ` Hans Verkuil 0 siblings, 2 replies; 7+ messages in thread From: Maxime Jourdan @ 2018-10-04 13:37 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: Maxime Jourdan, Tomasz Figa, Hans Verkuil, linux-media, linux-kernel When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually OUTPUT) formats may not be able to trigger this event. Add a enum_fmt format flag to tag those specific formats. Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com> --- Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 5 +++++ include/uapi/linux/videodev2.h | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst index 019c513df217..e0040b36ac43 100644 --- a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst +++ b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst @@ -116,6 +116,11 @@ one until ``EINVAL`` is returned. - This format is not native to the device but emulated through software (usually libv4l2), where possible try to use a native format instead for better performance. + * - ``V4L2_FMT_FLAG_NO_SOURCE_CHANGE`` + - 0x0004 + - The event ``V4L2_EVENT_SOURCE_CHANGE`` is not supported + for this format. + Return Value diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 3a65951ca51e..a28acee1cb52 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -723,8 +723,9 @@ struct v4l2_fmtdesc { __u32 reserved[4]; }; -#define V4L2_FMT_FLAG_COMPRESSED 0x0001 -#define V4L2_FMT_FLAG_EMULATED 0x0002 +#define V4L2_FMT_FLAG_COMPRESSED 0x0001 +#define V4L2_FMT_FLAG_EMULATED 0x0002 +#define V4L2_FMT_FLAG_NO_SOURCE_CHANGE 0x0004 /* Frame Size and frame rate enumeration */ /* -- 2.19.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE 2018-10-04 13:37 [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE Maxime Jourdan @ 2018-10-09 7:58 ` Tomasz Figa 2018-10-09 11:04 ` Maxime Jourdan 2018-11-29 9:01 ` Hans Verkuil 1 sibling, 1 reply; 7+ messages in thread From: Tomasz Figa @ 2018-10-09 7:58 UTC (permalink / raw) To: mjourdan Cc: Mauro Carvalho Chehab, Hans Verkuil, Linux Media Mailing List, Linux Kernel Mailing List Hi Maxime, On Thu, Oct 4, 2018 at 10:38 PM Maxime Jourdan <mjourdan@baylibre.com> wrote: > > When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually > OUTPUT) formats may not be able to trigger this event. > > Add a enum_fmt format flag to tag those specific formats. > > Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com> > --- > Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 5 +++++ > include/uapi/linux/videodev2.h | 5 +++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > index 019c513df217..e0040b36ac43 100644 > --- a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > +++ b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > @@ -116,6 +116,11 @@ one until ``EINVAL`` is returned. > - This format is not native to the device but emulated through > software (usually libv4l2), where possible try to use a native > format instead for better performance. > + * - ``V4L2_FMT_FLAG_NO_SOURCE_CHANGE`` > + - 0x0004 > + - The event ``V4L2_EVENT_SOURCE_CHANGE`` is not supported > + for this format. > + > > > Return Value > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 3a65951ca51e..a28acee1cb52 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -723,8 +723,9 @@ struct v4l2_fmtdesc { > __u32 reserved[4]; > }; > > -#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > -#define V4L2_FMT_FLAG_EMULATED 0x0002 > +#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > +#define V4L2_FMT_FLAG_EMULATED 0x0002 > +#define V4L2_FMT_FLAG_NO_SOURCE_CHANGE 0x0004 I think it indeed makes sense. I'd suggest submitting this patch together with the series that adds the affected driver, though, since we'd be otherwise just adding a dead API. Also, it would be good to refer to it from the Decoder Interface documentation. Depending on which one gets in earlier, you might either want to base on it or I'd add a note myself. Best regards, Tomasz ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE 2018-10-09 7:58 ` Tomasz Figa @ 2018-10-09 11:04 ` Maxime Jourdan 0 siblings, 0 replies; 7+ messages in thread From: Maxime Jourdan @ 2018-10-09 11:04 UTC (permalink / raw) To: Tomasz Figa Cc: Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel Hi Tomasz, On Tue, Oct 9, 2018 at 9:59 AM Tomasz Figa <tfiga@chromium.org> wrote: > > Hi Maxime, > > On Thu, Oct 4, 2018 at 10:38 PM Maxime Jourdan <mjourdan@baylibre.com> wrote: > > > > When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually > > OUTPUT) formats may not be able to trigger this event. > > > > Add a enum_fmt format flag to tag those specific formats. > > > > Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com> > > --- > > Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 5 +++++ > > include/uapi/linux/videodev2.h | 5 +++-- > > 2 files changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > > index 019c513df217..e0040b36ac43 100644 > > --- a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > > +++ b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > > @@ -116,6 +116,11 @@ one until ``EINVAL`` is returned. > > - This format is not native to the device but emulated through > > software (usually libv4l2), where possible try to use a native > > format instead for better performance. > > + * - ``V4L2_FMT_FLAG_NO_SOURCE_CHANGE`` > > + - 0x0004 > > + - The event ``V4L2_EVENT_SOURCE_CHANGE`` is not supported > > + for this format. > > + > > > > > > Return Value > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > index 3a65951ca51e..a28acee1cb52 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -723,8 +723,9 @@ struct v4l2_fmtdesc { > > __u32 reserved[4]; > > }; > > > > -#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > > -#define V4L2_FMT_FLAG_EMULATED 0x0002 > > +#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > > +#define V4L2_FMT_FLAG_EMULATED 0x0002 > > +#define V4L2_FMT_FLAG_NO_SOURCE_CHANGE 0x0004 > > I think it indeed makes sense. I'd suggest submitting this patch > together with the series that adds the affected driver, though, since > we'd be otherwise just adding a dead API. > > Also, it would be good to refer to it from the Decoder Interface > documentation. Depending on which one gets in earlier, you might > either want to base on it or I'd add a note myself. > > Best regards, > Tomasz Agreed on both points. If your documentation makes it in before, I'll update it within the patch. We'll have time to sync on that anyway in the coming weeks. Maxime ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE 2018-10-04 13:37 [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE Maxime Jourdan 2018-10-09 7:58 ` Tomasz Figa @ 2018-11-29 9:01 ` Hans Verkuil 2018-11-29 19:35 ` Tomasz Figa 1 sibling, 1 reply; 7+ messages in thread From: Hans Verkuil @ 2018-11-29 9:01 UTC (permalink / raw) To: Maxime Jourdan, Mauro Carvalho Chehab Cc: Tomasz Figa, Hans Verkuil, linux-media, linux-kernel On 10/04/2018 03:37 PM, Maxime Jourdan wrote: > When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually > OUTPUT) formats may not be able to trigger this event. > > Add a enum_fmt format flag to tag those specific formats. I think I missed (or forgot) some discussion about this since I have no idea why this flag is needed. What's the use-case? Regards, Hans > > Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com> > --- > Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 5 +++++ > include/uapi/linux/videodev2.h | 5 +++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > index 019c513df217..e0040b36ac43 100644 > --- a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > +++ b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > @@ -116,6 +116,11 @@ one until ``EINVAL`` is returned. > - This format is not native to the device but emulated through > software (usually libv4l2), where possible try to use a native > format instead for better performance. > + * - ``V4L2_FMT_FLAG_NO_SOURCE_CHANGE`` > + - 0x0004 > + - The event ``V4L2_EVENT_SOURCE_CHANGE`` is not supported > + for this format. > + > > > Return Value > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 3a65951ca51e..a28acee1cb52 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -723,8 +723,9 @@ struct v4l2_fmtdesc { > __u32 reserved[4]; > }; > > -#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > -#define V4L2_FMT_FLAG_EMULATED 0x0002 > +#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > +#define V4L2_FMT_FLAG_EMULATED 0x0002 > +#define V4L2_FMT_FLAG_NO_SOURCE_CHANGE 0x0004 > > /* Frame Size and frame rate enumeration */ > /* > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE 2018-11-29 9:01 ` Hans Verkuil @ 2018-11-29 19:35 ` Tomasz Figa 2018-11-30 7:35 ` Hans Verkuil 0 siblings, 1 reply; 7+ messages in thread From: Tomasz Figa @ 2018-11-29 19:35 UTC (permalink / raw) To: Hans Verkuil Cc: mjourdan, Mauro Carvalho Chehab, Hans Verkuil, Linux Media Mailing List, Linux Kernel Mailing List On Thu, Nov 29, 2018 at 1:01 AM Hans Verkuil <hverkuil@xs4all.nl> wrote: > > On 10/04/2018 03:37 PM, Maxime Jourdan wrote: > > When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually > > OUTPUT) formats may not be able to trigger this event. > > > > Add a enum_fmt format flag to tag those specific formats. > > I think I missed (or forgot) some discussion about this since I have no > idea why this flag is needed. What's the use-case? As far as I remember, the hardware/firmware Maxime has been working with can't handle resolution changes for some coded formats. Perhaps we should explain that better in the commit message and documentation of the flag, though. Maxime, could you refresh my memory with the details? Best regards, Tomasz > > Regards, > > Hans > > > > > Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com> > > --- > > Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 5 +++++ > > include/uapi/linux/videodev2.h | 5 +++-- > > 2 files changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > > index 019c513df217..e0040b36ac43 100644 > > --- a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > > +++ b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > > @@ -116,6 +116,11 @@ one until ``EINVAL`` is returned. > > - This format is not native to the device but emulated through > > software (usually libv4l2), where possible try to use a native > > format instead for better performance. > > + * - ``V4L2_FMT_FLAG_NO_SOURCE_CHANGE`` > > + - 0x0004 > > + - The event ``V4L2_EVENT_SOURCE_CHANGE`` is not supported > > + for this format. > > + > > > > > > Return Value > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > index 3a65951ca51e..a28acee1cb52 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -723,8 +723,9 @@ struct v4l2_fmtdesc { > > __u32 reserved[4]; > > }; > > > > -#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > > -#define V4L2_FMT_FLAG_EMULATED 0x0002 > > +#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > > +#define V4L2_FMT_FLAG_EMULATED 0x0002 > > +#define V4L2_FMT_FLAG_NO_SOURCE_CHANGE 0x0004 > > > > /* Frame Size and frame rate enumeration */ > > /* > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE 2018-11-29 19:35 ` Tomasz Figa @ 2018-11-30 7:35 ` Hans Verkuil 2018-12-07 16:12 ` Maxime Jourdan 0 siblings, 1 reply; 7+ messages in thread From: Hans Verkuil @ 2018-11-30 7:35 UTC (permalink / raw) To: Tomasz Figa Cc: mjourdan, Mauro Carvalho Chehab, Hans Verkuil, Linux Media Mailing List, Linux Kernel Mailing List On 11/29/2018 08:35 PM, Tomasz Figa wrote: > On Thu, Nov 29, 2018 at 1:01 AM Hans Verkuil <hverkuil@xs4all.nl> wrote: >> >> On 10/04/2018 03:37 PM, Maxime Jourdan wrote: >>> When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually >>> OUTPUT) formats may not be able to trigger this event. >>> >>> Add a enum_fmt format flag to tag those specific formats. >> >> I think I missed (or forgot) some discussion about this since I have no >> idea why this flag is needed. What's the use-case? > > As far as I remember, the hardware/firmware Maxime has been working > with can't handle resolution changes for some coded formats. Perhaps > we should explain that better in the commit message and documentation > of the flag, though. Maxime, could you refresh my memory with the > details? So basically it describes if a compressed format can handle resolution changes for the given hardware? If that's the case, then NO_SOURCE_CHANGE is not a good name as it describes the symptom, not the real reason. Perhaps _FIXED_RESOLUTION might be a better name. Regards, Hans > > Best regards, > Tomasz > >> >> Regards, >> >> Hans >> >>> >>> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com> >>> --- >>> Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 5 +++++ >>> include/uapi/linux/videodev2.h | 5 +++-- >>> 2 files changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst >>> index 019c513df217..e0040b36ac43 100644 >>> --- a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst >>> +++ b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst >>> @@ -116,6 +116,11 @@ one until ``EINVAL`` is returned. >>> - This format is not native to the device but emulated through >>> software (usually libv4l2), where possible try to use a native >>> format instead for better performance. >>> + * - ``V4L2_FMT_FLAG_NO_SOURCE_CHANGE`` >>> + - 0x0004 >>> + - The event ``V4L2_EVENT_SOURCE_CHANGE`` is not supported >>> + for this format. >>> + >>> >>> >>> Return Value >>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h >>> index 3a65951ca51e..a28acee1cb52 100644 >>> --- a/include/uapi/linux/videodev2.h >>> +++ b/include/uapi/linux/videodev2.h >>> @@ -723,8 +723,9 @@ struct v4l2_fmtdesc { >>> __u32 reserved[4]; >>> }; >>> >>> -#define V4L2_FMT_FLAG_COMPRESSED 0x0001 >>> -#define V4L2_FMT_FLAG_EMULATED 0x0002 >>> +#define V4L2_FMT_FLAG_COMPRESSED 0x0001 >>> +#define V4L2_FMT_FLAG_EMULATED 0x0002 >>> +#define V4L2_FMT_FLAG_NO_SOURCE_CHANGE 0x0004 >>> >>> /* Frame Size and frame rate enumeration */ >>> /* >>> >> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE 2018-11-30 7:35 ` Hans Verkuil @ 2018-12-07 16:12 ` Maxime Jourdan 0 siblings, 0 replies; 7+ messages in thread From: Maxime Jourdan @ 2018-12-07 16:12 UTC (permalink / raw) To: Hans Verkuil Cc: Tomasz Figa, Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel Hi Hans, Tomasz, Sorry I missed your messages last week..! On Fri, Nov 30, 2018 at 8:35 AM Hans Verkuil <hverkuil@xs4all.nl> wrote: > > On 11/29/2018 08:35 PM, Tomasz Figa wrote: > > On Thu, Nov 29, 2018 at 1:01 AM Hans Verkuil <hverkuil@xs4all.nl> wrote: > >> > >> On 10/04/2018 03:37 PM, Maxime Jourdan wrote: > >>> When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually > >>> OUTPUT) formats may not be able to trigger this event. > >>> > >>> Add a enum_fmt format flag to tag those specific formats. > >> > >> I think I missed (or forgot) some discussion about this since I have no > >> idea why this flag is needed. What's the use-case? > > > > As far as I remember, the hardware/firmware Maxime has been working > > with can't handle resolution changes for some coded formats. Perhaps > > we should explain that better in the commit message and documentation > > of the flag, though. Maxime, could you refresh my memory with the > > details? > > So basically it describes if a compressed format can handle resolution > changes for the given hardware? > Yes, exactly > If that's the case, then NO_SOURCE_CHANGE is not a good name as it > describes the symptom, not the real reason. > > Perhaps _FIXED_RESOLUTION might be a better name. > Fair point, I will update it as such. Next time, this patch will come in a series that uses the flag. Cheers, Maxime > Regards, > > Hans > > > > > Best regards, > > Tomasz > > > >> > >> Regards, > >> > >> Hans > >> > >>> > >>> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com> > >>> --- > >>> Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 5 +++++ > >>> include/uapi/linux/videodev2.h | 5 +++-- > >>> 2 files changed, 8 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > >>> index 019c513df217..e0040b36ac43 100644 > >>> --- a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > >>> +++ b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst > >>> @@ -116,6 +116,11 @@ one until ``EINVAL`` is returned. > >>> - This format is not native to the device but emulated through > >>> software (usually libv4l2), where possible try to use a native > >>> format instead for better performance. > >>> + * - ``V4L2_FMT_FLAG_NO_SOURCE_CHANGE`` > >>> + - 0x0004 > >>> + - The event ``V4L2_EVENT_SOURCE_CHANGE`` is not supported > >>> + for this format. > >>> + > >>> > >>> > >>> Return Value > >>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > >>> index 3a65951ca51e..a28acee1cb52 100644 > >>> --- a/include/uapi/linux/videodev2.h > >>> +++ b/include/uapi/linux/videodev2.h > >>> @@ -723,8 +723,9 @@ struct v4l2_fmtdesc { > >>> __u32 reserved[4]; > >>> }; > >>> > >>> -#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > >>> -#define V4L2_FMT_FLAG_EMULATED 0x0002 > >>> +#define V4L2_FMT_FLAG_COMPRESSED 0x0001 > >>> +#define V4L2_FMT_FLAG_EMULATED 0x0002 > >>> +#define V4L2_FMT_FLAG_NO_SOURCE_CHANGE 0x0004 > >>> > >>> /* Frame Size and frame rate enumeration */ > >>> /* > >>> > >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-12-07 16:12 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-10-04 13:37 [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE Maxime Jourdan 2018-10-09 7:58 ` Tomasz Figa 2018-10-09 11:04 ` Maxime Jourdan 2018-11-29 9:01 ` Hans Verkuil 2018-11-29 19:35 ` Tomasz Figa 2018-11-30 7:35 ` Hans Verkuil 2018-12-07 16:12 ` Maxime Jourdan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).