linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomas Krcka <tomas.krcka@nkgroup.cz>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: support for rv4162c7
Date: Thu, 14 Apr 2016 09:24:41 +0200	[thread overview]
Message-ID: <CAAJk-V1M-wRMOt0BYk+Nnrb805A8wwji0yyzT2OPfGoCWuruaw@mail.gmail.com> (raw)
In-Reply-To: <20160414071902.GK7765@piout.net>

Hi,
  ok, good. Thanks.
Patch is not needed.

2016-04-14 9:19 GMT+02:00 Alexandre Belloni
<alexandre.belloni@free-electrons.com>:
> Hi,
>
> On 14/04/2016 at 08:29:47 +0200, Tomas Krcka wrote :
>> Hi,
>>   that's correct, but idetification of this chip is rv4162c7 so
>> i2c_match_id() returns NULL.
>> If it's there any workaround, how the chip can be detected
>> automatically then OK, but without this patch it doesn't work for me.
>>
>
> Just use rv4162 as your compatible string. That is what the mainline dtsi
> is doing for the phycore som:
>
> $ grep -C 2 rv4162 arch/arm/boot/dts/am335x-phycore-som.dtsi
>
>         i2c_rtc: rtc@68 {
>                 compatible = "rv4162";
>                 reg = <0x68>;
>                 status = "disabled";
>
>
>> 2016-04-14 0:49 GMT+02:00 Alexandre Belloni
>> <alexandre.belloni@free-electrons.com>:
>> > Hi,
>> >
>> > On 13/04/2016 at 22:39:39 +0200, Tomas Krcka wrote :
>> >> This patch is for support of rv4162c7 RTC chip.
>> >> The device has same parameters as rv4162, but with different identification.
>> >> Tested with PhyTec module AM335x.
>> >>
>> >
>> > Well, technically, it is an rv4162. rv4162-c7 is the only available one.
>> > So this patch is not necessary.
>> >
>> >> Signed-off-by: Tomas Krcka <tomas.krcka@nkgroup.cz>
>> >>
>> >> ---
>> >>  drivers/rtc/rtc-m41t80.c | 1 +
>> >>  1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
>> >> index d107a8e..1aa57d8 100644
>> >> --- a/drivers/rtc/rtc-m41t80.c
>> >> +++ b/drivers/rtc/rtc-m41t80.c
>> >> @@ -81,6 +81,7 @@ static const struct i2c_device_id m41t80_id[] = {
>> >>      { "m41st85", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
>> >>      { "m41st87", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
>> >>      { "rv4162", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
>> >> +    { "rv4162c7", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
>> >>      { }
>> >>  };
>> >>  MODULE_DEVICE_TABLE(i2c, m41t80_id);
>> >> -- 1.9.1
>> >>
>> >
>> > --
>> > Alexandre Belloni, Free Electrons
>> > Embedded Linux, Kernel and Android engineering
>> > http://free-electrons.com
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

      reply	other threads:[~2016-04-14  7:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 20:39 [PATCH] rtc: support for rv4162c7 Tomas Krcka
2016-04-13 22:49 ` Alexandre Belloni
2016-04-14  6:29   ` Tomas Krcka
2016-04-14  7:19     ` Alexandre Belloni
2016-04-14  7:24       ` Tomas Krcka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAJk-V1M-wRMOt0BYk+Nnrb805A8wwji0yyzT2OPfGoCWuruaw@mail.gmail.com \
    --to=tomas.krcka@nkgroup.cz \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).