* [PATCH] rtc: support for rv4162c7
@ 2016-04-13 20:39 Tomas Krcka
2016-04-13 22:49 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Tomas Krcka @ 2016-04-13 20:39 UTC (permalink / raw)
To: rtc-linux; +Cc: a.zummo, alexandre.belloni, linux-kernel
This patch is for support of rv4162c7 RTC chip.
The device has same parameters as rv4162, but with different identification.
Tested with PhyTec module AM335x.
Signed-off-by: Tomas Krcka <tomas.krcka@nkgroup.cz>
---
drivers/rtc/rtc-m41t80.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index d107a8e..1aa57d8 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -81,6 +81,7 @@ static const struct i2c_device_id m41t80_id[] = {
{ "m41st85", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
{ "m41st87", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
{ "rv4162", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
+ { "rv4162c7", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
{ }
};
MODULE_DEVICE_TABLE(i2c, m41t80_id);
-- 1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] rtc: support for rv4162c7
2016-04-13 20:39 [PATCH] rtc: support for rv4162c7 Tomas Krcka
@ 2016-04-13 22:49 ` Alexandre Belloni
2016-04-14 6:29 ` Tomas Krcka
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2016-04-13 22:49 UTC (permalink / raw)
To: Tomas Krcka; +Cc: rtc-linux, a.zummo, linux-kernel
Hi,
On 13/04/2016 at 22:39:39 +0200, Tomas Krcka wrote :
> This patch is for support of rv4162c7 RTC chip.
> The device has same parameters as rv4162, but with different identification.
> Tested with PhyTec module AM335x.
>
Well, technically, it is an rv4162. rv4162-c7 is the only available one.
So this patch is not necessary.
> Signed-off-by: Tomas Krcka <tomas.krcka@nkgroup.cz>
>
> ---
> drivers/rtc/rtc-m41t80.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
> index d107a8e..1aa57d8 100644
> --- a/drivers/rtc/rtc-m41t80.c
> +++ b/drivers/rtc/rtc-m41t80.c
> @@ -81,6 +81,7 @@ static const struct i2c_device_id m41t80_id[] = {
> { "m41st85", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
> { "m41st87", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
> { "rv4162", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
> + { "rv4162c7", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, m41t80_id);
> -- 1.9.1
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtc: support for rv4162c7
2016-04-13 22:49 ` Alexandre Belloni
@ 2016-04-14 6:29 ` Tomas Krcka
2016-04-14 7:19 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Tomas Krcka @ 2016-04-14 6:29 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: rtc-linux, Alessandro Zummo, linux-kernel
Hi,
that's correct, but idetification of this chip is rv4162c7 so
i2c_match_id() returns NULL.
If it's there any workaround, how the chip can be detected
automatically then OK, but without this patch it doesn't work for me.
2016-04-14 0:49 GMT+02:00 Alexandre Belloni
<alexandre.belloni@free-electrons.com>:
> Hi,
>
> On 13/04/2016 at 22:39:39 +0200, Tomas Krcka wrote :
>> This patch is for support of rv4162c7 RTC chip.
>> The device has same parameters as rv4162, but with different identification.
>> Tested with PhyTec module AM335x.
>>
>
> Well, technically, it is an rv4162. rv4162-c7 is the only available one.
> So this patch is not necessary.
>
>> Signed-off-by: Tomas Krcka <tomas.krcka@nkgroup.cz>
>>
>> ---
>> drivers/rtc/rtc-m41t80.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
>> index d107a8e..1aa57d8 100644
>> --- a/drivers/rtc/rtc-m41t80.c
>> +++ b/drivers/rtc/rtc-m41t80.c
>> @@ -81,6 +81,7 @@ static const struct i2c_device_id m41t80_id[] = {
>> { "m41st85", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
>> { "m41st87", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
>> { "rv4162", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
>> + { "rv4162c7", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
>> { }
>> };
>> MODULE_DEVICE_TABLE(i2c, m41t80_id);
>> -- 1.9.1
>>
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtc: support for rv4162c7
2016-04-14 6:29 ` Tomas Krcka
@ 2016-04-14 7:19 ` Alexandre Belloni
2016-04-14 7:24 ` Tomas Krcka
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2016-04-14 7:19 UTC (permalink / raw)
To: Tomas Krcka; +Cc: rtc-linux, Alessandro Zummo, linux-kernel
Hi,
On 14/04/2016 at 08:29:47 +0200, Tomas Krcka wrote :
> Hi,
> that's correct, but idetification of this chip is rv4162c7 so
> i2c_match_id() returns NULL.
> If it's there any workaround, how the chip can be detected
> automatically then OK, but without this patch it doesn't work for me.
>
Just use rv4162 as your compatible string. That is what the mainline dtsi
is doing for the phycore som:
$ grep -C 2 rv4162 arch/arm/boot/dts/am335x-phycore-som.dtsi
i2c_rtc: rtc@68 {
compatible = "rv4162";
reg = <0x68>;
status = "disabled";
> 2016-04-14 0:49 GMT+02:00 Alexandre Belloni
> <alexandre.belloni@free-electrons.com>:
> > Hi,
> >
> > On 13/04/2016 at 22:39:39 +0200, Tomas Krcka wrote :
> >> This patch is for support of rv4162c7 RTC chip.
> >> The device has same parameters as rv4162, but with different identification.
> >> Tested with PhyTec module AM335x.
> >>
> >
> > Well, technically, it is an rv4162. rv4162-c7 is the only available one.
> > So this patch is not necessary.
> >
> >> Signed-off-by: Tomas Krcka <tomas.krcka@nkgroup.cz>
> >>
> >> ---
> >> drivers/rtc/rtc-m41t80.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
> >> index d107a8e..1aa57d8 100644
> >> --- a/drivers/rtc/rtc-m41t80.c
> >> +++ b/drivers/rtc/rtc-m41t80.c
> >> @@ -81,6 +81,7 @@ static const struct i2c_device_id m41t80_id[] = {
> >> { "m41st85", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
> >> { "m41st87", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
> >> { "rv4162", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
> >> + { "rv4162c7", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
> >> { }
> >> };
> >> MODULE_DEVICE_TABLE(i2c, m41t80_id);
> >> -- 1.9.1
> >>
> >
> > --
> > Alexandre Belloni, Free Electrons
> > Embedded Linux, Kernel and Android engineering
> > http://free-electrons.com
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtc: support for rv4162c7
2016-04-14 7:19 ` Alexandre Belloni
@ 2016-04-14 7:24 ` Tomas Krcka
0 siblings, 0 replies; 5+ messages in thread
From: Tomas Krcka @ 2016-04-14 7:24 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: rtc-linux, Alessandro Zummo, linux-kernel
Hi,
ok, good. Thanks.
Patch is not needed.
2016-04-14 9:19 GMT+02:00 Alexandre Belloni
<alexandre.belloni@free-electrons.com>:
> Hi,
>
> On 14/04/2016 at 08:29:47 +0200, Tomas Krcka wrote :
>> Hi,
>> that's correct, but idetification of this chip is rv4162c7 so
>> i2c_match_id() returns NULL.
>> If it's there any workaround, how the chip can be detected
>> automatically then OK, but without this patch it doesn't work for me.
>>
>
> Just use rv4162 as your compatible string. That is what the mainline dtsi
> is doing for the phycore som:
>
> $ grep -C 2 rv4162 arch/arm/boot/dts/am335x-phycore-som.dtsi
>
> i2c_rtc: rtc@68 {
> compatible = "rv4162";
> reg = <0x68>;
> status = "disabled";
>
>
>> 2016-04-14 0:49 GMT+02:00 Alexandre Belloni
>> <alexandre.belloni@free-electrons.com>:
>> > Hi,
>> >
>> > On 13/04/2016 at 22:39:39 +0200, Tomas Krcka wrote :
>> >> This patch is for support of rv4162c7 RTC chip.
>> >> The device has same parameters as rv4162, but with different identification.
>> >> Tested with PhyTec module AM335x.
>> >>
>> >
>> > Well, technically, it is an rv4162. rv4162-c7 is the only available one.
>> > So this patch is not necessary.
>> >
>> >> Signed-off-by: Tomas Krcka <tomas.krcka@nkgroup.cz>
>> >>
>> >> ---
>> >> drivers/rtc/rtc-m41t80.c | 1 +
>> >> 1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
>> >> index d107a8e..1aa57d8 100644
>> >> --- a/drivers/rtc/rtc-m41t80.c
>> >> +++ b/drivers/rtc/rtc-m41t80.c
>> >> @@ -81,6 +81,7 @@ static const struct i2c_device_id m41t80_id[] = {
>> >> { "m41st85", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
>> >> { "m41st87", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ },
>> >> { "rv4162", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
>> >> + { "rv4162c7", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT },
>> >> { }
>> >> };
>> >> MODULE_DEVICE_TABLE(i2c, m41t80_id);
>> >> -- 1.9.1
>> >>
>> >
>> > --
>> > Alexandre Belloni, Free Electrons
>> > Embedded Linux, Kernel and Android engineering
>> > http://free-electrons.com
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-14 7:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-13 20:39 [PATCH] rtc: support for rv4162c7 Tomas Krcka
2016-04-13 22:49 ` Alexandre Belloni
2016-04-14 6:29 ` Tomas Krcka
2016-04-14 7:19 ` Alexandre Belloni
2016-04-14 7:24 ` Tomas Krcka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).