* [PATCH] crypto: brcm - Fix SHA3-512 algorithm failure
@ 2017-06-23 6:45 Raveendra Padasalagi
2017-06-23 8:33 ` Anup Patel
0 siblings, 1 reply; 2+ messages in thread
From: Raveendra Padasalagi @ 2017-06-23 6:45 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Rob Rice, Scott Branden, Ray Jui,
Steve Lin, linux-crypto
Cc: bcm-kernel-feedback-list, linux-kernel, Raveendra Padasalagi
In Broadcom SPU driver, due to missing break statement
in spu2_hash_xlate() while mapping SPU2 equivalent
SHA3-512 value, -EINVAL is chosen and hence leading to
failure of SHA3-512 algorithm. This patch fixes the same.
Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
---
drivers/crypto/bcm/spu2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/bcm/spu2.c b/drivers/crypto/bcm/spu2.c
index ef04c97..bf7ac62 100644
--- a/drivers/crypto/bcm/spu2.c
+++ b/drivers/crypto/bcm/spu2.c
@@ -302,6 +302,7 @@ static int spu2_hash_mode_xlate(enum hash_mode hash_mode,
break;
case HASH_ALG_SHA3_512:
*spu2_type = SPU2_HASH_TYPE_SHA3_512;
+ break;
case HASH_ALG_LAST:
default:
err = -EINVAL;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: brcm - Fix SHA3-512 algorithm failure
2017-06-23 6:45 [PATCH] crypto: brcm - Fix SHA3-512 algorithm failure Raveendra Padasalagi
@ 2017-06-23 8:33 ` Anup Patel
0 siblings, 0 replies; 2+ messages in thread
From: Anup Patel @ 2017-06-23 8:33 UTC (permalink / raw)
To: Raveendra Padasalagi
Cc: Herbert Xu, David S. Miller, Rob Rice, Scott Branden, Ray Jui,
Steve Lin, linux-crypto, BCM Kernel Feedback, Linux Kernel
On Fri, Jun 23, 2017 at 12:15 PM, Raveendra Padasalagi
<raveendra.padasalagi@broadcom.com> wrote:
> In Broadcom SPU driver, due to missing break statement
> in spu2_hash_xlate() while mapping SPU2 equivalent
> SHA3-512 value, -EINVAL is chosen and hence leading to
> failure of SHA3-512 algorithm. This patch fixes the same.
>
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/crypto/bcm/spu2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/bcm/spu2.c b/drivers/crypto/bcm/spu2.c
> index ef04c97..bf7ac62 100644
> --- a/drivers/crypto/bcm/spu2.c
> +++ b/drivers/crypto/bcm/spu2.c
> @@ -302,6 +302,7 @@ static int spu2_hash_mode_xlate(enum hash_mode hash_mode,
> break;
> case HASH_ALG_SHA3_512:
> *spu2_type = SPU2_HASH_TYPE_SHA3_512;
> + break;
> case HASH_ALG_LAST:
> default:
> err = -EINVAL;
> --
> 1.9.1
>
This should go in linux-stable too.
Please CC Linux stable and include "Fixes:".
Regards,
Anup
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-23 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 6:45 [PATCH] crypto: brcm - Fix SHA3-512 algorithm failure Raveendra Padasalagi
2017-06-23 8:33 ` Anup Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).